On Wed, Mar 21, 2012 at 3:33 AM, Philip Martin <philip.mar...@wandisco.com> wrote: > Joe Swatosh <joe.swat...@gmail.com> writes: > >> Before r1293375, the node that represented 'diff1.txt' in this walk >> had the "prop_mod" member set true. After r1293375, the "prop_mod" >> member for this node is false. Since the implementation of >> Svn::Info#get_diff_recurse checks "prop_mod" member before attempting >> to collect the property changes on the node, the test started failing. > > I don't understand why prop_mod is no longer being set.
Because replay is no longer setting it? > >> My second patch removes the (optimization?) check for the "prop_mod" >> member and thus always get the properties from the prior revision and >> compares them with the current version. Making the test pass again for >> me. > > That also looks dubious to me. > >> Is the prop_mod not being set in this scenario for this node the >> desired behavior? > > In the past a property delete caused prop_mod to be set and now it does > not. The Subversion core is still reporting the property delete to the So, from the first sentence here, it sounds like the change to not report property deletions as "prop_mod" on the svn_repos_node_t is deliberate. > Ruby bindings layer at ChangedEditor.change_file_prop. I don't The Ruby bindings aren't using the ChangedEditor to track these changes. Currently, the bindings rely on the state of the svn_repos_node_t structs being passed out of the replay on the node from the baton passed to the editor. (I think I said that right). The state of the graph of nodes rooted in the one from the baton changed after r1293375. > understand the Ruby code so I don't know why prop_mod is no longer set > but it seems like a bug to me. > Because replay is no longer setting it? The bindings never *set* prop_mod on the svn_repos_node_t struct, they *use* it. Perhaps the bindings should be re-implemented to use the Editor to report these changes. But that doesn't change the question. > -- > uberSVN: Apache Subversion Made Easy > http://www.uberSVN.com
