Re: [patch] applying patch can fail with dry_run

2012-01-12 Thread Philip Martin
Stefan Küng writes: > $ svn co https://triplea.svn.sourceforge.net/svnroot/triplea/trunk wc -r3375 > $ svn patch test.patch wc --dry-run No error on my machine, it would simply create wc/src, and does without --dry-run. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com

Re: [PATCH] enabling ruby in the subversion build

2012-01-12 Thread Daniel Shahaf
On Thu, Jan 12, 2012, at 10:58, Vincent Batts wrote: > I haven't seen any commits or conversation about these patches. What's > the next step? Notwithstanding attempts to get attention to this thread, please file them as bugs --- with the 'patch' keyword and milestone 1.8-consider.

Re: [patch] applying patch can fail with dry_run

2012-01-12 Thread Philip Martin
Stefan Küng writes: > I'm not sure how this is triggered exactly. If you check the mailing > list thread on the TSVN mailing list: > http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2899409 > you can see that both the working copy and the patch to reproduce the > issue a

Re: [patch] applying patch can fail with dry_run

2012-01-12 Thread Stefan Küng
On 12.01.2012 21:13, Philip Martin wrote: Stefan Küng writes: Question is: do we need the notifications for deleting empty dirs in a dry-run? If yes, then this get's complicated: the error is thrown from svn_wc_walk_status() called in check_dir_empty. I could just not call that function in cas

Re: [patch] applying patch can fail with dry_run

2012-01-12 Thread Philip Martin
Stefan Küng writes: > Question is: do we need the notifications for deleting empty dirs in a > dry-run? If yes, then this get's complicated: > the error is thrown from svn_wc_walk_status() called in > check_dir_empty. I could just not call that function in case of a > dry-run, or catch that speci

Re: svn commit: r1223036 - /subversion/trunk/subversion/libsvn_delta/xdelta.c

2012-01-12 Thread Hyrum K Wright
On Sun, Dec 25, 2011 at 11:57 AM, Stefan Fuhrmann wrote: > On 25.12.2011 12:04, Bert Huijben wrote: >>> >>> -Original Message- > > >>> Log: >>> Minor xdelta optimization: find short matches at both end of the delta >>> window. >> >> All buildbots are red after this patch. >> >> At least on

Re: [patch] applying patch can fail with dry_run

2012-01-12 Thread Stefan Küng
On 12.01.2012 20:07, Philip Martin wrote: Stefan Küng writes: Could someone please review my patch? I'm sure you guys can see immediately whether this is save or not. If it's ok, then I'll commit it later. Index: subversion/libsvn_client/patch.c ==

Re: [patch] applying patch can fail with dry_run

2012-01-12 Thread Philip Martin
Stefan Küng writes: > Could someone please review my patch? I'm sure you guys can see > immediately whether this is save or not. If it's ok, then I'll commit > it later. Index: subversion/libsvn_client/patch.c === --- subversion/lib

Re: [PATCH] enabling ruby in the subversion build

2012-01-12 Thread Vincent Batts
On 20/12/11 21:08 -0800, Vincent Batts wrote: On 19/12/11 10:04 +0200, Daniel Shahaf wrote: Please send separate patches for separate functional changes. Getting the tests to pass with ruby1.8 would be a separate functional change than supporting ruby1.9. Okay after a bit of familiarizing mys

[patch] applying patch can fail with dry_run

2012-01-12 Thread Stefan Küng
Hi, When applying a patch in dry-run mode, svn can return an error even if the patching would work just fine. The returned error is then: The Node /newDirectory was not found If you want to reproduce this, here's the mailing list thread on the TSVN mailing list: http://tortoisesvn.tigris