Stefan Küng <tortoise...@gmail.com> writes: > Question is: do we need the notifications for deleting empty dirs in a > dry-run? If yes, then this get's complicated: > the error is thrown from svn_wc_walk_status() called in > check_dir_empty. I could just not call that function in case of a > dry-run, or catch that specific error and go on. But then the > notifications wouldn't be completely accurate anymore. > > So assuming we don't want to extend svn_wc_walk_status to take a > dry-run param, the notifications for deleting empty dirs wouldn't be > accurate. > > Should I just change delete_empty_dirs() to not use the dry_run param > and not get the notifications for those in a dry-run? > I think no notifications is better than inaccurate ones (at least in a > dry-run).
I'm not clear what problem the patch is triggering. I assume the patch deletes one or more files but then what happens? At present a --dry-run patch that deletes a file will track the deletions and notify about a directory that would be empty and deleted, we don't want to lose that feature. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
