Re: [PATCH] commit --include-externals (v2)

On 11/04/2011 12:22 PM, Julian Foad wrote: > Hi Neels. Brief response. ...yet a first class review, thanks a lot Julian! > Looks like a good improvement. > > svn_wc__committable_external_info_t: Use the new 'svn_kind_t' instead of > svn_node_kind_t. doh! > svn_client_commit6(): Could you ext

Re: [PATCH] commit --include-externals (v2)

On 11/04/2011 01:29 PM, Bert Huijben wrote: >> From: C. Michael Pilato [mailto:cmpil...@collab.net] > +0 on including the support to allow the commits. (I haven't reviewed the > patch in detail yet, but the idea is good) > > -0 to -0.5 on making it configurable as default behavior. > > As projec

[PATCH] configure: pre-create build directories for VPATH builds

With r1197804, I tried: svn export ~/src/subversion svn-test cd svn-test ./autogen.sh mkdir BUILD cd BUILD ../configure --prefix=$HOME/opt/subversion make extraclean-swig The result: for d in /tmp/svn-test/BUILD/subversion/bindings/

RE: svn_wc_adm_probe_open3 fails on windows

> -Original Message- > From: Barry Scott [mailto:ba...@barrys-emacs.org] > Sent: vrijdag 4 november 2011 19:57 > To: Bert Huijben > Cc: 'Subversion Development' > Subject: Re: svn_wc_adm_probe_open3 fails on windows > > > On 4 Nov 2011, at 11:10, Bert Huijben wrote: > > > > > > >>

Re: svn_wc_adm_probe_open3 fails on windows

On 4 Nov 2011, at 11:10, Bert Huijben wrote: > > >> -Original Message- >> From: Barry Scott [mailto:ba...@barrys-emacs.org] >> Sent: vrijdag 4 november 2011 12:06 >> To: Subversion Development >> Subject: svn_wc_adm_probe_open3 fails on windows >> >> I know that you have marked svn_wc_

Re: Editor v2 - suggestions and queries

Hi Greg. Thanks for the detailed response. First on one point from Hyrum: Hyrum Wright wrote: @@ -698,57 +760,51 @@ * Create a new directory at @a relpath. [...] * - * If this add is expected to replace a previously existing file or - * directory at @a relpath, the revision

Re: [PATCH] commit --include-externals (v2)

On 11/04/2011 09:13 AM, Mark Phippard wrote: > On Fri, Nov 4, 2011 at 9:09 AM, C. Michael Pilato > wrote: > > On 11/04/2011 08:36 AM, Mark Phippard wrote: > > I can comment from a GUI tool perspective. In Subclipse, we have > always had > > this featur

Re: [PATCH] commit --include-externals (v2)

On Fri, Nov 4, 2011 at 9:09 AM, C. Michael Pilato wrote: > On 11/04/2011 08:36 AM, Mark Phippard wrote: > > I can comment from a GUI tool perspective. In Subclipse, we have always > had > > this feature. > > [...] > > > FWIW, I think that the command line client should have always included > > ex

Re: [PATCH] commit --include-externals (v2)

On 11/04/2011 08:36 AM, Mark Phippard wrote: > I can comment from a GUI tool perspective. In Subclipse, we have always had > this feature. [...] > FWIW, I think that the command line client should have always included > externals by default. I guess we cannot do that now, so having an option is

Re: [PATCH] commit --include-externals (v2)

On Thu, Nov 3, 2011 at 9:33 AM, Neels J Hofmeyr wrote: > I've rinsed and improved my proposed feature dubbed > svn commit --include-externals > (Related issues: #1167, #3563) > > I hope this will cut a much clearer path through the jungle that is > externals behavior. Now I'm hoping for some rev

RE: [PATCH] commit --include-externals (v2)

> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: vrijdag 4 november 2011 12:31 > To: Neels J Hofmeyr > Cc: Alexey Neyman; dev@subversion.apache.org > Subject: Re: [PATCH] commit --include-externals (v2) > > On 11/04/2011 06:55 AM, Neels J Hofmeyr wrote:

Re: [Issue 4048] wcng fails with 1.0.x servers

"Bert Huijben" writes: >> By experiment 1.0 does not remove incomplete from the whole tree, only >> from the >> anchor. svn_wc__do_update_cleanup calls svn_wc__tweak_entry and that >> doesn't >> clear incomplete as far as I can see. > > If the adm crawler notes an pre-existing incomplete director

Re: [PATCH] commit --include-externals (v2)

"C. Michael Pilato" writes: > On 11/04/2011 06:55 AM, Neels J Hofmeyr wrote: >> Right now my focus is still on the "inner" behavior and so far it seems most >> other devs have different things on their mind. I'm still gauging whether it >> is permissive or dismissive silence, +0 or -0 ;) > > +0 f

Re: [PATCH] commit --include-externals (v2)

On 11/04/2011 06:55 AM, Neels J Hofmeyr wrote: > Right now my focus is still on the "inner" behavior and so far it seems most > other devs have different things on their mind. I'm still gauging whether it > is permissive or dismissive silence, +0 or -0 ;) +0 from me. :-) -- C. Michael Pilato C

Re: 1.7.0 assert on svn_client_checkout with E235000

On 11/04/2011 10:53 AM, Barry Scott wrote: > > On 3 Nov 2011, at 11:48, C. Michael Pilato wrote: > >> On 11/02/2011 05:42 PM, Barry Scott wrote: >>> I wish that the canonical stuff was inside the svn_client_XXX API calls and >>> not >>> a burdon on callers. To my mind the svn.exe API and the svn

Re: [PATCH] commit --include-externals (v2)

Hi Neels.  Brief response. Looks like a good improvement. svn_wc__committable_external_info_t: Use the new 'svn_kind_t' instead of svn_node_kind_t. svn_client_commit6(): Could you extract the main chunk of added code as a separate function?  That would help me (the reader) quickly understand h

RE: svn_wc_adm_probe_open3 fails on windows

> -Original Message- > From: Barry Scott [mailto:ba...@barrys-emacs.org] > Sent: vrijdag 4 november 2011 12:06 > To: Subversion Development > Subject: svn_wc_adm_probe_open3 fails on windows > > I know that you have marked svn_wc_adm_probe_open3 as deprecated > however I assume you expec

svn_wc_adm_probe_open3 fails on windows

I know that you have marked svn_wc_adm_probe_open3 as deprecated however I assume you expect it to still work. And it does on Mac OS X. When called like this: svn_error_t *error = svn_wc_adm_probe_open3( &adm_access, NULL, norm_path.c_str(), false, 0, NULL, NULL, pool ); Where norm_path

Re: [PATCH] commit --include-externals (v2)

On 11/04/2011 05:47 AM, Alexey Neyman wrote: > Neels, > > Question from a user standpoint: would it be possible to request this > behavior > as default via some config file option? Yes, probably, as soon as we implement it, which I think we should do when the time comes (as in $HOME/.subversion

RE: [Issue 4048] wcng fails with 1.0.x servers

> -Original Message- > From: phi...@tigris.org [mailto:phi...@tigris.org] > Sent: donderdag 3 november 2011 19:17 > To: iss...@subversion.tigris.org > Subject: [Issue 4048] wcng fails with 1.0.x servers > > http://subversion.tigris.org/issues/show_bug.cgi?id=4048 > > > > > > >

Re: Patch ping, 5 years later: removing properties

Hi Alexey. In your original email , you described the problem this way. You have a tree imported into SVN from CVS, and another copy of it in which you have added Subversion properties such as svn:executable to

Re: 1.7.0 assert on svn_client_checkout with E235000

On 3 Nov 2011, at 11:48, C. Michael Pilato wrote: > On 11/02/2011 05:42 PM, Barry Scott wrote: >> I wish that the canonical stuff was inside the svn_client_XXX API calls and >> not >> a burdon on callers. To my mind the svn.exe API and the svn_client_XXX should >> accept the same strings and eit