On Thu, Nov 3, 2011 at 9:33 AM, Neels J Hofmeyr <ne...@elego.de> wrote:
> I've rinsed and improved my proposed feature dubbed > svn commit --include-externals > (Related issues: #1167, #3563) > > I hope this will cut a much clearer path through the jungle that is > externals behavior. Now I'm hoping for some reviews! > > The idea is to have file and dir externals behave the same way during > commit, and to provide a way to recursively commit all externals (that are > from the same repository and are not revision-pegged). > > Who'd have guessed, there are a few corners that would be good to have > others' opinions on. > > (To: CMike and Bert because you two were involved in the original > discussion: http://svn.haxx.se/dev/archive-2011-08/0617.shtml ) > I can comment from a GUI tool perspective. In Subclipse, we have always had this feature. When you commit we present a dialog with all the changes in the WC (including externals). We are able to include externals from the same repository in the commit and do it as a single commit. So obviously the underlying client commit API handles this as long as you tell it the targets. So I imagine your change is just about making the command line include changes in externals when you do a recursive commit? In Subclipse, if you have externals from a different repository we will also commit those, but of course it is in a separate call to the commit API. How are you handling externals from a different repository? FWIW, I think that the command line client should have always included externals by default. I guess we cannot do that now, so having an option is good. I kind of agree with Bert that I do not like the idea of making it configurable. -- Thanks Mark Phippard http://markphip.blogspot.com/
