Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Jun 01, 2011 at 01:22:40 +0200: > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: > > [[[ > > The usual namespace rules apply: only names that begin with "SVN_" > > and don't contain double underscores are considered part of the public > > API. Everyth

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 1:22 AM, Stefan Sperling wrote: > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: >> [[[ >> The usual namespace rules apply: only names that begin with "SVN_" >> and don't contain double underscores are considered part of the public >> API. Everything else i

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-31 Thread Johan Corveleyn
On Tue, May 31, 2011 at 12:44 PM, Johan Corveleyn wrote: ... > Maybe a new 'knob' should be added for this? To make it easier to > (stress) test the LCS ... sorry don't have time to do it myself now. Added the new 'knob' in r1129957 (with followup in r1129965). To disable the prefix/suffix scanni

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Stefan Sperling
On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: > [[[ > The usual namespace rules apply: only names that begin with "SVN_" > and don't contain double underscores are considered part of the public > API. Everything else is not officially supported. > ]]] > > Thinking: "I don't thin

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 1:11 AM, Stefan Sperling wrote: > On Tue, May 31, 2011 at 11:07:55PM -, jcor...@apache.org wrote: >> Author: jcorvel >> Date: Tue May 31 23:07:54 2011 >> New Revision: 1129957 >> >> URL: http://svn.apache.org/viewvc?rev=1129957&view=rev >> Log: >> Add another knob, to ma

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Stefan Sperling
On Tue, May 31, 2011 at 11:07:55PM -, jcor...@apache.org wrote: > Author: jcorvel > Date: Tue May 31 23:07:54 2011 > New Revision: 1129957 > > URL: http://svn.apache.org/viewvc?rev=1129957&view=rev > Log: > Add another knob, to make it possible to disable the prefix/suffix scanning > of the li

Re: [RFC] Final approach for issue #3702 (case-only renames on Windows)?

2011-05-31 Thread Johan Corveleyn
On Sun, May 29, 2011 at 9:42 AM, Stefan Küng wrote: > On 29.05.2011 08:43, Johan Corveleyn wrote: >> >> On Tue, May 24, 2011 at 11:02 AM, Johan Corveleyn >>  wrote: >>> >>> 1) Rev svn_client_args_to_target_array to take an argument "is_move". >>> That's really the only case where something special

Re: Are repos_id and repos_path supposed to be filled in for working nodes (op-depth > 0)?

2011-05-31 Thread Julian Foad
Ugh, this was a really poor email I tried to dash off in a hurry before stopping for the day. Some background was Bert suggested a couple of weeks back that I could add a validation that "where op_depth > 0: repos_path:repos_id:revision should match that of the op-root, extended by the right relpa

Are repos_id and repos_path supposed to be filled in for working nodes (op-depth > 0)?

2011-05-31 Thread Julian Foad
A question which I want to validate. wc-metadata.sql says: /* Repository location fields */ /* When op_depth == 0, these fields refer to the repository location of the BASE node, the location of the initial checkout. When op_depth != 0, they indicate where this node was copied/mov

Re: svn commit: r1129818 - /subversion/trunk/subversion/libsvn_wc/wc-checks.sql

2011-05-31 Thread Philip Martin
Johan Corveleyn writes: >> @@ -54,10 +54,9 @@ CREATE TEMPORARY TRIGGER validation_03 B >>  WHEN NOT ( >>     (new.op_depth = relpath_depth(new.local_relpath)) >>     OR >> -    ((SELECT COUNT(*) FROM nodes >> -      WHERE wc_id = new.wc_id AND op_depth = new.op_depth >> -        AND local_relpath

Re: svn commit: r1129818 - /subversion/trunk/subversion/libsvn_wc/wc-checks.sql

2011-05-31 Thread Julian Foad
On Tue, 2011-05-31 at 21:13 +0200, Johan Corveleyn wrote: > On Tue, May 31, 2011 at 7:37 PM, wrote: > > Author: philip > > Date: Tue May 31 17:37:33 2011 > > New Revision: 1129818 > > > > URL: http://svn.apache.org/viewvc?rev=1129818&view=rev > > Log: > > * subversion/libsvn_wc/wc-checks.sql > >

Re: svn commit: r1129818 - /subversion/trunk/subversion/libsvn_wc/wc-checks.sql

2011-05-31 Thread Johan Corveleyn
On Tue, May 31, 2011 at 7:37 PM, wrote: > Author: philip > Date: Tue May 31 17:37:33 2011 > New Revision: 1129818 > > URL: http://svn.apache.org/viewvc?rev=1129818&view=rev > Log: > * subversion/libsvn_wc/wc-checks.sql >  (validation_03): Use EXISTS rather than COUNT. > > Modified: >    subversio

Re: Roadmap : 1.7 Release Status : Test Review : XFails (update)

2011-05-31 Thread C. Michael Pilato
On 05/31/2011 10:34 AM, Bert Huijben wrote: >> 2) tree_conflict_tests.py >> Test # Mode Test Description >> -- - >>8XFAIL up/sw dir: add onto add [#3314(1.7.0)] > > Issue #3314 is "DAV can overwrite directories during copy". > > I had a hard time looking at

Re: possible improvement to svn log with "forward" revision range

2011-05-31 Thread C. Michael Pilato
On 05/30/2011 07:52 AM, Avalon wrote: > Could someone of the devs please take a closer look? > I am willing to improve the patch based on concrete suggestions. [...] Sure thing. I can see where you're going with the patch. I haven't taken the time to fully consider the appropriate, so consider

Re: svn commit: r1129802 - /subversion/trunk/subversion/libsvn_wc/wc-checks.sql

2011-05-31 Thread Hyrum K Wright
On Tue, May 31, 2011 at 7:03 AM, wrote: > Author: julianfoad > Date: Tue May 31 17:03:44 2011 > New Revision: 1129802 > > URL: http://svn.apache.org/viewvc?rev=1129802&view=rev > Log: > * subversion/libsvn_wc/wc-checks.sql >  (validation_03, validation_04): Use more efficient SQL expressions. I

Re: large number of large binary files in subversion

2011-05-31 Thread Daniel Shahaf
[ old thread, but I'd like to add this warning to the archives: ] > > > > If you ensure that no commits happen during the backup period you > > > > could use rsync instead. > > > > > > It is not safe to rsync live Subversion filesystems. (the result may or > > > may not be corrupt) > > > > That's

RE: svn commit: r1129698 - /subversion/trunk/subversion/svn/status.c

2011-05-31 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: dinsdag 31 mei 2011 16:52 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1129698 - > /subversion/trunk/subversion/svn/status.c > > On Tue, May 31, 2011 at 02:28:34PM -, rhuij...@apache.org wrote:

Re: svn commit: r1129698 - /subversion/trunk/subversion/svn/status.c

2011-05-31 Thread Stefan Sperling
On Tue, May 31, 2011 at 02:28:34PM -, rhuij...@apache.org wrote: > Author: rhuijben > Date: Tue May 31 14:28:34 2011 > New Revision: 1129698 > > URL: http://svn.apache.org/viewvc?rev=1129698&view=rev > Log: > * subversion/svn/status.c > (print_status): Document why prop_status is cleared. >

RE: Roadmap : 1.7 Release Status : Test Review : XFails (update)

2011-05-31 Thread Bert Huijben
> -Original Message- > From: Paul Burba [mailto:ptbu...@gmail.com] > Sent: dinsdag 31 mei 2011 16:05 > To: Subversion Development > Subject: Roadmap : 1.7 Release Status : Test Review : XFails (update) > > A quick update: A while back we made an effort to ensure that all > XFail tests ha

Roadmap : 1.7 Release Status : Test Review : XFails (update)

2011-05-31 Thread Paul Burba
A quick update: A while back we made an effort to ensure that all XFail tests had an associated issue. The good news is that all of these tests do have an associated issue. The bad news is that there are three with associated issues that are marked as resolved: 1) externals_tests.py Test # Mod

Re: [PATCH] Factor out test repo creation func - help needed

2011-05-31 Thread Julian Foad
On Fri, 2011-05-27 at 21:27 +0100, Julian Foad wrote: > In preparation for installing temp triggers for DB validation, I'm > trying to do a simple factoring-out of a WC DB creation func, but it's > failing. I'm out of time now so if anybody wants to debug for me please > feel free! > > Error on r

Re: svn commit: r1129641 - in /subversion/trunk/subversion: include/private/svn_fs_util.h libsvn_fs/fs-loader.c libsvn_repos/dump.c tests/cmdline/svnadmin_tests.py

2011-05-31 Thread Daniel Shahaf
s...@apache.org wrote on Tue, May 31, 2011 at 12:23:05 -: > Author: stsp > Date: Tue May 31 12:23:05 2011 > New Revision: 1129641 > > URL: http://svn.apache.org/viewvc?rev=1129641&view=rev > Log: > Make 'svnadmin verify' error out if an invalid path is found in the > repository. > Thanks :-

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-31 Thread Julian Foad
Thanks. Committed in r1129621. I made some minor cosmetic tweaks to the code and changed some wording in the log message. - Julian

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-31 Thread Johan Corveleyn
On Tue, May 31, 2011 at 12:03 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Tue, May 31, 2011 at 02:53:47 +0200: >> - Take a closer look at measuring the overhead of the token counting. >> Maybe you can also provide some numbers here? I think a good test for >> measuring this in practice is:

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-31 Thread Daniel Shahaf
Johan Corveleyn wrote on Tue, May 31, 2011 at 02:53:47 +0200: > - Take a closer look at measuring the overhead of the token counting. > Maybe you can also provide some numbers here? I think a good test for > measuring this in practice is: > 1. take a very large file > 2. change a line in the be

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-31 Thread Noorul Islam K M
Julian Foad writes: > On Tue, 2011-05-31 at 14:52 +0530, Noorul Islam K M wrote: > >> Julian Foad writes: >> >> > Noorul Islam K M wrote: >> > >> >> Noorul Islam K M writes: >> >> > Julian Foad writes: >> > [...] >> >> >> * Use SVN_ERR instead of svn_error_clear. There 'kind' variable is not

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-31 Thread Julian Foad
On Tue, 2011-05-31 at 14:52 +0530, Noorul Islam K M wrote: > Julian Foad writes: > > > Noorul Islam K M wrote: > > > >> Noorul Islam K M writes: > >> > Julian Foad writes: > > [...] > >> >> * Use SVN_ERR instead of svn_error_clear. There 'kind' variable is not > >> >> guaranteed to be set to a

Re: Bug in exporting externals?

2011-05-31 Thread Noorul Islam K M
Noorul Islam K M writes: > Noorul Islam K M writes: > >> While working on issue 3799, in one of the review comments julianf said >> the following about number 10 test in external_tests.py. >> >> >> A/B/gamma is only an external: it does not appear in the WC until >> Subversion processes the ext

Re: Final(?) format bump for 1.7: Format 29

2011-05-31 Thread Julian Foad
Thanks for removing the code that I had put in to introduce validation triggers into the DB. I intended to remove that but hadn't yet done so. Monday was a public holiday in the UK and USA so I've only just seen your email announding this format bump. - Julian On Sun, 2011-05-29 at 15:56 +0200

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-31 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> > Julian Foad writes: > [...] >> >> * Use SVN_ERR instead of svn_error_clear. There 'kind' variable is not >> >> guaranteed to be set to a valid value if you the function throws an >> >> error. >> >> >> >> * Name the

Re: Bug in exporting externals?

2011-05-31 Thread Noorul Islam K M
Noorul Islam K M writes: > While working on issue 3799, in one of the review comments julianf said > the following about number 10 test in external_tests.py. > > > A/B/gamma is only an external: it does not appear in the WC until > Subversion processes the external definitions. > > It looks to m

Re: possible improvement to svn log with "forward" revision range

2011-05-31 Thread Philip Martin
Avalon writes: > i have attached a patch to the issue tracker (see > http://subversion.tigris.org/issues/show_bug.cgi?id=3830) and tested > the described use cases: > svn log -rX:Y PATH@PEG > - where Y > X and Y > PEG even if PATH@PEG has been deleted in revision Z, > where PEG < Z < Y >