On Tue, May 31, 2011 at 02:28:34PM -0000, rhuij...@apache.org wrote: > Author: rhuijben > Date: Tue May 31 14:28:34 2011 > New Revision: 1129698 > > URL: http://svn.apache.org/viewvc?rev=1129698&view=rev > Log: > * subversion/svn/status.c > (print_status): Document why prop_status is cleared. > > Modified: > subversion/trunk/subversion/svn/status.c >
Hmmm... that comment doesn't really seem to explain the reason for ignoring prop status. "Historic reasons" is just hand-waving since you don't provide pointers to old documentation or something similar. Can you provide a more precise explanation? > Modified: subversion/trunk/subversion/svn/status.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/status.c?rev=1129698&r1=1129697&r2=1129698&view=diff > ============================================================================== > --- subversion/trunk/subversion/svn/status.c (original) > +++ subversion/trunk/subversion/svn/status.c Tue May 31 14:28:34 2011 > @@ -137,6 +137,13 @@ print_status(const char *path, > char tree_status_code = ' '; > const char *tree_desc_line = ""; > > + /* For historic reasons svn ignores the property status for added nodes, > even > + if these nodes were copied and have local property changes. > + > + Note that it doesn't do this on replacements, or children of copies. > + > + ### Our test suite would catch more errors if we reported property > + changes on copies. */ > if (node_status == svn_wc_status_added) > prop_status = svn_wc_status_none; > >
