Re: [PATCH] Fix for issue 3787

2011-04-06 Thread Daniel Shahaf
Noorul Islam K M wrote on Thu, Apr 07, 2011 at 10:17:49 +0530: > Index: subversion/tests/cmdline/depth_tests.py > === > --- subversion/tests/cmdline/depth_tests.py (revision 1089373) > +++ subversion/tests/cmdline/depth_tests.py (w

Re: [PATCH] Fix for issue 3787

2011-04-06 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Mar 10, 2011 at 04:49:32PM +0530, Noorul Islam K M wrote: > >> >> >From issue tracker >> (http://subversion.tigris.org/issues/show_bug.cgi?id=3787) >> >> It would be ever-so-helpful to folks looking to capture and replicate a >> working >> copy sparse checkout

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Daniel Shahaf
Hyrum K Wright wrote on Wed, Apr 06, 2011 at 11:44:47 -0500: > On Wed, Apr 6, 2011 at 7:58 AM, Greg Stein wrote: > >... > >>... > >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Tue Apr  5 21:53:47 2011 > >>... > >>  svn_error_t * > >> +svn_wc__db_changelist_list_notify(svn_wc_notify_func2_t

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Branko Čibej
On 06.04.2011 16:17, C. Michael Pilato wrote: > I'd love to see a better suggestion, ideally one that avoids the glut of new > queries and bifurcation of the "depth" concept into 3 or 4 different handler > functions such as what I recall was the case for what should have been a > relatively simple

r1089593 bumps the WC format

2011-04-06 Thread Philip Martin
Philip Martin writes: > To fix this I plan to store relpaths instead of names. There will be no > change to the SQLite tables, just to the way the existing columns are > used by the code. I'll bump the WC format and autoupgrade existing > working copies. r1089593 bumps the WC format, using thi

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Hyrum K Wright
On Wed, Apr 6, 2011 at 7:58 AM, Greg Stein wrote: >... >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Tue Apr  5 21:53:47 2011 >>... >>  svn_error_t * >> +svn_wc__db_changelist_list_notify(svn_wc_notify_func2_t notify_func, >> +                                  void *notify_baton, >> +

Re: WC format bump: store conflict files by relpath rather than name

2011-04-06 Thread Philip Martin
"C. Michael Pilato" writes: >> I've got the new code working (not started on the upgrade code). The >> change spilled over into the public API in the form of the >> svn_wc_conflict_description2_t structure. This contains the names of >> the conflict files, but it is also used within libsvn_wc a

Re: WC format bump: store conflict files by relpath rather than name

2011-04-06 Thread C. Michael Pilato
On 04/06/2011 11:40 AM, Philip Martin wrote: > Philip Martin writes: > >> Text and property conflict file names are stored in ACTUAL_NODE as >> simple names and the WC code has to do path manipulation to obtain the >> path from name. For the property conflict file the manipulation is >> differen

Re: WC format bump: store conflict files by relpath rather than name

2011-04-06 Thread Philip Martin
Philip Martin writes: > Text and property conflict file names are stored in ACTUAL_NODE as > simple names and the WC code has to do path manipulation to obtain the > path from name. For the property conflict file the manipulation is > different for files and directories and this is a problem for

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Philip Martin
Greg Stein writes: > Note: beyond the review below, I'm registering a general concern > around this notion of "hey! let's drop off this data into some global > variables^W^Woh, I mean the wc state database... and then some time > later, we'll perform some operation around them". > > This is *so*

Re: Questions before applying for GSOC

2011-04-06 Thread Justin Peng
Got it, thanks! 2011/4/6 C. Michael Pilato : > I would imagine that Subversion is under the ASF umbrella, yes. > > On 04/06/2011 10:47 AM, Justin Peng wrote: >> Hi, Stefan. Which project should I choose to submit my application on >> GSOC website, please? I haven't found subversion in the separate

Re: Questions before applying for GSOC

2011-04-06 Thread C. Michael Pilato
I would imagine that Subversion is under the ASF umbrella, yes. On 04/06/2011 10:47 AM, Justin Peng wrote: > Hi, Stefan. Which project should I choose to submit my application on > GSOC website, please? I haven't found subversion in the separate > project list, is it under the umbrella of the Apac

Re: Questions before applying for GSOC

2011-04-06 Thread Justin Peng
Hi, Stefan. Which project should I choose to submit my application on GSOC website, please? I haven't found subversion in the separate project list, is it under the umbrella of the Apache Software Foundation? Thanks! 2011/4/6 Stefan Sperling : > On Tue, Apr 05, 2011 at 12:18:11PM +0200, Stefan Spe

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread C. Michael Pilato
On 04/06/2011 08:58 AM, Greg Stein wrote: > Note: beyond the review below, I'm registering a general concern > around this notion of "hey! let's drop off this data into some global > variables^W^Woh, I mean the wc state database... and then some time > later, we'll perform some operation around the

Re: Questions before applying for GSOC

2011-04-06 Thread Justin Peng
It's excited to receive from you, Stefan. After read the document advised by you earnestly, I focused on two issues below: 1.)Allow the test suite to be run in production environments. 2.)Show progress output. I'm not so sure 2.)Show progress output is valid, as the idea list seems outdated. A

Re: WC format bump: store conflict files by relpath rather than name

2011-04-06 Thread Greg Stein
On Wed, Apr 6, 2011 at 08:55, Geoff Rowell wrote: > On Tue, Apr 5, 2011 at 6:56 PM, Greg Stein wrote: >> Sounds good to me. >> On Apr 5, 2011 4:18 AM, "Philip Martin" wrote: >>> Text and property conflict file names are stored in ACTUAL_NODE as >>> simple names and the WC code has to do path man

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Greg Stein
Note: beyond the review below, I'm registering a general concern around this notion of "hey! let's drop off this data into some global variables^W^Woh, I mean the wc state database... and then some time later, we'll perform some operation around them". This is *so* ripe for danger, I'm depressed.

Re: WC format bump: store conflict files by relpath rather than name

2011-04-06 Thread Geoff Rowell
On Tue, Apr 5, 2011 at 6:56 PM, Greg Stein wrote: > Sounds good to me. > On Apr 5, 2011 4:18 AM, "Philip Martin" wrote: >> Text and property conflict file names are stored in ACTUAL_NODE as >> simple names and the WC code has to do path manipulation to obtain the >> path from name. For the proper

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Hyrum K Wright
On Tue, Apr 5, 2011 at 6:09 PM, Bert Huijben wrote: > > >> -Original Message- >> From: hwri...@apache.org [mailto:hwri...@apache.org] >> Sent: dinsdag 5 april 2011 23:54 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: >> ad

Re: Questions before applying for GSOC

2011-04-06 Thread Stefan Sperling
On Tue, Apr 05, 2011 at 12:18:11PM +0200, Stefan Sperling wrote: > On Tue, Apr 05, 2011 at 11:28:04AM +0800, Justin Peng wrote: > > 2.) Who will be the mentors this GSOC? > > I would sign up to be mentor and review proposals if there is interest. I have now signed up as a mentor and will review a

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

2011-04-06 Thread Philip Martin
"Bert Huijben" writes: > This breaks the build on systems that don't use 64 bit for int. (So > this breaks 32 bit unix and 32 and 64 bit Windows) Very few platforms use 64-bit int, 64-bit Linux does not. It's still a bug, but not always (ever?) visible on 64-bit Linux due to the calling convent