Re: svn commit: r1082806 - in /subversion/trunk: notes/wc_node_walkers.txt subversion/include/private/svn_wc_private.h subversion/libsvn_client/ra.c subversion/libsvn_wc/node.c

2011-03-17 Thread Ivan Zhakov
On Fri, Mar 18, 2011 at 06:20, C. Michael Pilato wrote: > On 03/17/2011 10:52 PM, cmpil...@apache.org wrote: >> Author: cmpilato >> Date: Fri Mar 18 02:52:57 2011 >> New Revision: 1082806 >> >> URL: http://svn.apache.org/viewvc?rev=1082806&view=rev >> Log: >> Eliminate another node walk, this time

Re: svn commit: r1082806 - in /subversion/trunk: notes/wc_node_walkers.txt subversion/include/private/svn_wc_private.h subversion/libsvn_client/ra.c subversion/libsvn_wc/node.c

2011-03-17 Thread C. Michael Pilato
On 03/17/2011 10:52 PM, cmpil...@apache.org wrote: > Author: cmpilato > Date: Fri Mar 18 02:52:57 2011 > New Revision: 1082806 > > URL: http://svn.apache.org/viewvc?rev=1082806&view=rev > Log: > Eliminate another node walk, this time in the invalidate_wc_prop() RA > callback function. In a sparse

Re: Property storage / modification in WC-NG

2011-03-17 Thread C. Michael Pilato
On 03/17/2011 03:43 PM, Greg Stein wrote: > Dude. If you want to delete *one* prop from the dav_cache, then just torch > them all (ie. set to null). HTTPv2 does not use them. HTTPv1 only uses the > vsn URL. And it is a cache. > > So don't be tricky. Blast the entire dav_cache rather than tweak it.

Re: Property storage / modification in WC-NG

2011-03-17 Thread Julian Foad
Greg Stein wrote: > I'd thought about removing them long ago, or at least moving them out into > helper/utility functions. So I say nuke them! Gone. r1082690. Thanks. - Julian > On Mar 17, 2011 5:29 PM, "Julian Foad" wrote: > > Mike, Greg, > > > > Is it OK with you if I remove the single-pro

Re: [RFC] Rationalize WC internal API to read pristine and working versions

2011-03-17 Thread Julian Foad
Greg Stein wrote: > On Mar 17, 2011 1:37 PM, "Julian Foad" > wrote: > > > > I'd like to rationalize this set of internal libsvn_wc functions: > > Is this something that needs to be fixed for 1.7? Not *specifically*, it's just something that makes my life harder every time I have to deal with any

Re: svn commit: r1082665 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_pristine.c wc_db_private.h wc_db_wcroot.c

2011-03-17 Thread Hyrum K Wright
Yep. On Thu, Mar 17, 2011 at 3:03 PM, Greg Stein wrote: > Are you going to propagate this out to the wc_db API too? > > On Mar 17, 2011 7:54 PM, wrote: >> >> Author: hwright >> Date: Thu Mar 17 19:53:53 2011 >> New Revision: 1082665 >> >> URL: http://svn.apache.org/viewvc?rev=1082665&view=rev >>

Re: svn commit: r1082650 - /subversion/trunk/subversion/libsvn_wc/wc-queries.sql

2011-03-17 Thread Philip Martin
Greg Stein writes: > On Mar 17, 2011 7:19 PM, wrote: >> >> Author: philip >> Date: Thu Mar 17 19:19:11 2011 >> New Revision: 1082650 >> >> URL: http://svn.apache.org/viewvc?rev=1082650&view=rev >> Log: >> Only single statements in wc-queries.sql are executed, anything after >> a semi-colon is ig

Re: svn commit: r1082650 - /subversion/trunk/subversion/libsvn_wc/wc-queries.sql

2011-03-17 Thread Greg Stein
Maybe we could rename these to GROUP_ to acknowledge their multiple statements, and how to run them? On Mar 17, 2011 7:59 PM, "Greg Stein" wrote: > On Mar 17, 2011 7:19 PM, wrote: >> >> Author: philip >> Date: Thu Mar 17 19:19:11 2011 >> New Revision: 1082650 >> >> URL: http://svn.apache.org/view

Re: svn commit: r1082665 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_pristine.c wc_db_private.h wc_db_wcroot.c

2011-03-17 Thread Greg Stein
Are you going to propagate this out to the wc_db API too? On Mar 17, 2011 7:54 PM, wrote: > > Author: hwright > Date: Thu Mar 17 19:53:53 2011 > New Revision: 1082665 > > URL: http://svn.apache.org/viewvc?rev=1082665&view=rev > Log: > Make the 'always open wc.db as readwrite' hack official. This

Re: svn commit: r1082658 - in /subversion/trunk/subversion: include/private/ libsvn_client/ libsvn_fs_base/ libsvn_fs_base/util/ libsvn_subr/ libsvn_wc/ tests/cmdline/

2011-03-17 Thread Paul Burba
On Thu, Mar 17, 2011 at 3:52 PM, Greg Stein wrote: > On Mar 17, 2011 7:40 PM, wrote: >> >> Author: pburba >> Date: Thu Mar 17 19:40:07 2011 >> New Revision: 1082658 >> >> URL: http://svn.apache.org/viewvc?rev=1082658&view=rev >> Log: >> Leverage the recent improvements to svn proplist -R[1] so th

Re: svn commit: r1082650 - /subversion/trunk/subversion/libsvn_wc/wc-queries.sql

2011-03-17 Thread Greg Stein
On Mar 17, 2011 7:19 PM, wrote: > > Author: philip > Date: Thu Mar 17 19:19:11 2011 > New Revision: 1082650 > > URL: http://svn.apache.org/viewvc?rev=1082650&view=rev > Log: > Only single statements in wc-queries.sql are executed, anything after > a semi-colon is ignored. That means that some sta

Re: svn commit: r1082658 - in /subversion/trunk/subversion: include/private/ libsvn_client/ libsvn_fs_base/ libsvn_fs_base/util/ libsvn_subr/ libsvn_wc/ tests/cmdline/

2011-03-17 Thread Greg Stein
On Mar 17, 2011 7:40 PM, wrote: > > Author: pburba > Date: Thu Mar 17 19:40:07 2011 > New Revision: 1082658 > > URL: http://svn.apache.org/viewvc?rev=1082658&view=rev > Log: > Leverage the recent improvements to svn proplist -R[1] so that svn propget -R > can do away with svn_wc__node_walk_childre

Re: Property storage / modification in WC-NG

2011-03-17 Thread Greg Stein
Dude. If you want to delete *one* prop from the dav_cache, then just torch them all (ie. set to null). HTTPv2 does not use them. HTTPv1 only uses the vsn URL. And it is a cache. So don't be tricky. Blast the entire dav_cache rather than tweak it. On Mar 17, 2011 6:40 PM, "C. Michael Pilato" wrot

Re: [PATCH] Fix issue #3532, 'svn update' via ra_serf of locked file in locally deleted dir triggers assert and breaks WC

2011-03-17 Thread Philip Martin
Julian Foad writes: > However, this attempt at the patch is ugly. It stats the file to see if > it exists, and I just get the feeling it should be doing it some > "better" way. Something should be different about the structure of the > code - probably the larger tree conflict handling code and

Re: wc_db performance (was: wc_db API discussion)

2011-03-17 Thread Paul Burba
On Tue, Mar 15, 2011 at 6:22 PM, Paul Burba wrote: > On Mon, Mar 14, 2011 at 2:36 PM, Hyrum K Wright wrote: >> On Sat, Mar 12, 2011 at 6:47 AM, Stefan Sperling wrote: >>> On Fri, Mar 11, 2011 at 10:43:46PM -0500, Greg Stein wrote: 2011/3/11 Branko Čibej : >... > For the second tas

Re: Property storage / modification in WC-NG

2011-03-17 Thread Greg Stein
I'd thought about removing them long ago, or at least moving them out into helper/utility functions. So I say nuke them! On Mar 17, 2011 5:29 PM, "Julian Foad" wrote: > Mike, Greg, > > Is it OK with you if I remove the single-prop-get WC DB APIs, which are > unused? In light of what you're talking

Re: [RFC] Rationalize WC internal API to read pristine and working versions

2011-03-17 Thread Greg Stein
On Mar 17, 2011 1:37 PM, "Julian Foad" wrote: > > I'd like to rationalize this set of internal libsvn_wc functions: Is this something that needs to be fixed for 1.7? > > svn_wc__get_pristine_contents(path) > svn_wc__get_ultimate_base_contents(path) > > svn_wc__get_pristine_text_status(path) >

Re: Property storage / modification in WC-NG

2011-03-17 Thread C. Michael Pilato
That's fine with me. I'm actually off playing with custom SQLite functions at the moment, trying to find a way to write statements like "go delete all the version-url properties from the dav_cache for all the items in and under TARGET". On 03/17/2011 01:29 PM, Julian Foad wrote: > Mike, Greg, >

Subversion and OSLC

2011-03-17 Thread Nick Crossley
Subversion Developers, Some of you may already be aware of Open Services for Lifecycle Collaboration (OSLC), an open initiative being developed at open-services.net. OSLC is a community developing specifications for a set of REST services for linked data in product and software delivery teams. On

Re: [PATCH] Fix issue #3532, 'svn update' via ra_serf of locked file in locally deleted dir triggers assert and breaks WC

2011-03-17 Thread Julian Foad
p.s. Maybe if I fix issue #3525 "Locked file which is scheduled for delete causes tree conflict", this attempt to set a non-existent file read-only will simply go away. - Julian I (Julian Foad) wrote: > Help needed. > > This patch succeeds in fixing issue #3532 "'svn update' via ra_serf of > lo

Re: [Issue 3807] 'svn up' of a nonexistent child in a copied dir triggers an assertion

2011-03-17 Thread Daniel Shahaf
On Thu, 17 Mar 2011 09:21 -0500, "Hyrum K Wright" wrote: > On Mon, Mar 14, 2011 at 8:35 AM, Daniel Shahaf > wrote: > > hwri...@tigris.org wrote on Mon, Mar 14, 2011 at 05:59:26 -0700: > >> http://subversion.tigris.org/issues/show_bug.cgi?id=3807 > >> > >> --- Additional comments from hwri..

[PATCH] Fix issue #3532, 'svn update' via ra_serf of locked file in locally deleted dir triggers assert and breaks WC

2011-03-17 Thread Julian Foad
Help needed. This patch succeeds in fixing issue #3532 "'svn update' via ra_serf of locked file in locally deleted dir triggers assert and breaks WC". This avoids trying to set a file's permissions if the file does not in fact exist on disk - e.g. when the incoming change is just an unlock and th

Re: Property storage / modification in WC-NG

2011-03-17 Thread Julian Foad
Mike, Greg, Is it OK with you if I remove the single-prop-get WC DB APIs, which are unused? In light of what you're talking about I just want to check this won't be stepping on your toes. [[[ Remove unused single-prop-get functions from the WC DB API, because they were just clutter in the API.

Questions about this GSOC

2011-03-17 Thread yun lee
Hi, everyone. Nice to write in the mailing list. I'm a GSOC student volunteer for SVN. I have passed last year's GSOC with DERBY as my project. It's my last school year and also the 5th year that I use SVN in my developping, and I would love to choose SVN for this GSOC. So far, I have read throu

Re: Property storage / modification in WC-NG

2011-03-17 Thread C. Michael Pilato
On 03/17/2011 09:57 AM, Julian Foad wrote: > What both of you say makes sense. What I can add is an observation that > separating the props out into the schema would appear to benefit the > efficiency of bulk-data operations such as "svn pget -R svn:needs-lock". > I don't think it would have much

Re: [Issue 3807] 'svn up' of a nonexistent child in a copied dir triggers an assertion

2011-03-17 Thread Hyrum K Wright
On Mon, Mar 14, 2011 at 8:35 AM, Daniel Shahaf wrote: > hwri...@tigris.org wrote on Mon, Mar 14, 2011 at 05:59:26 -0700: >> http://subversion.tigris.org/issues/show_bug.cgi?id=3807 >> >> >> >> >> >> >> --- Additional comments from hwri...@tigris.org Mon Mar 14 05:59:26 >> -0700 2011 --- >

Re: Property storage / modification in WC-NG

2011-03-17 Thread Julian Foad
What both of you say makes sense. What I can add is an observation that separating the props out into the schema would appear to benefit the efficiency of bulk-data operations such as "svn pget -R svn:needs-lock". I don't think it would have much effect on per-node operations such as "update", "me

Re: Property storage / modification in WC-NG

2011-03-17 Thread Greg Stein
On Mar 16, 2011 5:34 PM, "C. Michael Pilato" wrote: > > On 03/16/2011 01:17 PM, Greg Stein wrote: > > On Wed, Mar 16, 2011 at 12:59, C. Michael Pilato wrote: > >> ... > >> to manage at least the "read" subset of these operations. But I find myself > >> wondering if we wouldn't be better served b

[RFC] Rationalize WC internal API to read pristine and working versions

2011-03-17 Thread Julian Foad
I'd like to rationalize this set of internal libsvn_wc functions: svn_wc__get_pristine_contents(path) svn_wc__get_ultimate_base_contents(path) svn_wc__get_pristine_text_status(path) svn_wc__text_base_path_to_read(path) svn_wc__ultimate_base_text_path(path) svn_wc__ultimate_base_text_

Re: svn delete fails when deleting multiple URLs with URL-encoded spaces

2011-03-17 Thread Simon Wilson
I have created issue #3839. Best regards, Simon http://www.zennaware.com On Mar 17, 2011, at 12:36 PM, Stefan Sperling wrote: On Thu, Mar 17, 2011 at 12:19:01PM +0100, Simon Wilson wrote: > I'm posting here for feedback before opening an issue with the Subversion > tracker. > Please feel fr

Re: svn delete fails when deleting multiple URLs with URL-encoded spaces

2011-03-17 Thread Stefan Sperling
On Thu, Mar 17, 2011 at 12:19:01PM +0100, Simon Wilson wrote: > I'm posting here for feedback before opening an issue with the Subversion > tracker. > Please feel free to file an issue. Thank you! > Passing multiple URLs to 'svn delete' generates the following error when one > or more of the U

svn delete fails when deleting multiple URLs with URL-encoded spaces

2011-03-17 Thread Simon Wilson
I'm posting here for feedback before opening an issue with the Subversion tracker. Passing multiple URLs to 'svn delete' generates the following error when one or more of the URLs contains a URL-encoded space (i.e. %20): URL 'file:///Users/me/dev/repo/lib/tags/2.0.3.008%2520(R2.0.3)' does not e

RE: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-17 Thread Bert Huijben
> -Original Message- > From: Arwin Arni [mailto:ar...@collab.net] > Sent: donderdag 17 maart 2011 7:43 > To: Julian Foad > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] Add --dry-run flag to "svn update" client command > > > Arwin Arni wrote: > >> On Tuesday 15 March 2011 08:34 PM

Re: wc_db API discussion

2011-03-17 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> Update with no changes on NFS disk: >> >> 1.6: 2s >> 1.7: 50s > > With the recent bump-post-update changes that 50s has become 23s. With the recent report-revisions per-dir changes that 23s has become 7.5s. -- Philip