Greg Stein wrote: > I'd thought about removing them long ago, or at least moving them out into > helper/utility functions. So I say nuke them!
Gone. r1082690. Thanks. - Julian > On Mar 17, 2011 5:29 PM, "Julian Foad" <julian.f...@wandisco.com> wrote: > > Mike, Greg, > > > > Is it OK with you if I remove the single-prop-get WC DB APIs, which are > > unused? In light of what you're talking about I just want to check this > > won't be stepping on your toes. > > > > [[[ > > Remove unused single-prop-get functions from the WC DB API, because they > > were just clutter in the API. The "read all props" and "write all > > props" APIs make a sensible interface by themselves and there are no > > "write one prop" interfaces at this level. > > > > * subversion/libsvn_wc/wc_db.h, > > subversion/libsvn_wc/wc_db.c > > (svn_wc__db_base_get_prop, svn_wc__db_read_prop): Remove. > > > > * subversion/tests/libsvn_wc/db-test.c > > (validate_node): Remove the testing of svn_wc__db_base_get_prop(). It > > still tests svn_wc__db_base_get_props(). There were no tests for > > svn_wc__db_read_prop(). > > ]]] > > > > - Julian > > > >
