Another svnadmin checksum mismatch

[[[ % $svnversion `.svn` 1081669M % $svn di `.svn` Index: subversion/libsvn_fs_fs/fs_fs.c === --- subversion/libsvn_fs_fs/fs_fs.c (revision 1081669) +++ subversion/libsvn_fs_fs/fs_fs.c (working copy) @@ -3349,6 +3349,7 @@ *

Re: svn commit: r1079686 - /subversion/trunk/subversion/libsvn_diff/parse-diff.c

style...@apache.org wrote on Wed, Mar 09, 2011 at 07:40:38 -: > Author: stylesen > Date: Wed Mar 9 07:40:38 2011 > New Revision: 1079686 > > URL: http://svn.apache.org/viewvc?rev=1079686&view=rev > Log: > Clean up some deprecated functions. > > * subversion/libsvn_diff/parse-diff.c > (scan

Re: svn commit: r1079592 - /subversion/trunk/subversion/svn/main.c

s...@apache.org wrote on Tue, Mar 08, 2011 at 22:51:52 -: > Author: stsp > Date: Tue Mar 8 22:51:51 2011 > New Revision: 1079592 > > URL: http://svn.apache.org/viewvc?rev=1079592&view=rev > Log: > * subversion/svn/main.c > (svn_cl__cmd_table): Document foreign repos merges in merge help tex

Re: svn commit: r1079508 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/commit_util.c libsvn_client/deprecated.c svn/notify.c

cmpil...@apache.org wrote on Tue, Mar 08, 2011 at 20:05:51 -: > Author: cmpilato > Date: Tue Mar 8 20:05:50 2011 > New Revision: 1079508 > > URL: http://svn.apache.org/viewvc?rev=1079508&view=rev > Log: > For issue #3752 ("Warn about committing copied directory at depth > 'empty'"), introduce

Re: svn commit: r1079400 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

pbu...@apache.org wrote on Tue, Mar 08, 2011 at 15:46:10 -: > Author: pburba > Date: Tue Mar 8 15:46:09 2011 > New Revision: 1079400 > > URL: http://svn.apache.org/viewvc?rev=1079400&view=rev > Log: > Follow-up to rr1076726, fix a flawed log -g test helper. > > * subversion/tests/cmdline/log

[l10n] Translation status report for trunk r1081665

Translation status report for trunk@r1081665 lang trans untrans fuzzy obs -- de2048 133 253 217 es1985 196 284 355 fr2170 11 27 24 it1839 342 478 174 ja1977

Re: [PATCH] Fix regression introduced in r1075802

On Tue, Mar 15, 2011 at 07:33:06AM +1000, Daniel Becroft wrote: > Hi, > > Below is a patch that fixes the regression introduced in r1075802. THe > thread related to this regress can > be found here: http://svn.haxx.se/dev/archive-2011-03/0145.shtml. > > Cheers, > Daniel B. > > [[[ > Fix regressi

Re: wc_db performance

On 14.03.2011 17:13, Stefan Sperling wrote: > On Mon, Mar 14, 2011 at 05:05:39PM +0100, Stefan Sperling wrote: >> The concern seems to be that invoking a notification callback could >> attempt to modify DB state, correct? Which would deadlock if you invoke >> the callback after starting a transacti

[PATCH] Fix regression introduced in r1075802

Hi, Below is a patch that fixes the regression introduced in r1075802. THe thread related to this regress can be found here: http://svn.haxx.se/dev/archive-2011-03/0145.shtml. Cheers, Daniel B. [[[ Fix regression introduced in r1075802, where conflict files were created during a dry-run merge.

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

On Mon, Mar 14, 2011 at 23:26, Lieven Govaerts wrote: > > > On Mon, Mar 14, 2011 at 8:52 PM, Ivan Zhakov wrote: >> >> On Mon, Mar 14, 2011 at 22:47, John Beranek wrote: >> > On 14/03/2011 19:45, Ivan Zhakov wrote: >> >> On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: >> >>> On 14/03/11 17:14

Re: [PATCH] Add --dry-run flag to "svn update" client command

On Mon, Mar 14, 2011 at 07:49:21PM +0200, 'Daniel Shahaf' wrote: > I'd have expected this discussion to take place prior to anyone writing a > patch. Whether or not the order of patch submission and discussion is a problem depends on the attitude of the person putting in the work. Arwin already s

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

On Mon, Mar 14, 2011 at 8:52 PM, Ivan Zhakov wrote: > On Mon, Mar 14, 2011 at 22:47, John Beranek wrote: > > On 14/03/2011 19:45, Ivan Zhakov wrote: > >> On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: > >>> On 14/03/11 17:14, Philip Martin wrote: > Ivan Zhakov writes: > > > I

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

Ivan Zhakov writes: > Authentication is one problem, because serf sends many pipelined > requests and gets 403 authorization required reply, and only after > that sends requests with authorization headers. This is place for > optimization. Auth will obviously contribute, but I can reproduce it w

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

On Mon, Mar 14, 2011 at 22:47, John Beranek wrote: > On 14/03/2011 19:45, Ivan Zhakov wrote: >> On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: >>> On 14/03/11 17:14, Philip Martin wrote: Ivan Zhakov writes: > I investigated your problem with high CPU usage and fixed in serf in

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

On 14/03/2011 19:45, Ivan Zhakov wrote: > On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: >> On 14/03/11 17:14, Philip Martin wrote: >>> Ivan Zhakov writes: >>> I investigated your problem with high CPU usage and fixed in serf in r1456. Could you please test it and confirm that probl

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: > On 14/03/11 17:14, Philip Martin wrote: >> Ivan Zhakov writes: >> >>> I investigated your problem with high CPU usage and fixed in serf in >>> r1456. Could you please test it and confirm that problem with high CPU >>> load is fixed in your case

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

John Beranek writes: > Hmm, your timings still don't match mine. I still see ra_serf being > (significantly) slower than ra_neon. With serf r1456 and SVN r1081484 > > Export over a LAN from a trunk server: > > trunk ra_neon: 1.42 > trunk ra_serf: 2.44 Neon uses a single REPORT request while serf

Re: wc_db performance (was: wc_db API discussion)

On Sat, Mar 12, 2011 at 6:47 AM, Stefan Sperling wrote: > On Fri, Mar 11, 2011 at 10:43:46PM -0500, Greg Stein wrote: >> 2011/3/11 Branko Čibej : >> >... >> > For the second task, I think the first order of business is to change >> > the wc-db tree crawler to do one query instead of zillions, or a

RE: [PATCH] Add --dry-run flag to "svn update" client command

>> Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: >> > Unless there are no objection I will commit this patch post I >> > receive a r1075802 regression fix(and testcase) from either Daniel >> > Becroft or Arwin. >> >> Hold on, are you suggesting to commit the two thousand, six h

Re: wc_db API discussion

Mark Phippard writes: > I think it should be faster overall. Like Ivan, I think status and > update on large working copies are areas where I would like to see > show significant improvements. > > I can live with some operations being comparable to 1.6. I do not > think we can accept any major

RE: [PATCH] Add --dry-run flag to "svn update" client command

Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: >> Unless there are no objection I will commit this patch post I >> receive a r1075802 regression fix(and testcase) from either Daniel >> Becroft or Arwin. >Hold on, are you suggesting to commit the two thousand, six hundred and >

Re: [PATCH] Add --dry-run flag to "svn update" client command

On 03/14/2011 01:49 PM, 'Daniel Shahaf' wrote: > Stefan Sperling wrote on Mon, Mar 14, 2011 at 18:36:21 +0100: >> I haven't yet seen any good suggestion for an alternative approach. >> >> Dry run implies carrying out every step made during an update expect >> making modifications to the working cop

Re: [PATCH] Add --dry-run flag to "svn update" client command

Stefan Sperling wrote on Mon, Mar 14, 2011 at 18:36:21 +0100: > I haven't yet seen any good suggestion for an alternative approach. > > Dry run implies carrying out every step made during an update expect > making modifications to the working copy. The suggestion to put dry-run > into a separate e

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

On 14/03/11 17:14, Philip Martin wrote: > Ivan Zhakov writes: > >> I investigated your problem with high CPU usage and fixed in serf in >> r1456. Could you please test it and confirm that problem with high CPU >> load is fixed in your case? > Hmm, your timings still don't match mine. I still se

Re: [PATCH] Add --dry-run flag to "svn update" client command

On Mon, Mar 14, 2011 at 06:22:11PM +0100, Bert Huijben wrote: > It adds an insane amount of conditionals. How are you going to test this and > maintain it? > > The complexity of sourcecode increases by every conditional. The testing approach taken by Arwin seems solid enough in my book. > I d

RE: [PATCH] Add --dry-run flag to "svn update" client command

> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: maandag 14 maart 2011 17:55 > To: Daniel Shahaf > Cc: Kamesh Jayachandran; dev@subversion.apache.org > Subject: Re: [PATCH] Add --dry-run flag to "svn update" client command > > On Mon, Mar 14, 2011 at 06:34:15PM

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

Ivan Zhakov writes: > I investigated your problem with high CPU usage and fixed in serf in > r1456. Could you please test it and confirm that problem with high CPU > load is fixed in your case? Export over a LAN, Server 1.6 Client 1.6/neon real0m8.286s 0m8.079s user0m2.890s 0m3.040s s

Re: svn commit: r1081390 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

On Mon, Mar 14, 2011 at 02:24:58PM -, kame...@apache.org wrote: > Author: kameshj > Date: Mon Mar 14 14:24:58 2011 > New Revision: 1081390 > > URL: http://svn.apache.org/viewvc?rev=1081390&view=rev > Log: > Adds an XFail test to catch regression created by r1075802 > > * subversion/tests/cmdl

RE: [PATCH] Add --dry-run flag to "svn update" client command

> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: maandag 14 maart 2011 17:34 > To: Kamesh Jayachandran > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] Add --dry-run flag to "svn update" client command > > Kamesh Jayachandran wrote on Fri, Mar 11, 2

Re: [PATCH] Add --dry-run flag to "svn update" client command

On Mon, Mar 14, 2011 at 06:34:15PM +0200, Daniel Shahaf wrote: > Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: > > Unless there are no objection I will commit this patch post I > > receive a r1075802 regression fix(and testcase) from either Daniel > > Becroft or Arwin. > > Hold

Re: [PATCH] Add --dry-run flag to "svn update" client command

Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: > Unless there are no objection I will commit this patch post I > receive a r1075802 regression fix(and testcase) from either Daniel > Becroft or Arwin. Hold on, are you suggesting to commit the two thousand, six hundred and sixty-t

Re: wc_db performance

On Mon, Mar 14, 2011 at 05:05:39PM +0100, Stefan Sperling wrote: > The concern seems to be that invoking a notification callback could > attempt to modify DB state, correct? Which would deadlock if you invoke > the callback after starting a transaction to tweak changelist information > but before t

Re: wc_db performance

On Mon, Mar 14, 2011 at 10:53:48AM -0400, C. Michael Pilato wrote: > > On 12.03.2011 13:47, Stefan Sperling wrote: > >> For others who want to jump in and help, here is a list of places > >> where the node walker is still being used. I'm not sure if we can > >> eliminate it everywhere before releas

Re: [PATCH] Fix for issue 3787

On Thu, Mar 10, 2011 at 04:49:32PM +0530, Noorul Islam K M wrote: > > >From issue tracker > (http://subversion.tigris.org/issues/show_bug.cgi?id=3787) > > It would be ever-so-helpful to folks looking to capture and replicate a > working > copy sparse checkouts configuration if 'svn info -R' woul

Re: wc_db performance

> On 12.03.2011 13:47, Stefan Sperling wrote: >> For others who want to jump in and help, here is a list of places >> where the node walker is still being used. I'm not sure if we can >> eliminate it everywhere before release, but each of these should >> be looked at to see whether we can use an al

Re: svn commit: r1081390 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

On Mon, Mar 14, 2011 at 02:24:58PM -, kame...@apache.org wrote: > Author: kameshj > Date: Mon Mar 14 14:24:58 2011 > New Revision: 1081390 > > URL: http://svn.apache.org/viewvc?rev=1081390&view=rev > Log: > Adds an XFail test to catch regression created by r1075802 > > * subversion/tests/cmdl

Re: [PATCH] Add a test to cover the regression introduced in r1075802

On 03/14/2011 06:11 PM, Arwin Arni wrote: On Monday 14 March 2011 11:40 AM, Arwin Arni wrote: On Monday 14 March 2011 02:47 AM, Daniel Becroft wrote: On Mon, Mar 14, 2011 at 7:06 AM, Daniel Becroft mailto:djcbecr...@gmail.com>> wrote: On Sat, Mar 12, 2011 at 1:50 AM, C. Michael Pilato mai

Re: [Issue 3807] 'svn up' of a nonexistent child in a copied dir triggers an assertion

hwri...@tigris.org wrote on Mon, Mar 14, 2011 at 05:59:26 -0700: > http://subversion.tigris.org/issues/show_bug.cgi?id=3807 > > > > > > > --- Additional comments from hwri...@tigris.org Mon Mar 14 05:59:26 -0700 > 2011 --- > As the assertion has been fixed, I'm tempted to close this

Re: svn commit: r1081130 - /subversion/trunk/subversion/include/svn_dirent_uri.h

On 03/13/2011 10:43 AM, danie...@apache.org wrote: > Author: danielsh > Date: Sun Mar 13 14:43:18 2011 > New Revision: 1081130 [...] > Modified: subversion/trunk/subversion/include/svn_dirent_uri.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_dirent_uri.h?rev=108

Using the Wimp decorator in the Python tests

I don't see any of the Python tests using @Wimp. How is it used? @Wimp @Wimp() TypeError: __init__() got an unexpected keyword argument 'issues' @Wimp('string') TypeError: __init__() takes at least 3 arguments (2 given) Looking at testcase.py the Wimp functions is different from the other dec

Re: [PATCH] Add a test to cover the regression introduced in r1075802

On Monday 14 March 2011 11:40 AM, Arwin Arni wrote: On Monday 14 March 2011 02:47 AM, Daniel Becroft wrote: On Mon, Mar 14, 2011 at 7:06 AM, Daniel Becroft > wrote: On Sat, Mar 12, 2011 at 1:50 AM, C. Michael Pilato mailto:cmpil...@collab.net>> wrote: O

Re: svn commit: r1081141 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

On Sun, Mar 13, 2011 at 7:57 PM, Ivan Zhakov wrote: > On Sun, Mar 13, 2011 at 18:38, wrote: > > Author: lgo > > Date: Sun Mar 13 15:38:01 2011 > > New Revision: 1081141 > > > > URL: http://svn.apache.org/viewvc?rev=1081141&view=rev > > Log: > > ra_serf: Drastically limit memory usage on large c

Re: svn commit: r1081141 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

On Sun, Mar 13, 2011 at 21:57, Ivan Zhakov wrote: > On Sun, Mar 13, 2011 at 18:38,   wrote: >> Author: lgo >> Date: Sun Mar 13 15:38:01 2011 >> New Revision: 1081141 >> >> URL: http://svn.apache.org/viewvc?rev=1081141&view=rev >> Log: >> ra_serf: Drastically limit memory usage on large checkouts.