Re: Breakage on trunk?

On 05.03.2011 01:16, John Beranek wrote: On 04/03/2011 23:02, Stefan Fuhrmann wrote: On 04.03.2011 12:32, John Beranek wrote: On 04/03/11 11:18, Philip Martin wrote: John Beranek writes: Oh, this is for a run of an installed copy of svnserve, as I don't have a: subversion/tests/libsvn_cli

Re: Breakage on trunk?

On 04/03/2011 23:02, Stefan Fuhrmann wrote: > On 04.03.2011 12:32, John Beranek wrote: >> On 04/03/11 11:18, Philip Martin wrote: >>> John Beranek writes: >>> Oh, this is for a run of an installed copy of svnserve, as I don't have a: subversion/tests/libsvn_client/.libs/lt-clie

Re: Last batch of performance improvements for 1.7

On 03.03.2011 12:53, Arnout van Meer wrote: On 3 March 2011 11:42, Arnout van Meer wrote: On 3 March 2011 08:36, Stefan Fuhrmann wrote: Hi Arnout, Thanks for your review! See my answers below. -- Stefan^2. On 28.02.2011 23:36, Arnout van Meer wrote: On 23 February 2011 08:43, Stefan Fuhrm

Re: crash during svn blame on windows 64-bit version

On 04.03.2011 14:15, Marc Haesen wrote: When doing the change of r1076556, should the define LOWER_7BITS_SET not always be mapped to 0x7f7f7f7f independent of the APR_SIZEOF_VOIDP setting? //#if SVN_UNALIGNED_ACCESS_IS_OK //#if APR_SIZEOF_VOIDP == 8 //# define LOWER_7BITS_SET 0x7f7f7f7f7f7f7f7f

Re: Breakage on trunk?

On 04.03.2011 12:32, John Beranek wrote: On 04/03/11 11:18, Philip Martin wrote: John Beranek writes: Oh, this is for a run of an installed copy of svnserve, as I don't have a: subversion/tests/libsvn_client/.libs/lt-client-test only: subversion/tests/libsvn_client/client-test [A wrapper s

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

On Fri, Mar 4, 2011 at 11:35 PM, Arwin Arni wrote: > On Friday 04 March 2011 05:15 PM, Philip Martin wrote: > >> Arwin Arni writes: >> >> On Friday 04 March 2011 04:52 PM, Philip Martin wrote: >>> Arwin Arni writes: Post this fix, I noticed that **merge --dry-run** throws an >

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

On Fri, Mar 04, 2011 at 07:05:33PM +0530, Arwin Arni wrote: > On Friday 04 March 2011 05:15 PM, Philip Martin wrote: > >Arwin Arni writes: > > > >>On Friday 04 March 2011 04:52 PM, Philip Martin wrote: > >>>Arwin Arni writes: > >>> > Post this fix, I noticed that **merge --dry-run** throws a

Re: svn commit: r1076741 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc_db.c wc_db.h

On Fri, Mar 04, 2011 at 11:10:17AM +, Philip Martin wrote: > s...@apache.org writes: > > > Author: stsp > > Date: Thu Mar 3 19:23:12 2011 > > New Revision: 1076741 > > > > URL: http://svn.apache.org/viewvc?rev=1076741&view=rev > > Log: > > Another step towards eliminating use of the node walk

Re: Breakage on trunk?

On 04/03/2011 15:07, Daniel Shahaf wrote: > John Beranek wrote on Fri, Mar 04, 2011 at 14:49:48 +: >> On 04/03/11 14:44, Daniel Shahaf wrote: >>> John Beranek wrote on Thu, Mar 03, 2011 at 17:54:04 +: Hi, This afternoon, I checked out the trunk from Subversion in order to >>>

Re: [PATCH v2] HTTPv2 allow client to control transaction name in protocol

On Fri, Mar 4, 2011 at 07:29, Philip Martin wrote: >... > Extend Subversion's v2 HTTP protocol to include URIs that allow the > client to define the transaction name visible in on the wire. > > If the client sends, or a proxy injects, an SVN-VTxn-Name header with > the POST request it defines the

Re: svn commit: r1078008 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On Fri, Mar 4, 2011 at 11:19, Hyrum K Wright wrote: > 2011/3/4 Branko Čibej : >> On 04.03.2011 16:33, hwri...@apache.org wrote: >>> Author: hwright >>> Date: Fri Mar  4 15:33:48 2011 >>> New Revision: 1078008 >>> >>> >>> -  scb.changelist = changelist; >>> - >>> -  SVN_ERR(with_db_txn(wcroot, loca

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On Fri, Mar 4, 2011 at 10:34, Hyrum K Wright wrote: >... > Reverted r1076645 and added the cast in r1078008. Thanks Hyrum!

Re: svn commit: r1078008 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011/3/4 Branko Čibej : > On 04.03.2011 16:33, hwri...@apache.org wrote: >> Author: hwright >> Date: Fri Mar  4 15:33:48 2011 >> New Revision: 1078008 >> >> >> -  scb.changelist = changelist; >> - >> -  SVN_ERR(with_db_txn(wcroot, local_relpath, set_changelist_txn, &scb, >> -                      s

Re: svn commit: r1078008 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On 04.03.2011 16:33, hwri...@apache.org wrote: > Author: hwright > Date: Fri Mar 4 15:33:48 2011 > New Revision: 1078008 > > > - scb.changelist = changelist; > - > - SVN_ERR(with_db_txn(wcroot, local_relpath, set_changelist_txn, &scb, > - scratch_pool)); > + SVN_ERR(with_

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On Thu, Mar 3, 2011 at 12:05 PM, Philip Martin wrote: > Greg Stein writes: > >> It is a lot of crap just to avoid a single cast. It makes the code >> more complicated than it needs to be. > > I don't see the cast as an improvement but I won't object if somebody > changes it (a bit like one variab

Re: Breakage on trunk?

John Beranek wrote on Fri, Mar 04, 2011 at 14:49:48 +: > On 04/03/11 14:44, Daniel Shahaf wrote: > > John Beranek wrote on Thu, Mar 03, 2011 at 17:54:04 +: > >> Hi, > >> > >> This afternoon, I checked out the trunk from Subversion in order to > >> build a dev system running 1.7. > >> > >> I

Re: Breakage on trunk?

On 04/03/11 14:44, Daniel Shahaf wrote: > John Beranek wrote on Thu, Mar 03, 2011 at 17:54:04 +: >> Hi, >> >> This afternoon, I checked out the trunk from Subversion in order to >> build a dev system running 1.7. >> >> I updated a sandbox I had lying around, made it 'extraclean', built and >> i

Re: Breakage on trunk?

John Beranek wrote on Thu, Mar 03, 2011 at 17:54:04 +: > Hi, > > This afternoon, I checked out the trunk from Subversion in order to > build a dev system running 1.7. > > I updated a sandbox I had lying around, made it 'extraclean', built and > installed serf 0.7.1, ran autogen.sh, ran config

Re: Breakage on trunk?

On 04/03/11 14:02, John Beranek wrote: > On 04/03/11 13:48, Philip Martin wrote: >> John Beranek writes: >> One thing you could try is identifying which revision causes the problem. I'm guessing that r1072301 will PASS, it would be good to know which is the first revision to FAIL.

Re: Subversion 1.7 through (squid) proxy

John Beranek wrote on Thu, Mar 03, 2011 at 22:12:08 +: > Following on from my earlier post, I thought I'd use my trunk Subversion > (built with ra_serf) to access some external Subversion repositories > from work. > > To get access I have to use the corporate Squid proxy, and that all > works

Re: [PATCH v2] HTTPv2 allow client to control transaction name in protocol

On 03/04/2011 07:29 AM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> Just a thought: Have you considered expanding the scope of the private >> resource space rather than using the magic prefix hack? You could add >> ".../!svn/vtxn/UUID" and ".../!svn/vtxr/UUID/..." to be alternate wa

Re: Breakage on trunk?

On 04/03/11 13:48, Philip Martin wrote: > John Beranek writes: > >>> One thing you could try is identifying which revision causes the >>> problem. I'm guessing that r1072301 will PASS, it would be good to >>> know which is the first revision to FAIL. >> >> Hmm, no - r1072301 FAILs too. > > But

Re: Breakage on trunk?

John Beranek writes: >> One thing you could try is identifying which revision causes the >> problem. I'm guessing that r1072301 will PASS, it would be good to >> know which is the first revision to FAIL. > > Hmm, no - r1072301 FAILs too. But it can't be crashing in svn_temp_deserializer__resol

Re: Breakage on trunk?

On 04/03/11 13:09, Philip Martin wrote: > John Beranek writes: > >>> That could be tricky. You are using 64-bit Fedora 14, what version of >>> gcc and APR are you using? I can't reproduce it on my Debian/oldstable >>> box. Fedora 14 is a cutting edge distribution, could it be a compiler >>> bu

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

On Friday 04 March 2011 05:15 PM, Philip Martin wrote: Arwin Arni writes: On Friday 04 March 2011 04:52 PM, Philip Martin wrote: Arwin Arni writes: Post this fix, I noticed that **merge --dry-run** throws an interactive conflict resolution dialog and create the merge-left and merge-right

Re: Breakage on trunk?

On 04/03/11 13:15, Philip Martin wrote: > John Beranek writes: > >> Oh, and my results with valgrind: >> >> PASS: lt-client-test 1: test svn_client__elide_mergeinfo_catalog >> PASS: lt-client-test 2: test svn_client_args_to_target_array >> PASS: lt-client-test 3: test svn_client_patch >> ==450

RE: crash during svn blame on windows 64-bit version

When doing the change of r1076556, should the define LOWER_7BITS_SET not always be mapped to 0x7f7f7f7f independent of the APR_SIZEOF_VOIDP setting? //#if SVN_UNALIGNED_ACCESS_IS_OK //#if APR_SIZEOF_VOIDP == 8 //# define LOWER_7BITS_SET 0x7f7f7f7f7f7f7f7f //# define BIT_7_SET 0x80808080808

Re: Breakage on trunk?

John Beranek writes: > Oh, and my results with valgrind: > > PASS: lt-client-test 1: test svn_client__elide_mergeinfo_catalog > PASS: lt-client-test 2: test svn_client_args_to_target_array > PASS: lt-client-test 3: test svn_client_patch > ==4509== Use of uninitialised value of size 8 > ==4509=

Re: Breakage on trunk?

On 04/03/11 12:45, Philip Martin wrote: > John Beranek writes: > >> On 04/03/11 11:52, Philip Martin wrote: >>> John Beranek writes: >>> Is there a recommended way to get -O0 into the compilation in Subversion build land? >>> >>> You can "configure --enable-debug" or "make EXTRA_CFLAGS

Re: Breakage on trunk?

John Beranek writes: >> That could be tricky. You are using 64-bit Fedora 14, what version of >> gcc and APR are you using? I can't reproduce it on my Debian/oldstable >> box. Fedora 14 is a cutting edge distribution, could it be a compiler >> bug? > > Fedora 14 is almost halfway to being obso

Re: Breakage on trunk?

On 04/03/11 12:45, Philip Martin wrote: > John Beranek writes: > >> On 04/03/11 11:52, Philip Martin wrote: >>> John Beranek writes: >>> Is there a recommended way to get -O0 into the compilation in Subversion build land? >>> >>> You can "configure --enable-debug" or "make EXTRA_CFLAGS

Re: Breakage on trunk?

John Beranek writes: > On 04/03/11 11:52, Philip Martin wrote: >> John Beranek writes: >> >>> Is there a recommended way to get -O0 into the compilation in Subversion >>> build land? >> >> You can "configure --enable-debug" or "make EXTRA_CFLAGS=-O0". > > OK, the test does indeed pass when the

Re: Breakage on trunk?

On 04/03/11 12:21, John Beranek wrote: > On 04/03/11 11:52, Philip Martin wrote: >> John Beranek writes: >> >>> Is there a recommended way to get -O0 into the compilation in Subversion >>> build land? >> >> You can "configure --enable-debug" or "make EXTRA_CFLAGS=-O0". > > OK, the test does indee

[PATCH v2] HTTPv2 allow client to control transaction name in protocol

"C. Michael Pilato" writes: > Just a thought: Have you considered expanding the scope of the private > resource space rather than using the magic prefix hack? You could add > ".../!svn/vtxn/UUID" and ".../!svn/vtxr/UUID/..." to be alternate ways to > address transactions and transaction roots (

Re: Breakage on trunk?

On 04/03/11 11:52, Philip Martin wrote: > John Beranek writes: > >> Is there a recommended way to get -O0 into the compilation in Subversion >> build land? > > You can "configure --enable-debug" or "make EXTRA_CFLAGS=-O0". OK, the test does indeed pass when the tree is built with just "make EXT

Re: Breakage on trunk?

On Fri, 2011-03-04 at 11:43 +, John Beranek wrote: > On 04/03/11 11:32, Julian Foad wrote: > > On Thu, 2011-03-03, John Beranek wrote: > >> Running tests in auth-test [1/88].success > >> Running tests in cache-test [2/88]success > >> Runni

Post-replace deletions - harvest_committables - issue #3468

Just a heads-up that I'm looking at "children of replaced directories cannot be deleted post-replace" . It refers to a big comment that was added in subversion/libsvn_client/commit_util.c:harvest_committables(), which is still there. This

Re: Breakage on trunk?

John Beranek writes: > Is there a recommended way to get -O0 into the compilation in Subversion > build land? You can "configure --enable-debug" or "make EXTRA_CFLAGS=-O0". -- Philip

Re: Breakage on trunk?

Daniel Shahaf writes: > /me 's workaround has been $prefix/apache2/build/libtool --mode=execute env > SHELL=$SHELL gdb --args ./subversion/svn/svn That's the proper, platform-independent way to do it. > (but the lt-$basename should be easier to work with) This works on Linux. It may not work

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

Arwin Arni writes: > On Friday 04 March 2011 04:52 PM, Philip Martin wrote: >> Arwin Arni writes: >> >>> Post this fix, I noticed that **merge --dry-run** throws an >>> interactive conflict resolution dialog and create the merge-left and >>> merge-right files. >> >> Does this apply to all files

Re: Breakage on trunk?

On 04/03/11 11:32, Julian Foad wrote: > On Thu, 2011-03-03, John Beranek wrote: >> Running tests in auth-test [1/88].success >> Running tests in cache-test [2/88]success >> Running tests in checksum-test [3/88].success

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

Philip Martin wrote on Fri, Mar 04, 2011 at 11:22:37 +: > It's long standing behaviour that removing the left/right files is one > way to resolve a conflict. /me learnt something new

Re: Breakage on trunk?

Philip Martin wrote on Fri, Mar 04, 2011 at 11:18:33 +: > John Beranek writes: > > > Oh, this is for a run of an installed copy of svnserve, as I don't have a: > > > > subversion/tests/libsvn_client/.libs/lt-client-test > > > > only: > > > > subversion/tests/libsvn_client/client-test > > [A w

Re: Breakage on trunk?

On 04/03/11 11:35, Philip Martin wrote: > John Beranek writes: > >> On 03/03/11 23:48, Philip Martin wrote: >>> John Beranek writes: >>> Forgot to note, same assertion failure: START: client-test lt-client-test: subversion/libsvn_subr/svn_temp_serializer.c:282: svn_temp_

Re: Breakage on trunk?

John Beranek writes: > On 03/03/11 23:48, Philip Martin wrote: >> John Beranek writes: >> >>> Forgot to note, same assertion failure: >>> >>> START: client-test >>> lt-client-test: subversion/libsvn_subr/svn_temp_serializer.c:282: >>> svn_temp_deserializer__resolve: Assertion `*ptr > buffer' fa

Re: Breakage on trunk?

On 04/03/11 11:18, Philip Martin wrote: > John Beranek writes: > >> Oh, this is for a run of an installed copy of svnserve, as I don't have a: >> >> subversion/tests/libsvn_client/.libs/lt-client-test >> >> only: >> >> subversion/tests/libsvn_client/client-test >> [A wrapper script I can't run wi

Re: Breakage on trunk?

On Thu, 2011-03-03, John Beranek wrote: > Running tests in auth-test [1/88].success > Running tests in cache-test [2/88]success > Running tests in checksum-test [3/88].success > Running tests in client-test [4/88]..

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

On Friday 04 March 2011 04:52 PM, Philip Martin wrote: Arwin Arni writes: Post this fix, I noticed that **merge --dry-run** throws an interactive conflict resolution dialog and create the merge-left and merge-right files. Does this apply to all files or just binary files? This applies only

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

Arwin Arni writes: > Post this fix, I noticed that **merge --dry-run** throws an > interactive conflict resolution dialog and create the merge-left and > merge-right files. Does this apply to all files or just binary files? > This alters the Working Copy (creating filename.merge-left.rXYZ, > fi

Re: [PATCH] Fix for issue 3826

On Thu, 2011-03-03 at 22:48 +0530, Noorul Islam K M wrote: > Julian Foad writes: > > > On Wed, 2011-03-02, Noorul Islam K M wrote: > > > >> Please find attached patch for issue 3826. All tests pass using 'make > >> check' > > [...] > >> Index: subversion/svn/diff-cmd.c > >> =

Re: Breakage on trunk?

John Beranek writes: > Oh, this is for a run of an installed copy of svnserve, as I don't have a: > > subversion/tests/libsvn_client/.libs/lt-client-test > > only: > > subversion/tests/libsvn_client/client-test > [A wrapper script I can't run with gdb] > > subversion/tests/libsvn_client/.libs/cli

Re: svn commit: r1076741 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc_db.c wc_db.h

s...@apache.org writes: > Author: stsp > Date: Thu Mar 3 19:23:12 2011 > New Revision: 1076741 > > URL: http://svn.apache.org/viewvc?rev=1076741&view=rev > Log: > Another step towards eliminating use of the node walker in > svn_wc_revision_status2(): use a DB query to determine if any absent > no

Re: Breakage on trunk?

On 04/03/11 11:00, John Beranek wrote: > On 03/03/11 23:48, Philip Martin wrote: >> John Beranek writes: >> >>> Forgot to note, same assertion failure: >>> >>> START: client-test >>> lt-client-test: subversion/libsvn_subr/svn_temp_serializer.c:282: >>> svn_temp_deserializer__resolve: Assertion `*p

Re: Breakage on trunk?

On 03/03/11 23:48, Philip Martin wrote: > John Beranek writes: > >> Forgot to note, same assertion failure: >> >> START: client-test >> lt-client-test: subversion/libsvn_subr/svn_temp_serializer.c:282: >> svn_temp_deserializer__resolve: Assertion `*ptr > buffer' failed. > > A stack trace please:

Re: svn commit: r1075802 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/merge.c tests/cmdline/merge_tests.py

On Tuesday 01 March 2011 06:30 PM, s...@apache.org wrote: Author: stsp Date: Tue Mar 1 13:00:47 2011 New Revision: 1075802 URL: http://svn.apache.org/viewvc?rev=1075802&view=rev Log: Fix issue #3686 - executable bit not set during merge. The cause was the special case in libsvn_client, which b