[PATCH] Remove dead code - was - Re: svn commit: r1067669

2011-02-22 Thread Dongsheng Song
On Sun, Feb 6, 2011 at 22:13, wrote: > Author: stefan2 > Date: Sun Feb 6 14:13:57 2011 > New Revision: 1067669 > > URL: http://svn.apache.org/viewvc?rev=1067669&view=rev > Log: > Merge all changes (r998649, r998843, r998852) from the > integrate-cache-membuffer branch. > > These patches introduc

Re: Further diff optimization ideas

2011-02-22 Thread Johan Corveleyn
On Mon, Feb 21, 2011 at 8:55 AM, Stefan Fuhrmann wrote: > On 15.02.2011 01:42, Johan Corveleyn wrote: >> >> Hi, >> >> Here are some more ideas for optimizing "svn diff". Maybe I should >> start to write up a notes file, but for now I'm settling for a list in >> a mail. >> >> [ note: these ideas ar

Re: Comments on 'notes/unicode-composition-for-filenames'

2011-02-22 Thread Branko Čibej
On 22.02.2011 20:11, Daniel Shahaf wrote: > Branko Čibej wrote on Tue, Feb 22, 2011 at 19:41:12 +0100: >> On 22.02.2011 18:17, Julian Foad wrote: >>> For example, a solution that involves normalizing all input to NFD would >>> have the advantages that on MacOSX it would need to do *no* conversions

Re: Comments on 'notes/unicode-composition-for-filenames'

2011-02-22 Thread Daniel Shahaf
Branko Čibej wrote on Tue, Feb 22, 2011 at 19:41:12 +0100: > On 22.02.2011 18:17, Julian Foad wrote: > > For example, a solution that involves normalizing all input to NFD would > > have the advantages that on MacOSX it would need to do *no* conversions > > and would continue to work with old repos

Re: Comments on 'notes/unicode-composition-for-filenames'

2011-02-22 Thread Stefan Sperling
On Tue, Feb 22, 2011 at 07:41:12PM +0100, Branko Čibej wrote: > On 22.02.2011 18:17, Julian Foad wrote: > >> Proposed Support Library > >> > >> > >>Assumptions > >>--- > >> > >>The main assumption is that we'll keep using APR for character set > > s/char

Re: Comments on 'notes/unicode-composition-for-filenames'

2011-02-22 Thread Branko Čibej
On 22.02.2011 18:17, Julian Foad wrote: >> Proposed Support Library >> >> >>Assumptions >>--- >> >>The main assumption is that we'll keep using APR for character set > s/character set/character encoding/. > >>conversion, meaning that the recoding sol

Why does import fail with autoprops ("inconsistent eol style")?

2011-02-22 Thread Stefan Sperling
When trying to 'svn import' files that have a mixed eol style, and at the same time using autoprops to set an svn:eol-style property with value 'native' on this file, svn import aborts with an "Inconsistent line ending style" error. Is there any specific reason for this? Can't we just normalize the

Re: svn commit: r1073325 - /subversion/trunk/contrib/client-side/svn_apply_autoprops.py

2011-02-22 Thread Stefan Sperling
On Tue, Feb 22, 2011 at 12:18:36PM -0500, C. Michael Pilato wrote: > On 02/22/2011 08:51 AM, s...@apache.org wrote: > > Author: stsp > > Date: Tue Feb 22 13:51:16 2011 > > New Revision: 1073325 > > [...] > > > In some situations users might want to use a different configuration file > > to config

Re: svn commit: r1073325 - /subversion/trunk/contrib/client-side/svn_apply_autoprops.py

2011-02-22 Thread C. Michael Pilato
On 02/22/2011 08:51 AM, s...@apache.org wrote: > Author: stsp > Date: Tue Feb 22 13:51:16 2011 > New Revision: 1073325 [...] > In some situations users might want to use a different configuration file > to configure a specific set of autoprops, so add a new --config option. Should we use "--con

Comments on 'notes/unicode-composition-for-filenames'

2011-02-22 Thread Julian Foad
> Proposed Support Library > > >Assumptions >--- > >The main assumption is that we'll keep using APR for character set s/character set/character encoding/. >conversion, meaning that the recoding solution to choose would not >need to provide a

Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite (v. 3)

2011-02-22 Thread Daniel Shahaf
Thanks, r1073377. See below for some comments. Danny Trebbien wrote on Sun, Feb 20, 2011 at 09:58:07 -0800: > Attached is version 3 of the patch and log message. > > > >> >> +        (! setlocale(LC_ALL, "en_US.ISO-8859-1")) && > >> >> +        (! setlocale(LC_ALL, "en_GB.ISO-8859-1")) && > >>

Re: svn commit: r1073102 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-22 Thread C. Michael Pilato
On 02/21/2011 09:30 PM, Noorul Islam K M wrote: > Branko Čibej writes: > >> On 22.02.2011 02:50, Noorul Islam K M wrote: >> >>> danie...@apache.org writes: >>> Author: danielsh Date: Mon Feb 21 18:14:02 2011 New Revision: 1073102 URL: http://svn.apache.org/viewvc?rev=1073

Re: svn commit: r1073102 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-22 Thread Daniel Shahaf
Noorul Islam K M wrote on Tue, Feb 22, 2011 at 07:20:51 +0530: > danie...@apache.org writes: > > > Author: danielsh > > Date: Mon Feb 21 18:14:02 2011 > > New Revision: 1073102 > > > > URL: http://svn.apache.org/viewvc?rev=1073102&view=rev > > Log: > > * subversion/include/private/svn_debug.h > >

Re: [PATCH] support printing changed properties in svnlook

2011-02-22 Thread Daniel Shahaf
Yes, please file an issue, and in the meantime I'll re-add it to my list. (There are a few things ahead of it...) Thanks! Daniel Gavin Beau Baumanis wrote on Tue, Feb 22, 2011 at 21:29:27 +1100: > Hi Daniel, > > Just checking as to whether or not you think you'll be able to get to this > subm

Re: [PATCH] support printing changed properties in svnlook

2011-02-22 Thread Gavin Beau Baumanis
Hi Daniel, Just checking as to whether or not you think you'll be able to get to this submission or not, please? I'm more than happy to log it into the Issue Tracker, if you feel that time is getting the better of you. On 08/01/2011, at 5:08 AM, Daniel Shahaf wrote: > I'll add it to my list,

Re: svn commit: r1073043 - in /subversion/trunk/subversion: include/svn_delta.h mod_dav_svn/mod_dav_svn.c svnserve/main.c

2011-02-22 Thread Stefan Fuhrmann
On 21.02.2011 22:17, Bert Huijben wrote: --- subversion/trunk/subversion/include/svn_delta.h (original) +++ subversion/trunk/subversion/include/svn_delta.h Mon Feb 21 16:08:15 2011 @@ -56,7 +56,7 @@ extern "C" { /** This is the maximum compression level we can pass to zlib. */ -#define SVN_