Re: More s.t.o -> s.a.o code changes

2011-02-18 Thread Ivan Zhakov
On Sat, Feb 19, 2011 at 05:13, Greg Stein wrote: > Those names are simply to ensure we have universally unique names. > There is no concrete reason to associate any semantics with them. We > could have generated a UUID instead. > > So: I'd say that we keep the names as-is, and leave a note to chan

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Stefan Sperling
On Fri, Feb 18, 2011 at 09:19:56PM -0500, Greg Stein wrote: > Can somebody provide a pointer to some of the latest speed analysis? Neels is on vacation this week. When he returns, I'll prod him about running his performance tests again and sharing the results.

[PATCH] Fix a bug introduced in r1071025.

2011-02-18 Thread Noorul Islam K M
Without the patch I get Segmentation fault when I pass unknown command to svnadmin command. Log [[[ Fix a bug introduced in r1071025. * subversion/svnadmin/main.c (parse_args): Handle NULL argument. Patch by: Noorul Islam K M ]]] Index: subversion/svnadmin/main.c ==

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-02-18 Thread Noorul Islam K M
Julian Foad writes: > On Fri, 2011-02-18 at 15:54 +0530, Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> >> > Julian Foad writes: >> > >> >> On Thu, 2011-02-17 at 21:04 +0530, Noorul Islam K M wrote: >> >> >> >>> Julian Foad writes: >> >>> >> >>> > Noorul Islam K M wrote: >> >>> > >

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Greg Stein
On Fri, Feb 18, 2011 at 11:38, Julian Foad wrote: > On Fri, 2011-02-18 at 17:20 +0100, Branko Čibej wrote: >... >> If I read that patch correctly, you expect to use one sqlite transaction >> per pristine file? While this may not affect WC performance now, it'll >> surely show up once other queries

Re: More s.t.o -> s.a.o code changes

2011-02-18 Thread Greg Stein
Those names are simply to ensure we have universally unique names. There is no concrete reason to associate any semantics with them. We could have generated a UUID instead. So: I'd say that we keep the names as-is, and leave a note to change them to s.a.o in the 2.0 timeframe (if that ever happens

Re: svn commit: r1033709 - /subversion/tests/cmdline/patch_tests.py

2011-02-18 Thread Daniel Shahaf
Paul Burba wrote on Fri, Feb 18, 2011 at 15:39:54 -0500: > On Fri, Feb 18, 2011 at 12:37 PM, Daniel Shahaf > wrote: > > Done: http://subversion.tigris.org/issues/show_bug.cgi?id=3814 > > Thanks Daniel. I took the liberty of setting the target milestone to > 'unscheduled' so it is clear this is

Re: svn commit: r1033709 - /subversion/tests/cmdline/patch_tests.py

2011-02-18 Thread Paul Burba
On Fri, Feb 18, 2011 at 12:37 PM, Daniel Shahaf wrote: > Stefan Sperling wrote on Thu, Feb 17, 2011 at 22:45:30 +0100: >> On Thu, Feb 17, 2011 at 04:37:11PM -0500, Paul Burba wrote: >> > Is this something that should be addressed before 1.7? >> >> I don't think so. >> We can address it in a patch

More s.t.o -> s.a.o code changes

2011-02-18 Thread C. Michael Pilato
Sorry if this was previously discussed, but there at least a couple of areas of our code still referring to subversion.tigris.org, and I was wondering what (if anything) we plan to do about them. The first is our custom DAV XML namespaces. You can see these defined in include/svn_dav.h. The seco

Re: s

2011-02-18 Thread Daniel Shahaf
C. Michael Pilato wrote on Thu, Feb 10, 2011 at 14:42:26 -0500: > On 02/06/2011 08:18 PM, Daniel Shahaf wrote: > > I managed to cause 'svn' to lose my commit message when (for whatever > > reason) Vim exited with error code 2 after I'd saved the file: > > I've read through the code a few times now

Re: svn commit: r1033709 - /subversion/tests/cmdline/patch_tests.py

2011-02-18 Thread Daniel Shahaf
Stefan Sperling wrote on Thu, Feb 17, 2011 at 22:45:30 +0100: > On Thu, Feb 17, 2011 at 04:37:11PM -0500, Paul Burba wrote: > > Is this something that should be addressed before 1.7? > > I don't think so. > We can address it in a patch release if necessary. +1 > > I should have been clearer, I w

Re: Pristine store - spec

2011-02-18 Thread Daniel Shahaf
Julian Foad wrote on Wed, Feb 16, 2011 at 19:27:19 +: > On Wed, 2011-02-16, Daniel Shahaf wrote: > > Julian Foad wrote on Tue, Feb 15, 2011 at 15:06:43 +: > > > * > > > * Texts in the Pristine Store are addressed only by their SHA-1 checksum. > > > * The Pristine Store does not track whi

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-02-18 Thread Julian Foad
On Fri, 2011-02-18 at 15:54 +0530, Noorul Islam K M wrote: > Noorul Islam K M writes: > > > Julian Foad writes: > > > >> On Thu, 2011-02-17 at 21:04 +0530, Noorul Islam K M wrote: > >> > >>> Julian Foad writes: > >>> > >>> > Noorul Islam K M wrote: > >>> > > >>> >> Julian Foad writes: > >>> >

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Julian Foad
On Fri, 2011-02-18 at 17:20 +0100, Branko Čibej wrote: > On 18.02.2011 16:51, Julian Foad wrote: > > On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote: > >> On 18.02.2011 15:49, Julian Foad wrote: > >>> svn_error_t * > >>> +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, > >>> + sv

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Branko Čibej
On 18.02.2011 16:51, Julian Foad wrote: > On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote: >> On 18.02.2011 15:49, Julian Foad wrote: >>> svn_error_t * >>> +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, >>> + svn_sqlite__transaction_callback_t cb_func, >>> + void *cb_baton, >>>

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-18 Thread C. Michael Pilato
On 02/18/2011 09:23 AM, Stefan Küng wrote: > I wanted to avoid this, but if you remember we've had this discussion > before. I requested that the new status API would return information that > the deprecated one did too. And the very first answer I got was that even > "the scan if the file has been

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Julian Foad
On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote: > On 18.02.2011 15:49, Julian Foad wrote: > > svn_error_t * > > +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, > > + svn_sqlite__transaction_callback_t cb_func, > > + void *cb_baton, > > + apr_pool_t *scratch_pool /* NULL allowed

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Branko Čibej
On 18.02.2011 15:49, Julian Foad wrote: > svn_error_t * > +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, > + svn_sqlite__transaction_callback_t cb_func, > + void *cb_baton, > + apr_pool_t *scratch_pool /* NULL allowed */) > +{ So you created a new (private) function that's a copy-pa

[PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Julian Foad
I have started adjusting the pristine store access functions to implement the spec in 'notes/wc-ng/pristine-store'. The attached patch goes most of the way to sorting out the 'install' function, except that testing for whether it's already installed is still done by looking on disk for the file wh

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-18 Thread Stefan Küng
On 18.02.2011 14:37, C. Michael Pilato wrote: On 02/18/2011 06:42 AM, Stefan Küng wrote: On 17.02.2011 14:19, Hyrum K Wright wrote: Last summer in Berlin we had a quite heated discussion about just deprecating all of libsvn_wc APIs. I was against such a move (at least until 2.0) in that it w

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-18 Thread C. Michael Pilato
On 02/18/2011 06:42 AM, Stefan Küng wrote: > On 17.02.2011 14:19, Hyrum K Wright wrote: > >> >> Last summer in Berlin we had a quite heated discussion about just >> deprecating all of libsvn_wc APIs. I was against such a move (at >> least until 2.0) in that it would leave the existing APIs publi

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-18 Thread C. Michael Pilato
On 02/18/2011 06:02 AM, Greg Stein wrote: > For 1.7, I would recommend leaving "dav props" (aka wcprops) in the > working copy library. At a minimum, for backwards compatibility > purposes. But I think we just don't want to get into ripping that out > right *now*. Let's ship 1.7 first. > > I would

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-18 Thread Stefan Sperling
On Fri, Feb 18, 2011 at 12:42:30PM +0100, Stefan Küng wrote: > On 17.02.2011 14:19, Hyrum K Wright wrote: > > > > >Last summer in Berlin we had a quite heated discussion about just > >deprecating all of libsvn_wc APIs. I was against such a move (at > >least until 2.0) in that it would leave the e

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-18 Thread Stefan Küng
On 17.02.2011 14:19, Hyrum K Wright wrote: Last summer in Berlin we had a quite heated discussion about just deprecating all of libsvn_wc APIs. I was against such a move (at least until 2.0) in that it would leave the existing APIs public, but any new ones private, and the whole interface in l

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-18 Thread Greg Stein
I concur with all of Mike's statements here. I see no reason to believe that we'll *ever* see any intention of pluggable working copy libraries. On Thu, Feb 17, 2011 at 09:22, C. Michael Pilato wrote: > On 02/17/2011 08:17 AM, Branko Čibej wrote: >> On 17.02.2011 14:12, Stefan Sperling wrote: >>>

Re: [PATCH] Combine multiple target tests to avoid checkout overhead.

2011-02-18 Thread Philip Martin
Noorul Islam K M writes: > Combine multiple targets tests from info_tests.py, blame-tests.py and > basic_tests.py logically into basic_tests.py to reduce the overhead of > checkouts. r1071961 thanks! -- Philip

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-18 Thread Greg Stein
On Thu, Feb 17, 2011 at 15:27, Ivan Zhakov wrote: > On Tue, Feb 15, 2011 at 12:44, Hyrum K Wright wrote: >... >> How far can we go with this?  If we're not using cached DAV properties >> with ra_serf, and ra_serf is the default in 1.7, does it make sense to >> remove support for them from the 1.7

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-02-18 Thread Noorul Islam K M
Noorul Islam K M writes: > Julian Foad writes: > >> On Thu, 2011-02-17 at 21:04 +0530, Noorul Islam K M wrote: >> >>> Julian Foad writes: >>> >>> > Noorul Islam K M wrote: >>> > >>> >> Julian Foad writes: >>> >> > On Tue, 2011-02-15, Noorul Islam K M wrote: >>> >> >> + if ((kind == svn_n

Re: Pristine store - spec

2011-02-18 Thread Julian Foad
On Wed, 2011-02-16, I (Julian Foad) wrote: > > > This specification is conceptually simple, but requires completing disk > > > operations within SDB transactions, which may make it too inefficient > > > in practice. An alternative specification could use the Work Queue to > > > enable more efficie

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-02-18 Thread Noorul Islam K M
Julian Foad writes: > On Thu, 2011-02-17 at 21:04 +0530, Noorul Islam K M wrote: > >> Julian Foad writes: >> >> > Noorul Islam K M wrote: >> > >> >> Julian Foad writes: >> >> > On Tue, 2011-02-15, Noorul Islam K M wrote: >> >> >> + if ((kind == svn_node_file) && ! force) >> >> > >> >> > W