Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-14 Thread Greg Stein
On Mon, Feb 14, 2011 at 14:14, C. Michael Pilato wrote: > On 02/14/2011 01:57 PM, Ivan Zhakov wrote: >> Hi, >> >> Currently ra_serf caches *all* DAV properties retrieved using PROPFIND >> in session pool. This was attempt to reduce number of PROPFIND >> requests. But current implementation has sev

Re: Adding new Subversion-private API's in patch releaqses

2011-02-14 Thread Greg Stein
On Mon, Feb 14, 2011 at 12:30, Stefan Sperling wrote: > On Mon, Feb 14, 2011 at 06:44:21PM +0200, Daniel Shahaf wrote: >> The 1.6.x-svn_fs_commit_txn branch adds a new Subversion-private API. >> >> On the one hand, if we add a new private API to 1.6.16, then clients >> compiled against 1.6.16 will

Re: svn commit: r1033709 - /subversion/tests/cmdline/patch_tests.py

2011-02-14 Thread Daniel Shahaf
Paul Burba wrote on Mon, Feb 14, 2011 at 17:36:43 -0500: > 2011/2/10 Branko Čibej : > > On 10.02.2011 20:25, Paul Burba wrote: > >>> Author: danielsh > >>> Date: Wed Nov 10 21:02:46 2010 > >>> New Revision: 1033709 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1033709&view=rev > >>> Log: > >>>

[l10n] Translation status report for trunk r1070774

2011-02-14 Thread Subversion Translation Status
Translation status report for trunk@r1070774 lang trans untrans fuzzy obs -- de2052 128 243 204 es1990 190 276 343 fr2175 5 10 10 it1839 341 475 167 ja1982

Further diff optimization ideas

2011-02-14 Thread Johan Corveleyn
Hi, Here are some more ideas for optimizing "svn diff". Maybe I should start to write up a notes file, but for now I'm settling for a list in a mail. [ note: these ideas are not original, other people have observed some of these as well (and discussed on IRC and all), and some inspiration also co

Re: Patches pending review

2011-02-14 Thread Gavin Beau Baumanis
Hi Noorul, Just so you know, there is absolutely no issue at all with pinging your own patch submissions. If anything, I encourage it - after all, if you're not going to see your submission through to the end of the submission process (regardless of the outcome) - who is? Please also take onb

Re: Patches pending review

2011-02-14 Thread Hyrum K Wright
On Mon, Feb 14, 2011 at 11:33 AM, Noorul Islam K M wrote: > > See below in line more information about the patches. > > Noorul Islam K M writes: ... >> 3. Issue 3690 >> >>    http://svn.haxx.se/dev/archive-2011-01/0414.shtml >> >>    This is actually an enhancement and there were two approaches.

Re: 1.6.16 next week (now 23 Feb)

2011-02-14 Thread Hyrum K Wright
On Wed, Feb 9, 2011 at 10:00 PM, Hyrum K Wright wrote: > Hello folks: I'd like to cut 1.6.16 next Wednesday.  Please nominate / > review / vote / etc in the mean time. Hopefully this isn't dashing too many hopes, but I'm running out of tuits this week, and it appears folks still have some review

Re: [Issue 3808] New - 'svn upgrade' doesn't remove

2011-02-14 Thread Paul Burba
On Mon, Feb 14, 2011 at 5:34 PM, Hyrum K Wright wrote: > On Mon, Feb 14, 2011 at 10:07 PM,   wrote: >> http://subversion.tigris.org/issues/show_bug.cgi?id=3808 >>                 Issue #|3808 >>                 Summary|'svn upgrade' doesn't remove > > Looks like the summary is lacking a direct obj

Re: svn commit: r1033709 - /subversion/tests/cmdline/patch_tests.py

2011-02-14 Thread Paul Burba
2011/2/10 Branko Čibej : > On 10.02.2011 20:25, Paul Burba wrote: >>> Author: danielsh >>> Date: Wed Nov 10 21:02:46 2010 >>> New Revision: 1033709 >>> >>> URL: http://svn.apache.org/viewvc?rev=1033709&view=rev >>> Log: >>> Add a regression test for 'svn patch' setting properties without >>> traili

Re: [Issue 3808] New - 'svn upgrade' doesn't remove

2011-02-14 Thread Hyrum K Wright
On Mon, Feb 14, 2011 at 10:07 PM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3808 >                 Issue #|3808 >                 Summary|'svn upgrade' doesn't remove Looks like the summary is lacking a direct object. "doesn't remove" what? -Hyrum

Re: svn_diff.h truncated

2011-02-14 Thread Johan Corveleyn
On Wed, Feb 9, 2011 at 12:29 AM, Johan Corveleyn wrote: > On Tue, Feb 8, 2011 at 11:19 PM, Johan Corveleyn wrote: >> On Tue, Feb 8, 2011 at 10:50 PM, Stefan Sperling wrote: >>> On Tue, Feb 08, 2011 at 10:45:03PM +0100, Johan Corveleyn wrote: On Tue, Feb 8, 2011 at 9:01 PM, Johan Corveleyn

Re: svn commit: r1067800 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_diff/ subversion/libsvn_subr/

2011-02-14 Thread Johan Corveleyn
On Mon, Feb 14, 2011 at 9:49 AM, Ivan Zhakov wrote: > On Mon, Feb 7, 2011 at 01:04,   wrote: >> Author: jcorvel >> Date: Sun Feb  6 23:04:04 2011 >> New Revision: 1067800 >> >> URL: http://svn.apache.org/viewvc?rev=1067800&view=rev >> Log: >> Reintegrate diff-optimizations-bytes branch with trunk.

Re: SQLite and callbacks

2011-02-14 Thread Branko Čibej
On 14.02.2011 13:37, Stefan Sperling wrote: > On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej wrote: >> Well, here it is, I fixed the thinko in the actual_props query and got >> all prop_tests to pass with this version. > Just FYI, the patch doesn't apply to HEAD. I'll try to adjust it when

Re: What should this tree conflict test expect? (was: svn commit: r879162)

2011-02-14 Thread Paul Burba
On Fri, Feb 11, 2011 at 7:07 AM, Julian Foad wrote: > On Thu, 2011-02-10 at 12:10 -0500, Paul Burba wrote: >> Hi Neels (or any other tree conflict gurus), >> >> I know you don't have much time for Subversion these days, but if you >> find some time in the near future could you take a look at the t

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-14 Thread Ivan Zhakov
On Mon, Feb 14, 2011 at 21:14, C. Michael Pilato wrote: > On 02/14/2011 01:57 PM, Ivan Zhakov wrote: >> So I'm propose just to remove DAV properties cache from ra_serf. >> Objections? Comments? >> >> PS: See attached patch in case you'd like test performance. > [...] > > But what is the effect fo

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-14 Thread C. Michael Pilato
On 02/14/2011 01:57 PM, Ivan Zhakov wrote: > Hi, > > Currently ra_serf caches *all* DAV properties retrieved using PROPFIND > in session pool. This was attempt to reduce number of PROPFIND > requests. But current implementation has several problems: > 1. Unlimited memory usage: current implementat

[Proposal] Remove DAV properties cache in ra_serf

2011-02-14 Thread Ivan Zhakov
Hi, Currently ra_serf caches *all* DAV properties retrieved using PROPFIND in session pool. This was attempt to reduce number of PROPFIND requests. But current implementation has several problems: 1. Unlimited memory usage: current implementation stores all properties, so svn ls -R command can eas

Re: Adding new Subversion-private API's in patch releaqses

2011-02-14 Thread Stefan Sperling
On Mon, Feb 14, 2011 at 06:44:21PM +0200, Daniel Shahaf wrote: > The 1.6.x-svn_fs_commit_txn branch adds a new Subversion-private API. > > On the one hand, if we add a new private API to 1.6.16, then clients > compiled against 1.6.16 will fail if run with 1.6.15 present in runtime. > (svn_ver_comp

Re: Adding new Subversion-private API's in patch releaqses

2011-02-14 Thread Daniel Shahaf
Consensus on IRC: all Subversion components should be upgraded/downgraded together, i.e., mod_dav_svn 1.6.16 with libsvn_repos 1.6.15 is "don't do that".

#3641 vetoed

2011-02-14 Thread Daniel Shahaf
Philip, You vetoed the r962377 group since descend_into_replace() is XFail. I've un-xfailed that test in these commits: 3485 * 11Jan26,02:35 danielsh@apache.o (2.5K) svn commit: r1063572 - in /subversion/trunk/subversion/tests/cmdline/ 3486 * 11Jan26,02:39 danielsh@apache.o (2.2K) svn commit

Adding new Subversion-private API's in patch releaqses

2011-02-14 Thread Daniel Shahaf
The 1.6.x-svn_fs_commit_txn branch adds a new Subversion-private API. On the one hand, if we add a new private API to 1.6.16, then clients compiled against 1.6.16 will fail if run with 1.6.15 present in runtime. (svn_ver_compatible() doesn't compare the patch number, only the major/minor numbers.)

[PATCH] Improve svn cat/info error messages.

2011-02-14 Thread Noorul Islam K M
Log [[[ Improve error message displayed by info/cat for consistency. * subversion/svn/info-cmd.c, * subversion/svn/cat-cmd.c (svn_cl__info, svn_cl__cat): Improve error message. Use meaningful variable. * subversion/tests/cmdline/cat_tests.py (cat_skip_uncattable): Modify test Patch by:

Re: cat_tests.py 5 failing because of double-escaped path in expected error message

2011-02-14 Thread Julian Foad
On Fri, 2011-02-11, Johan Corveleyn wrote: > Hi, > > Currently (trunk@1068411), cat_tests.py 5 (cat should skip uncattable > resources) is failing on my machine (Windows XP). There seems to be > some double-escaping of the path in the expected error message. I > don't understand why this only happ

Re: svn commit: r1070510 - in /subversion/trunk/subversion: svn/list-cmd.c tests/cmdline/basic_tests.py

2011-02-14 Thread Noorul Islam K M
s...@apache.org writes: > Author: stsp > Date: Mon Feb 14 14:44:50 2011 > New Revision: 1070510 > > URL: http://svn.apache.org/viewvc?rev=1070510&view=rev > Log: > * subversion/svn/list-cmd.c > (svn_cl__list): If one of the targets is a non-existent URL or > wc-entry, don't bail out. Just w

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 14, 2011 at 07:55:17PM +0530, Noorul Islam K M wrote: > >> Incorporated all review comments. Please find attached latest patch. > > Thanks! Committed in r1070510 (with similar log message tweak as > I did for the 'add' diff). > > Also, I did not commit the ch

Re: [PATCH] svn command - add - Multiple targets

2011-02-14 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 14, 2011 at 08:01:19PM +0530, Noorul Islam K M wrote: > >> Stefan Sperling writes: >> >> > On Thu, Jan 20, 2011 at 04:48:58PM +0530, Noorul Islam K M wrote: >> > >> >> >> >> This patch is a followup of the following thread. All tests pass with >> >> this p

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Stefan Sperling
On Mon, Feb 14, 2011 at 07:55:17PM +0530, Noorul Islam K M wrote: > Incorporated all review comments. Please find attached latest patch. Thanks! Committed in r1070510 (with similar log message tweak as I did for the 'add' diff). Also, I did not commit the change for svn info, because I wasn't sur

Re: [PATCH] svn command - add - Multiple targets

2011-02-14 Thread Stefan Sperling
On Mon, Feb 14, 2011 at 08:01:19PM +0530, Noorul Islam K M wrote: > Stefan Sperling writes: > > > On Thu, Jan 20, 2011 at 04:48:58PM +0530, Noorul Islam K M wrote: > > > >> > >> This patch is a followup of the following thread. All tests pass with > >> this patch. > >> > >> http://svn.haxx.se/

Re: [PATCH] svn command - add - Multiple targets

2011-02-14 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Jan 20, 2011 at 04:48:58PM +0530, Noorul Islam K M wrote: > >> >> This patch is a followup of the following thread. All tests pass with >> this patch. >> >> http://svn.haxx.se/dev/archive-2011-01/0210.shtml >> >> Log >> [[[ >> >> Make svn 'add' command to ret

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 14, 2011 at 07:32:51PM +0530, Noorul Islam K M wrote: > >> Daniel Shahaf writes: >> >> > Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100: >> > >> >> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote: >> >> > > @@ -301,5 +318,8 @@

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Stefan Sperling
On Mon, Feb 14, 2011 at 07:32:51PM +0530, Noorul Islam K M wrote: > Daniel Shahaf writes: > > > Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100: > > > >> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote: > >> > > @@ -301,5 +318,8 @@ > >> > >if (opt_state->xml && !

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Noorul Islam K M
Daniel Shahaf writes: > Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100: > >> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote: >> > > @@ -301,5 +318,8 @@ >> > >if (opt_state->xml && ! opt_state->incremental) >> > > SVN_ERR(svn_cl__xml_print_footer("lists", po

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Noorul Islam K M
Philip Martin writes: > Stefan Sperling writes: > >>> + alpha = os.path.join(wc_dir, 'A/B/E/alpha') >>> + beta = os.path.join(wc_dir, 'A/B/E/beta') >> >> I think you need this here instead: >> alpha = os.path.join(wc_dir, 'A', 'B', 'E', alpha') >> beta = os.path.join(wc_dir, 'A', 'B', 'E',

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100: > On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote: > > > @@ -301,5 +318,8 @@ > > >if (opt_state->xml && ! opt_state->incremental) > > > SVN_ERR(svn_cl__xml_print_footer("lists", pool)); > > > > > > - return SV

Re: svn commit: r1035894 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_client/ subversion/libsvn_fs/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/

2011-02-14 Thread Daniel Shahaf
pbu...@apache.org wrote on Wed, Nov 17, 2010 at 01:08:29 -: > +++ subversion/trunk/subversion/svnserve/serve.c Wed Nov 17 01:08:28 2010 > @@ -1838,11 +1838,14 @@ static svn_error_t *get_mergeinfo(svn_ra > + svn_boolean_t validate_inherited_mergeinfo; > > - SVN_ERR(svn_ra_svn_parse_tuple(par

Re: HEAD svnserve broken with 1.6 client

2011-02-14 Thread Daniel Shahaf
Philip Martin wrote on Fri, Feb 11, 2011 at 14:49:59 +: > The HEAD svnserve crashes when used with a 1.6 client: > > svnadmin create repo > printf "[global]\nanon-access=write\n" > repo/conf/svnserve.conf > svn mkdir -mm file://`pwd`/repo/A > svnserve -dr.

Re: SQLite and callbacks

2011-02-14 Thread Stefan Sperling
On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej wrote: > Well, here it is, I fixed the thinko in the actual_props query and got > all prop_tests to pass with this version. Just FYI, the patch doesn't apply to HEAD. I'll try to adjust it when I find time. But maybe you'll be quicker than me?

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Philip Martin
Stefan Sperling writes: >> + alpha = os.path.join(wc_dir, 'A/B/E/alpha') >> + beta = os.path.join(wc_dir, 'A/B/E/beta') > > I think you need this here instead: > alpha = os.path.join(wc_dir, 'A', 'B', 'E', alpha') > beta = os.path.join(wc_dir, 'A', 'B', 'E', 'beta') > > Otherwise you'll get

Re: [PATCH] svn command - add - Multiple targets

2011-02-14 Thread Stefan Sperling
On Thu, Jan 20, 2011 at 04:48:58PM +0530, Noorul Islam K M wrote: > > This patch is a followup of the following thread. All tests pass with > this patch. > > http://svn.haxx.se/dev/archive-2011-01/0210.shtml > > Log > [[[ > > Make svn 'add' command to return 1 when one or more targets fail. Als

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Stefan Sperling
On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote: > > @@ -301,5 +318,8 @@ > >if (opt_state->xml && ! opt_state->incremental) > > SVN_ERR(svn_cl__xml_print_footer("lists", pool)); > > > > - return SVN_NO_ERROR; > > + if (saw_a_problem) > > +return svn_error_create(SVN

Re: [PATCH] svn command - ls - Multiple targets

2011-02-14 Thread Stefan Sperling
Hi Noorul, comments inline: On Fri, Feb 11, 2011 at 12:49:04PM +0530, Noorul Islam K M wrote: > === > --- subversion/tests/cmdline/basic_tests.py (revision 1068757) > +++ subversion/tests/cmdline/basic_tests.py (working copy) > @

Re: Patches pending review

2011-02-14 Thread Noorul Islam K M
See below in line more information about the patches. Noorul Islam K M writes: > I have been working on some issues lately but I have not got many review > comments for the same. I have listed them below so that it gets some > attention and I can move forward. > > 1. I started sending patches f

Re: Patches pending review

2011-02-14 Thread Daniel Shahaf
Noorul Islam K M wrote on Mon, Feb 14, 2011 at 15:25:48 +0530: > 1. I started sending patches for >http://svn.haxx.se/dev/archive-2011-01/0210.shtml long back and one >of them got committed in r1068977. Apart from that there are two >more patches as a follow-up to r1068977 > >http:

Patches pending review

2011-02-14 Thread Noorul Islam K M
I have been working on some issues lately but I have not got many review comments for the same. I have listed them below so that it gets some attention and I can move forward. 1. I started sending patches for http://svn.haxx.se/dev/archive-2011-01/0210.shtml long back and one of them got co

Re: svn commit: r1067800 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_diff/ subversion/libsvn_subr/

2011-02-14 Thread Ivan Zhakov
On Mon, Feb 7, 2011 at 01:04, wrote: > Author: jcorvel > Date: Sun Feb  6 23:04:04 2011 > New Revision: 1067800 > > URL: http://svn.apache.org/viewvc?rev=1067800&view=rev > Log: > Reintegrate diff-optimizations-bytes branch with trunk. > Hi Johan, I think you can update status of "Diff/Blame opt

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 5.1)

2011-02-14 Thread Daniel Shahaf
Danny Trebbien wrote on Sun, Feb 13, 2011 at 20:20:45 -0800: > Attached are the corrected patch and log message. The new patch > incorporates this fix: > https://github.com/dtrebbien/subversion/commit/190f876b52626be6b30fe4e5a311c113fd87e589 Is there a github link that shows the equivalent of 'svn

Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite (v. 2)

2011-02-14 Thread Daniel Shahaf
Danny Trebbien wrote on Sun, Feb 13, 2011 at 18:05:38 -0800: > >> +        (! setlocale(LC_ALL, "en_US.ISO-8859-1")) && > >> +        (! setlocale(LC_ALL, "en_GB.ISO-8859-1")) && > >> +        (! setlocale(LC_ALL, "de_DE.ISO-8859-1"))) > >> +      return svn_error_createf(SVN_ERR_TEST_SKIPPED, NULL