Stefan Sperling <s...@elego.de> writes:
> On Mon, Feb 14, 2011 at 07:55:17PM +0530, Noorul Islam K M wrote:
>
>> Incorporated all review comments. Please find attached latest patch.
>
> Thanks! Committed in r1070510 (with similar log message tweak as
> I did for the 'add' diff).
>
> Also, I did not commit the change for svn info, because I wasn't sure
> whether you included it accidentally:
>
>> Index: subversion/svn/info-cmd.c
>> ===================================================================
>> --- subversion/svn/info-cmd.c (revision 1070486)
>> +++ subversion/svn/info-cmd.c (working copy)
>> @@ -588,7 +588,9 @@
>> SVN_ERR(svn_cl__xml_print_footer("info", pool));
>>
>> if (saw_a_problem)
>> - return svn_error_create(SVN_ERR_BASE, NULL, NULL);
>> + return svn_error_create(
>> + SVN_ERR_ILLEGAL_TARGET, NULL,
>> + _("Could not list all targets because some targets don't exist"));
>> else
>> return SVN_NO_ERROR;
>> }
>
> Can you resend this change as a separate patch, also renaming the
> saw_a_problem variable for consistency with 'ls' and 'add'?
My bad. Sorry about the noise. Sure, I will send a separate patch for
info and cat. Thank you!
Thanks and Regards
Noorul
