Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 4:38 PM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 13:22:11 -0800: On 12/22/10 10:56 AM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 10:45:12 -0800: Since probably 100% of the time the last error in a chain is not a tracing error, then err_ab

Re: Setting $HOME in the testsuite

2010-12-22 Thread Branko Čibej
On 23.12.2010 06:09, Peter Samuelson wrote: > And I still think that 90% of end users, maybe 99%, do _not_ think of > Subversion as a stack of libraries that just happens to also ship some > command-line wrapper programs as a convenience. Consequently I think > they'd prefer the smaller top-level-

Re: Setting $HOME in the testsuite

2010-12-22 Thread Peter Samuelson
[Hyrum K Wright] > Just curious if this suggestion is made in light of the concerns I > expressed in the other thread. Namely, that the location of the > config directory isn't determined until parsing the commandline args, > at which point it may be too late to introduce the additional args > ob

Re: Setting $HOME in the testsuite

2010-12-22 Thread Branko Čibej
On 23.12.2010 01:37, Hyrum K Wright wrote: > More fallout from my issue #3765 work: I'm investing using ~/.svnrc to > provide default arguments to the commandline client. In doing so, it > makes loads of sense not to use the a developer's ~/.svnrc when > running the tests. Since this is found via

Re: Setting $HOME in the testsuite

2010-12-22 Thread Hyrum K Wright
On Wed, Dec 22, 2010 at 9:31 PM, Peter Samuelson wrote: > > [Hyrum K Wright] >> More fallout from my issue #3765 work: I'm investing using ~/.svnrc >> to provide default arguments to the commandline client.  In doing so, >> it makes loads of sense not to use the a developer's ~/.svnrc when >> runn

Re: Setting $HOME in the testsuite

2010-12-22 Thread Peter Samuelson
[Hyrum K Wright] > More fallout from my issue #3765 work: I'm investing using ~/.svnrc > to provide default arguments to the commandline client. In doing so, > it makes loads of sense not to use the a developer's ~/.svnrc when > running the tests. I'd suggest putting svnrc inside ~/.subversion (

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-22 Thread Gavin Beau Baumanis
Hi Johan, I was intrigued by your requirement to create a large file for testing. I remember from a really long time ago when I learnt C, that we used a specific algorithm for creating "natural" and "random" text. With some help from Mr.Google found out about Markov Chains that look promising -

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-22 Thread Johan Corveleyn
On Wed, Dec 22, 2010 at 11:50 AM, Philip Martin wrote: > Johan Corveleyn writes: > >> On Mon, Dec 20, 2010 at 11:19 AM, Philip Martin >> wrote: >>> Johan Corveleyn writes: >>> This makes the diff algorithm another 10% - 15% faster (granted, this was measured with my "extreme" testcase

Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Daniel Shahaf
Blair Zajac wrote on Wed, Dec 22, 2010 at 13:22:11 -0800: > On 12/22/10 10:56 AM, Daniel Shahaf wrote: >> Blair Zajac wrote on Wed, Dec 22, 2010 at 10:45:12 -0800: >>> On 12/22/10 10:27 AM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 09:02:34 -0800: > On 12/22/10 5:47 AM

Setting $HOME in the testsuite

2010-12-22 Thread Hyrum K Wright
More fallout from my issue #3765 work: I'm investing using ~/.svnrc to provide default arguments to the commandline client. In doing so, it makes loads of sense not to use the a developer's ~/.svnrc when running the tests. Since this is found via the svn_user_get_homedir() function, which uses th

Re: [PATCH] support printing changed properties in svnlook

2010-12-22 Thread Erik Johansson
On Fri, Dec 10, 2010 at 15:08, Daniel Shahaf wrote: > [ I'm somewhat confused about this issue. ] > > Erik Johansson wrote on Thu, Dec 09, 2010 at 21:41:38 +0100: >> On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: >> > Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: >> >> +  /** H

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 1:53 PM, Hyrum K Wright wrote: On Wed, Dec 22, 2010 at 2:03 PM, Blair Zajac wrote: Lots of warnings in the build now. I remember the days when we have a warning free build. It would be nice to have that back, but it would be a bunch of work. It's because we've made the compile m

Re: [PATCH] support printing changed properties in svnlook

2010-12-22 Thread Erik Johansson
On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf wrote: >> >> +  /** How this property entered the node tree: 'A'dd, 'D'elete, >> >> 'R'eplace */ >> >> +  char action; >> > >> > This is copied from svn_repos_node_t->action.  There was recently >> > a question about that field: >> > http://mid.gmane.o

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Hyrum K Wright
On Wed, Dec 22, 2010 at 2:03 PM, Blair Zajac wrote: > Lots of warnings in the build now.  I remember the days when we have a > warning free build.  It would be nice to have that back, but it would be a > bunch of work. It's because we've made the compile more strict about flagging warnings, not b

Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 10:56 AM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 10:45:12 -0800: On 12/22/10 10:27 AM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 09:02:34 -0800: On 12/22/10 5:47 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 05

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-22 Thread Erik Johansson
On Sat, Dec 18, 2010 at 20:43, Daniel Shahaf wrote: > Erik Johansson wrote on Tue, Dec 14, 2010 at 19:19:17 +0100: >> [[[ >> r846201 added svn_repos_replay as a "replacement not so much for >> svn_repos_dir_delta, but for at least a whole class of functionality that >> svn_repos_dir_delta was neve

Re: svn commit: r1051778 - in /subversion/trunk/subversion: libsvn_repos/commit.c libsvn_repos/load-fs-vtable.c mod_dav_svn/lock.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 5:57 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 07:10:06 -: Author: blair Date: Wed Dec 22 07:10:05 2010 New Revision: 1051778 URL: http://svn.apache.org/viewvc?rev=1051778&view=rev Log: Have all remaining calls of svn_fs_commit_txn() and svn_repos_f

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 8:43 AM, Julian Foad wrote: On Wed, 2010-12-22, Blair Zajac wrote: On 12/22/10 4:36 AM, Julian Foad wrote: subversion/libsvn_repos/commit.c:648: no previous prototype for 'svn_repos__post_commit_error_str' Thanks, fixed in r1051968. Which compiler are you using that gives this wa

Re: Version 1.6.15 missing from archive.apache.org

2010-12-22 Thread Hyrum K. Wright
1.6.15 should be on archive.apache.org (or will when the mirrors propagate), along with the recently-released 1.5.9. Cheers, -Hyrum On Fri, Dec 17, 2010 at 4:04 AM, Rainer Jung wrote: > Hi Hyrum, > > On 17.12.2010 03:39, Hyrum K. Wright wrote: >> >> Rainer, >> Thanks for the poke.  I need to upl

Re: svn commit: r1051978 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 10:39 AM, Philip Martin wrote: bl...@apache.org writes: Author: blair Date: Wed Dec 22 16:46:40 2010 New Revision: 1051978 URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/version.c?rev=1051978&r1=1051977&r2=1051978&view=diff

Subversion 1.5.9 Released

2010-12-22 Thread Hyrum Wright
I'm happy to announce the release of Subversion 1.5.9. This release is intended for users who are still running the 1.5 release line, and contains a number of stability and performance fixes to previous 1.5.x releases. This release does *not* contain all the bug fixes and features which are found

Re: svn commit: r1051988 - /subversion/trunk/subversion/libsvn_repos/commit.c

2010-12-22 Thread Blair Zajac
On 12/22/10 9:09 AM, Blair Zajac wrote: On 12/22/10 9:01 AM, bl...@apache.org wrote: Author: blair Date: Wed Dec 22 17:01:20 2010 New Revision: 1051988 URL: http://svn.apache.org/viewvc?rev=1051988&view=rev Log: Improve error messages from svn_repos__post_commit_error_str(). Also, improve docs.

Re: svn commit: r1051988 - /subversion/trunk/subversion/libsvn_repos/commit.c

2010-12-22 Thread Blair Zajac
On 12/22/10 10:30 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 17:01:21 -: Author: blair Date: Wed Dec 22 17:01:20 2010 New Revision: 1051988 URL: http://svn.apache.org/viewvc?rev=1051988&view=rev Log: Improve error messages from svn_repos__post_commit_error_str()

Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Daniel Shahaf
Blair Zajac wrote on Wed, Dec 22, 2010 at 10:45:12 -0800: > On 12/22/10 10:27 AM, Daniel Shahaf wrote: >> Blair Zajac wrote on Wed, Dec 22, 2010 at 09:02:34 -0800: >>> On 12/22/10 5:47 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 05:46:45 -: > Author: blair >

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 5:47 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 05:46:45 -: Author: blair Date: Wed Dec 22 05:46:45 2010 New Revision: 1051763 URL: http://svn.apache.org/viewvc?rev=1051763&view=rev Log: Add a private function that takes the error returned from svn_r

Re: svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 10:27 AM, Daniel Shahaf wrote: Blair Zajac wrote on Wed, Dec 22, 2010 at 09:02:34 -0800: On 12/22/10 5:47 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 05:46:45 -: Author: blair Date: Wed Dec 22 05:46:45 2010 New Revision: 1051763 URL: http://svn.apac

Re: [PATCH] Issue #3653: svn update should not output svn:external fetches if they have not been updated

2010-12-22 Thread Daniel Shahaf
Your quoting is broken, please send MIME=text/plain replies so we don't have to think where my text ends and yours starts, thanks. Tijn Porcelijn wrote on Wed, Dec 22, 2010 at 07:37:50 -0800: > On 2010-12-22 14:02, Daniel Shahaf wrote: > > > > Forwarding back to the list. > > > > Tijn Porcelijn

Re: svn commit: r1051978 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Philip Martin
bl...@apache.org writes: > Author: blair > Date: Wed Dec 22 16:46:40 2010 > New Revision: 1051978 > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/version.c?rev=1051978&r1=1051977&r2=1051978&view=diff >

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Daniel Shahaf
Blair Zajac wrote on Wed, Dec 22, 2010 at 09:02:34 -0800: > Should we have an official term for FS fiddling, +1. > or call it post-commit processing? So we'll have to distinguish > between "hook" and "processing". > "Post-commit FS processing" seems fine to me... > Blair

Re: svn commit: r1051988 - /subversion/trunk/subversion/libsvn_repos/commit.c

2010-12-22 Thread Daniel Shahaf
bl...@apache.org wrote on Wed, Dec 22, 2010 at 17:01:21 -: > Author: blair > Date: Wed Dec 22 17:01:20 2010 > New Revision: 1051988 > > URL: http://svn.apache.org/viewvc?rev=1051988&view=rev > Log: > Improve error messages from svn_repos__post_commit_error_str(). Also, > improve docs. > > Fo

svn_error_purge_tracing() and clearing the errors Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Daniel Shahaf
Blair Zajac wrote on Wed, Dec 22, 2010 at 09:02:34 -0800: > On 12/22/10 5:47 AM, Daniel Shahaf wrote: >> bl...@apache.org wrote on Wed, Dec 22, 2010 at 05:46:45 -: >>> Author: blair >>> Date: Wed Dec 22 05:46:45 2010 >>> New Revision: 1051763 >>> >>> URL: http://svn.apache.org/viewvc?rev=105176

Re: svn commit: r1051988 - /subversion/trunk/subversion/libsvn_repos/commit.c

2010-12-22 Thread Blair Zajac
On 12/22/10 9:01 AM, bl...@apache.org wrote: Author: blair Date: Wed Dec 22 17:01:20 2010 New Revision: 1051988 URL: http://svn.apache.org/viewvc?rev=1051988&view=rev Log: Improve error messages from svn_repos__post_commit_error_str(). Also, improve docs. I see the unit test failures from thi

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 5:47 AM, Daniel Shahaf wrote: bl...@apache.org wrote on Wed, Dec 22, 2010 at 05:46:45 -: Author: blair Date: Wed Dec 22 05:46:45 2010 New Revision: 1051763 URL: http://svn.apache.org/viewvc?rev=1051763&view=rev Log: Modified: subversion/trunk/subversion/libsvn_repos/commit.c URL

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Julian Foad
On Wed, 2010-12-22, Blair Zajac wrote: > On 12/22/10 4:36 AM, Julian Foad wrote: > > subversion/libsvn_repos/commit.c:648: no previous prototype for > > 'svn_repos__post_commit_error_str' > > Thanks, fixed in r1051968. > > Which compiler are you using that gives this warning? GCC. >From the out

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Blair Zajac
On 12/22/10 4:36 AM, Julian Foad wrote: subversion/libsvn_repos/commit.c:648: no previous prototype for 'svn_repos__post_commit_error_str' Thanks, fixed in r1051968. Which compiler are you using that gives this warning? Blair

Re: [PATCH] Issue #3653: svn update should not output svn:external fetches if they have not been updated

2010-12-22 Thread Tijn Porcelijn
On 2010-12-22 14:02, Daniel Shahaf wrote: Forwarding back to the list. Tijn Porcelijn wrote on Wed, Dec 22, 2010 at 01:54:07 -0800: > Hi Daniel, > > I guess you're right. It makes more sense to echo the external URL > than the local directory in the "Updated external > 'url://remote/path/to/somew

Re: Windows svnsync test suite failures and a clue

2010-12-22 Thread C. Michael Pilato
> Problem solved, finally! Hooray! Huzzah! ${LC_HEARTY_EXPRESSION_OF_APPROVAL}! -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand signature.asc Description: OpenPGP digital signature

Re: [RFC] Include the svn version number in the "Working copy is too old" error message

2010-12-22 Thread Julian Foad
Hearing no dissent, I committed a version of this patch in r1051945. A typical message is now: svn: Please see the 'svn upgrade' command svn: Working copy '/home/julianfoad/tmp/svn/walk/wc' is too old (format 10, created by Subversion 1.6) - Julian On Fri, 2010-12-17 at 17:20 +, Julian

Re: svn commit: r1051819 - /subversion/trunk/subversion/tests/cmdline/entries-dump.c

2010-12-22 Thread Philip Martin
"Hyrum K. Wright" writes: >> After this commit I get the following warning when I run ./autogen.sh >> >> WARNING: "../libsvn_wc/entries.h" header not found, file >> subversion/tests/cmdline/entries-dump.c > > This may also be causing the build failure on the windows builtslave: > > "D:\svn-w2k3-r

Re: Disable transform_libtool_scripts.py by default?

2010-12-22 Thread Philip Martin
Philip Martin writes: > I'd like to disable libtool transformation by default, i.e. make > --disable-local-library-preloading the default. The script messes with > the internals of libtool and so runs the risk of breaking the build, > particularly on less common platforms. I've made this change

Re: svn commit: r1051778 - in /subversion/trunk/subversion: libsvn_repos/commit.c libsvn_repos/load-fs-vtable.c mod_dav_svn/lock.c mod_dav_svn/version.c

2010-12-22 Thread Daniel Shahaf
bl...@apache.org wrote on Wed, Dec 22, 2010 at 07:10:06 -: > Author: blair > Date: Wed Dec 22 07:10:05 2010 > New Revision: 1051778 > > URL: http://svn.apache.org/viewvc?rev=1051778&view=rev > Log: > Have all remaining calls of svn_fs_commit_txn() and > svn_repos_fs_commit_txn() use the contra

Re: [PATCH] Fix syntax inconsistency and update comments.

2010-12-22 Thread Noorul Islam K M
"Hyrum K. Wright" writes: > On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M wrote: > >> >> Find attached minor patch which makes 'if' syntax consistent and also >> some comment improvements. >> >> Log >> >> [[[ >> >> Fix syntax inconsistency and update comments. >> >> * libsvn_client/locking_

Re: svn commit: r1051745 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2010-12-22 Thread Hyrum K. Wright
On Wed, Dec 22, 2010 at 1:15 AM, Kamesh Jayachandran wrote: > On 12/22/2010 09:38 AM, bl...@apache.org wrote: >> >> Author: blair >> Date: Wed Dec 22 04:08:14 2010 >> New Revision: 1051745 >> >> URL: http://svn.apache.org/viewvc?rev=1051745&view=rev >> Log: >> Update test_commit_txn() to handle sv

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Daniel Shahaf
bl...@apache.org wrote on Wed, Dec 22, 2010 at 05:46:45 -: > Author: blair > Date: Wed Dec 22 05:46:45 2010 > New Revision: 1051763 > > URL: http://svn.apache.org/viewvc?rev=1051763&view=rev > Log: > Add a private function that takes the error returned from > svn_repos_fs_commit_txn() and buil

Re: svn commit: r1051819 - /subversion/trunk/subversion/tests/cmdline/entries-dump.c

2010-12-22 Thread Hyrum K. Wright
On Wed, Dec 22, 2010 at 6:21 AM, Noorul Islam K M wrote: > phi...@apache.org writes: > >> Author: philip >> Date: Wed Dec 22 10:41:38 2010 >> New Revision: 1051819 >> >> URL: http://svn.apache.org/viewvc?rev=1051819&view=rev >> Log: >> Make entries-dump fallback to operating on pre-wcng working co

Re: [PATCH] Fix syntax inconsistency and update comments.

2010-12-22 Thread Hyrum K. Wright
On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M wrote: > > Find attached minor patch which makes 'if' syntax consistent and also > some comment improvements. > > Log > > [[[ > > Fix syntax inconsistency and update comments. > > * libsvn_client/locking_commands.c >  (organize_lock_targets): Fix

Re: Default commandline args

2010-12-22 Thread Hyrum K. Wright
On Tue, Dec 21, 2010 at 12:34 AM, Blair Zajac wrote: > On 12/20/10 8:30 PM, C. Michael Pilato wrote: >> >> On 12/20/2010 05:28 PM, Hyrum K. Wright wrote: >>> >>> In issue #3765, I suggest the possibility of a CVS-style config file >>> wherein a user could specify a set of default arguments for a g

Re: svn commit: r1051875 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c

2010-12-22 Thread Daniel Shahaf
julianf...@apache.org wrote on Wed, Dec 22, 2010 at 12:48:01 -: > Author: julianfoad > Date: Wed Dec 22 12:48:01 2010 > New Revision: 1051875 > > URL: http://svn.apache.org/viewvc?rev=1051875&view=rev > Log: > Fix a printf format-string insecurity. A follow-up to r1030536. Found by > my compil

Re: [PATCH] Fix some deprecation warnings

2010-12-22 Thread Daniel Shahaf
Kamesh Jayachandran wrote on Wed, Dec 22, 2010 at 15:10:46 +0530: > On 12/22/2010 02:02 AM, vijay wrote: >> Hi, >> >> I have attached a patch that fixes few deprecation warnings while >> compiling libsvn_client/log.c. >> Attached log message also. >> >> Thanks & Regards, >> Vijayaguru > > Can you

Re: svn commit: r1051566 - /subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c

2010-12-22 Thread Daniel Shahaf
Julian Foad wrote on Wed, Dec 22, 2010 at 12:34:05 +: > danie...@apache.org wrote: > > When ignoring a warning, do so noisily if in maintainer mode. > > > > * subversion/libsvn_ra_local/ra_plugin.c > > (ignore_warnings): > > In maintainer mode, output notice that an error is being ignore

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

2010-12-22 Thread Daniel Shahaf
Blair Zajac wrote on Tue, Dec 21, 2010 at 19:48:49 -0800: > On 12/21/10 5:57 PM, Daniel Shahaf wrote: >> Blair Zajac wrote on Tue, Dec 21, 2010 at 13:47:40 -0800: >>> On 12/21/10 11:44 AM, Daniel Shahaf wrote: Daniel Shahaf wrote on Tue, Dec 21, 2010 at 20:40:02 +0200: > Blair Zajac wrote

Re: [PATCH] Issue #3653: svn update should not output svn:external fetches if they have not been updated

2010-12-22 Thread Daniel Shahaf
Forwarding back to the list. Tijn Porcelijn wrote on Wed, Dec 22, 2010 at 01:54:07 -0800: > Hi Daniel, > > I guess you're right. It makes more sense to echo the external URL > than the local directory in the "Updated external > 'url://remote/path/to/somewhere' to revision %ld". Anyway, my > sugge

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

2010-12-22 Thread Julian Foad
subversion/libsvn_repos/commit.c:648: no previous prototype for 'svn_repos__post_commit_error_str' - Julian bl...@apache.org wrote: > Add a private function that takes the error returned from > svn_repos_fs_commit_txn() and builds a error message string containing > either or both of the svn_fs_

Re: svn commit: r1051566 - /subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c

2010-12-22 Thread Julian Foad
danie...@apache.org wrote: > When ignoring a warning, do so noisily if in maintainer mode. > > * subversion/libsvn_ra_local/ra_plugin.c > (ignore_warnings): > In maintainer mode, output notice that an error is being ignored. > Update the comment, which was outdated by r1051559. subversi

Re: svn commit: r1051819 - /subversion/trunk/subversion/tests/cmdline/entries-dump.c

2010-12-22 Thread Noorul Islam K M
phi...@apache.org writes: > Author: philip > Date: Wed Dec 22 10:41:38 2010 > New Revision: 1051819 > > URL: http://svn.apache.org/viewvc?rev=1051819&view=rev > Log: > Make entries-dump fallback to operating on pre-wcng working copies. > This allows the 1.7 command line regression tests to be run

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

2010-12-22 Thread Julian Foad
Danny Trebbien wrote: > That's much better than mine, and I have verified that the tests are > the same. Please commit. Thanks very much. Committed revision 1051864. - Julian

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-22 Thread Philip Martin
Johan Corveleyn writes: > On Mon, Dec 20, 2010 at 11:19 AM, Philip Martin > wrote: >> Johan Corveleyn writes: >> >>> This makes the diff algorithm another 10% - 15% >>> faster (granted, this was measured with my "extreme" testcase of a 1,5 >>> Mb file (6 lines), of which most lines are iden

Re: svn commit: r1051804 - /subversion/trunk/subversion/libsvn_ra/util.c

2010-12-22 Thread Noorul Islam K M
rhuij...@apache.org writes: > Author: rhuijben > Date: Wed Dec 22 09:40:57 2010 > New Revision: 1051804 > > URL: http://svn.apache.org/viewvc?rev=1051804&view=rev > Log: > * subversion/libsvn_ra/util.c > (is_atomicity_error): Following up on r1051702, check pointer against NULL > instead of

Re: [PATCH] Fix some deprecation warnings

2010-12-22 Thread Kamesh Jayachandran
On 12/22/2010 02:02 AM, vijay wrote: Hi, I have attached a patch that fixes few deprecation warnings while compiling libsvn_client/log.c. Attached log message also. Thanks & Regards, Vijayaguru Can you pass scratch_pool for the below call as 'iterpool' and move the iterpool destruction dow