On 12/22/10 10:30 AM, Daniel Shahaf wrote:
bl...@apache.org wrote on Wed, Dec 22, 2010 at 17:01:21 -0000:
Author: blair
Date: Wed Dec 22 17:01:20 2010
New Revision: 1051988
URL: http://svn.apache.org/viewvc?rev=1051988&view=rev
Log:
Improve error messages from svn_repos__post_commit_error_str(). Also,
improve docs.
Found by: danielsh
* subversion/libsvn_repos/commit.c
(svn_repos__post_commit_error_str):
Since this skips over SVN_ERR_REPOS_POST_COMMIT_HOOK_FAILED,
include in all messages where the message is coming from,
post-commit processing or post-commit hook.
Modified:
subversion/trunk/subversion/libsvn_repos/commit.c
Modified: subversion/trunk/subversion/libsvn_repos/commit.c
hook_err1 = svn_error_find_cause(err,
SVN_ERR_REPOS_POST_COMMIT_HOOK_FAILED);
if (hook_err1&& hook_err1->child)
hook_err2 = hook_err1->child;
@@ -672,15 +676,15 @@ svn_repos__post_commit_error_str(svn_err
{
if (err == hook_err1)
{
- if (hook_err2->message)
- msg = apr_pstrdup(pool, hook_err2->message);
- else
- msg = "(no error message)";
+ msg = apr_psprintf(pool,
+ "Post-commit hook had error '%s'.",
+ hook_err2->message ? hook_err2->message
+ : "(no error message)");
}
else
{
msg = apr_psprintf(pool,
- "Post commit processing had error and '%s' "
+ "Post commit processing had error '%s' and "
"post-commit hook had error '%s'.",
These messages should be marked for translation?
Did those in r1052029.
Blair
