Re: svn commit: r1051745 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

On 12/22/2010 09:38 AM, bl...@apache.org wrote: Author: blair Date: Wed Dec 22 04:08:14 2010 New Revision: 1051745 URL: http://svn.apache.org/viewvc?rev=1051745&view=rev Log: Update test_commit_txn() to handle svn_fs_commit_txn()'s return semantics. * subversion/tests/libsvn_fs/fs-test.c (te

Re: [PATCH] Fix some deprecation warnings

On Wednesday 22 December 2010 11:32 AM, Noorul Islam K M wrote: vijay writes: Hi, I have attached a patch that fixes few deprecation warnings while compiling libsvn_client/log.c. Attached log message also. I could see this usage at one more place, subversion/svn/commit-cmd.c. Do you think t

[PATCH] Fix syntax inconsistency and update comments.

Find attached minor patch which makes 'if' syntax consistent and also some comment improvements. Log [[[ Fix syntax inconsistency and update comments. * libsvn_client/locking_commands.c (organize_lock_targets): Fix syntax inconsistency. Update comments. Patch by: Noorul Islam K M ]]] Than

Re: [PATCH] Fix some deprecation warnings

vijay writes: > Hi, > > I have attached a patch that fixes few deprecation warnings while > compiling libsvn_client/log.c. > Attached log message also. > I could see this usage at one more place, subversion/svn/commit-cmd.c. Do you think this can also be included as part of this patch? Thanks a

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 5:57 PM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 13:47:40 -0800: On 12/21/10 11:44 AM, Daniel Shahaf wrote: Daniel Shahaf wrote on Tue, Dec 21, 2010 at 20:40:02 +0200: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: 4) In svn_repos_fs_commit_txn(),

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

Blair Zajac wrote on Tue, Dec 21, 2010 at 13:47:40 -0800: > On 12/21/10 11:44 AM, Daniel Shahaf wrote: >> Daniel Shahaf wrote on Tue, Dec 21, 2010 at 20:40:02 +0200: >>> Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: 4) In svn_repos_fs_commit_txn(), which order should errors be comp

Re: [PATCH] Issue #3653: svn update should not output svn:external fetches if they have not been updated

This has a bug, when updating a file external it displays the external's directory rather than the external itself. (But maybe this is a bug in the way the library generates the notifications?) May I ask what is the motivation for this change? The normal notifications (U path/to/somewhere) wil

Ignored DAV errors

In dav_svn__checkin(), I see dav_svn__delete_activity() called but it doesn't pass the dav_error to the caller. Is this intentional? Blair

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 4:03 PM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 15:55:30 -0800: On 12/21/10 3:22 PM, Blair Zajac wrote: On 12/21/10 10:55 AM, Blair Zajac wrote: On 12/21/10 10:40 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: On 12/20/1

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

Blair Zajac wrote on Tue, Dec 21, 2010 at 15:55:30 -0800: > On 12/21/10 3:22 PM, Blair Zajac wrote: >> On 12/21/10 10:55 AM, Blair Zajac wrote: >>> On 12/21/10 10:40 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: > On 12/20/10 11:32 AM, C. Michael Pilato

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 3:22 PM, Blair Zajac wrote: On 12/21/10 10:55 AM, Blair Zajac wrote: On 12/21/10 10:40 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: On 12/20/10 11:32 AM, C. Michael Pilato wrote: On 12/20/2010 02:14 PM, Blair Zajac wrote: Shouldn't svn_repos_

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 10:55 AM, Blair Zajac wrote: On 12/21/10 10:40 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: On 12/20/10 11:32 AM, C. Michael Pilato wrote: On 12/20/2010 02:14 PM, Blair Zajac wrote: Shouldn't svn_repos_fs_commit_txn() always run the post-commi

Re: Windows svnsync test suite failures and a clue

Awesome effort Paul! On 22/12/2010, at 9:56 AM, Paul Burba wrote: > Problem solved, finally! > > Using a second work-issued Win7 box to build Subversion, I experienced > the same svnsync and svnrdump test failures I saw on my primary dev > box. So I was able to replicate the problem, but was

Re: Windows svnsync test suite failures and a clue

On Thu, Dec 16, 2010 at 5:22 PM, Paul Burba wrote: > On Tue, Nov 16, 2010 at 5:55 PM, Paul Burba wrote: >> As some of you know I've recently had some strange failures with the >> svnsync tests on both trunk and 1.6.x.  All the tests started failing >> during setup when the stdout of svnsync init

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 11:44 AM, Daniel Shahaf wrote: Daniel Shahaf wrote on Tue, Dec 21, 2010 at 20:40:02 +0200: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: 4) In svn_repos_fs_commit_txn(), which order should errors be composed? svn_fs_commit_txn()'s error as the parent followed by the SVN_

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

On Mon, Dec 20, 2010 at 4:11 PM, Julian Foad wrote: > On Mon, 2010-12-20, Danny Trebbien wrote: >> [[[ >> Add a public API function, svn_subst_translate_string2(), an extension of >> svn_subst_translate_string(), that has two additional output parameters for >> determining whether re-encoding and/

[PATCH] Fix some deprecation warnings

Hi, I have attached a patch that fixes few deprecation warnings while compiling libsvn_client/log.c. Attached log message also. Thanks & Regards, Vijayaguru [[[ Reslove some deprecation warnings using uri/dirent functions in its respective places. * subversion/libsvn_client/log.c (svn_clien

Re: buildbot failure in ASF Buildbot on svn-slik-w2k3-x64-ra

build...@apache.org wrote on Tue, Dec 21, 2010 at 19:57:09 +: > The Buildbot has detected a new failure of svn-slik-w2k3-x64-ra on ASF > Buildbot. > Full details are available at: > http://ci.apache.org/builders/svn-slik-w2k3-x64-ra/builds/1459 > > Buildbot URL: http://ci.apache.org/ > > Bu

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/2010 02:57 PM, Daniel Shahaf wrote: > C. Michael Pilato wrote on Tue, Dec 21, 2010 at 14:40:01 -0500: >> Can we fix this? Can we introduce a new error code >> SVN_ERR_RA_DAV_ERROR_CHAIN which means, "the descriptive message of this >> error contains a skel which, when parsed, carries a wh

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

C. Michael Pilato wrote on Tue, Dec 21, 2010 at 14:40:01 -0500: > On 12/21/2010 02:08 PM, Daniel Shahaf wrote: > > Blair Zajac wrote on Tue, Dec 21, 2010 at 10:55:37 -0800: > >> On 12/21/10 10:40 AM, Daniel Shahaf wrote: > >>> Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: > 4) In s

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

Daniel Shahaf wrote on Tue, Dec 21, 2010 at 20:40:02 +0200: > Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: > > 4) In svn_repos_fs_commit_txn(), which order should errors be composed? > > svn_fs_commit_txn()'s error as the parent followed by the > > SVN_ERR_REPOS_POST_COMMIT_HOOK_FA

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/2010 02:08 PM, Daniel Shahaf wrote: > Blair Zajac wrote on Tue, Dec 21, 2010 at 10:55:37 -0800: >> On 12/21/10 10:40 AM, Daniel Shahaf wrote: >>> Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: 4) In svn_repos_fs_commit_txn(), which order should errors be composed? svn_

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

Blair Zajac wrote on Tue, Dec 21, 2010 at 10:55:37 -0800: > On 12/21/10 10:40 AM, Daniel Shahaf wrote: >> Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: >>> 4) In svn_repos_fs_commit_txn(), which order should errors be composed? >>> svn_fs_commit_txn()'s error as the parent followed by t

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 11:08 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:55:37 -0800: On 12/21/10 10:40 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: 4) In svn_repos_fs_commit_txn(), which order should errors be composed? svn_fs_commit_txn()'

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

Blair Zajac wrote on Tue, Dec 21, 2010 at 10:55:37 -0800: > On 12/21/10 10:40 AM, Daniel Shahaf wrote: >> Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: >>> 4) In svn_repos_fs_commit_txn(), which order should errors be composed? >>> svn_fs_commit_txn()'s error as the parent followed by t

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/21/10 10:40 AM, Daniel Shahaf wrote: Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: On 12/20/10 11:32 AM, C. Michael Pilato wrote: On 12/20/2010 02:14 PM, Blair Zajac wrote: Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if new_rev is a valid rev? That d

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

Blair Zajac wrote on Tue, Dec 21, 2010 at 10:16:56 -0800: > On 12/20/10 11:32 AM, C. Michael Pilato wrote: >> On 12/20/2010 02:14 PM, Blair Zajac wrote: >>> Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if >>> new_rev is a valid rev? >> >> That does seem reasonable, yes. > > L

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

On 12/20/10 11:32 AM, C. Michael Pilato wrote: On 12/20/2010 02:14 PM, Blair Zajac wrote: Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if new_rev is a valid rev? That does seem reasonable, yes. Looking through our code, no existing use of svn_fs_commit_txn() and svn_r

Re: svn: database disk image is malformed

Daniel Shahaf wrote on Sat, Dec 18, 2010 at 20:41:43 +0200: > CC += dev@ > > Stefan Sperling wrote on Thu, Dec 16, 2010 at 18:49:22 +0100: > > On Thu, Dec 16, 2010 at 05:03:00PM +0100, Rainer Dorsch wrote: > > > I try to commit the change > > > > > > $ svn commit -m "minor change" > > > Sending

Re: svn_load_dirs.pl and paths with '@'

We build and deploy subversion using FreeBSD's ports system. There is a specific port for svn_load_dirs which replaces SVN_BINDIR and 'corrects' the path for perl: ${SED} -E \ -e 's|^(#!)/usr/bin/perl[[:>:]]|\1${PERL}|g' \ -e 's|@SVN_BINDIR@|${LOCALBASE}/bin|g' \ ${WRKSRC}/svn_load_dirs.pl.in > ${

Re: svn_load_dirs.pl and paths with '@'

C. Michael Pilato wrote: > On 12/21/2010 11:33 AM, Julian Foad wrote: > > Kevinm wrote: > >> Apologies Julian - it was the end of a long day :) > >> > >> Please find the patch attached... hopefully. > > > > Yup, it's there. > > > > Anyone know how we generate 'svn_load_dirs.pl' from > > 'svn_load

Re: svn_load_dirs.pl and paths with '@'

On 12/21/2010 11:33 AM, Julian Foad wrote: > Kevinm wrote: >> Apologies Julian - it was the end of a long day :) > >> >> Please find the patch attached... hopefully. > > Yup, it's there. > > Anyone know how we generate 'svn_load_dirs.pl' from > 'svn_load_dirs.pl.in'? I can't seem to find anythi

Re: svn_load_dirs.pl and paths with '@'

Kevinm wrote: > Apologies Julian - it was the end of a long day :) > > Please find the patch attached... hopefully. Yup, it's there. Anyone know how we generate 'svn_load_dirs.pl' from 'svn_load_dirs.pl.in'? I can't seem to find anything in "configure" or "make". I re-built and still it's not

Re: svn_load_dirs.pl and paths with '@'

Apologies Julian - it was the end of a long day :) Please find the patch attached... hopefully. On 20 December 2010 16:57, Julian Foad wrote: > Hi Kevin. > > Thanks for contributing this bug fix. > > '@' is called an 'at' sign; '&' is called an ampersand. > > Unfortunately your patch didn't rea

Re: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

On Tue, 2010-12-21 at 14:01 +, Julian Foad wrote: > On Tue, 2010-12-21 at 13:43 +, Julian Foad wrote: > > > > 1.5.9 tarballs are up for testing and signing. [...] > > > > I had some trouble building this but have now got the main tests > > ... working. > > I have not been able to run an

Re: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

On Tue, 2010-12-21 at 13:43 +, Julian Foad wrote: > > > 1.5.9 tarballs are up for testing and signing. [...] > > I had some trouble building this but have now got the main tests ... working. I have not been able to run any of the bindings tests. Details at or

Re: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

> > 1.5.9 tarballs are up for testing and signing. [...] I had some trouble building this but have now got the main tests Summary: +1 to release (Unix). My two signatures were successfully collected by your script. Tested: [ bdb | fsfs ] x [ ra_local | ra_svn | ra_neon | ra_serf ] Env

Re: svn commit: r1050061 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

On Sat, 18 Dec 2010, Hyrum K. Wright wrote: On Thu, Dec 16, 2010 at 11:18 AM, wrote: Author: cmpilato Date: Thu Dec 16 17:18:43 2010 New Revision: 1050061 URL: http://svn.apache.org/viewvc?rev=1050061&view=rev Log: Rev the svn_io_start_cmd() API, adding pipe support. Modified: subversion/

Re: [PATCH] WCNG: Enforce that a pristine checksum always references an entry in the pristine store.

Philip Martin wrote: > Philip Martin writes: > > > Philip Martin writes: > > > >>> +SVN_ERR(svn_io_file_checksum2(&file_info->sha1_checksum, > >>> text_base_path, > >>> + svn_checksum_sha1, result_pool)); > >> > >> How much memory is allocated when c

Re: Default commandline args

Bert Huijben wrote on Tue, Dec 21, 2010 at 10:00:37 +0100: > > -Original Message- > > From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf Of > > Hyrum K. Wright > > Sent: maandag 20 december 2010 23:29 > > To: Subversion Development > > Subject: Default commandline args > >

Re: [PATCH] WCNG: Enforce that a pristine checksum always references an entry in the pristine store.

Philip Martin writes: > Philip Martin writes: > >>> +SVN_ERR(svn_io_file_checksum2(&file_info->sha1_checksum, >>> text_base_path, >>> + svn_checksum_sha1, result_pool)); >> >> How much memory is allocated when checksumming a file? That's all going >

Re: [PATCH] WCNG: Enforce that a pristine checksum always references an entry in the pristine store.

Philip Martin writes: >> +SVN_ERR(svn_io_file_checksum2(&file_info->sha1_checksum, >> text_base_path, >> + svn_checksum_sha1, result_pool)); > > How much memory is allocated when checksumming a file? That's all going > into the long-lived result pool

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

Julian Foad wrote on Tue, Dec 21, 2010 at 00:11:01 +: > Committed revision 1051322. Nice :-).

Re: [PATCH] WCNG: Enforce that a pristine checksum always references an entry in the pristine store.

Julian Foad writes: > @@ -1009,23 +1034,25 @@ migrate_text_bases(const char *dir_abspa > complexity. :) */ > > /* Gather the two checksums. */ > -SVN_ERR(svn_io_file_checksum2(&md5_checksum, text_base_path, > - svn_checksum_

Re: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

On Mon, Dec 20, 2010 at 07:58:47PM +0100, Stefan Sperling wrote: > On Mon, Dec 20, 2010 at 12:31:55PM -0600, Hyrum K. Wright wrote: > > We got two sigs for each of Windows and Unix for 1.5.9, but the > > signing process has stalled from there. I'd still like to release > > this, if possible, but w

RE: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing)

> -Original Message- > From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf Of > Hyrum K. Wright > Sent: maandag 20 december 2010 19:32 > To: Subversion Development > Subject: Will we release 1.5.9? (was Re: 1.5.9 up for testing/signing) > > We got two sigs for each of Win

RE: Default commandline args

> -Original Message- > From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf Of > Hyrum K. Wright > Sent: maandag 20 december 2010 23:29 > To: Subversion Development > Subject: Default commandline args > > In issue #3765, I suggest the possibility of a CVS-style config file

Re: Default commandline args

On 21.12.2010 08:31, Stefan Sperling wrote: > The svnrc file should not be created by libsvn_client, though. > The cli client could create it after initializing the client library, > at which point the config directory is guaranteed to exist (if I remember > correctly). Indeed, the proposed "defau