Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Philipp Marek
How about returning a pointer to an empty string (zero length) at some fixed address (eg. allocated statically), which is good enough for most callers, but provide a function or symbol that compares against that address? This way you'd get an empty string back; if you care whether the property

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Hyrum K. Wright
On Wed, Oct 13, 2010 at 3:16 PM, Steinar Bang wrote: >> "Hyrum K. Wright" : > >> At this point, it's my turn to get confused.  I'm speaking >> specifically of cases where we return STL classes.  Brane's earlier >> suggestion to create an implicit bool conversion works fine for our >> custom cl

Re: svn commit: r1022255 - /subversion/branches/1.6.x/STATUS

2010-10-13 Thread Stefan Sperling
On Wed, Oct 13, 2010 at 07:34:56PM -, cmpil...@apache.org wrote: > Author: cmpilato > Date: Wed Oct 13 19:34:55 2010 > New Revision: 1022255 > > URL: http://svn.apache.org/viewvc?rev=1022255&view=rev > Log: > Propose (without yet adding my own strong vote) the backport of > \^/subversion/1.6.x

Re: svn commit: r1022250 - /subversion/site/publish/packages.html

2010-10-13 Thread C. Michael Pilato
On 10/13/2010 04:13 PM, Blair Zajac wrote: > On 10/13/2010 12:26 PM, hwri...@apache.org wrote: >> Author: hwright >> Date: Wed Oct 13 19:26:49 2010 >> New Revision: 1022250 >> > >> +http://www.wandisco.com/subversion/os/downloads";> >> +WANdisco (professionally supported and certified by

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Steinar Bang
> "Hyrum K. Wright" : > At this point, it's my turn to get confused. I'm speaking > specifically of cases where we return STL classes. Brane's earlier > suggestion to create an implicit bool conversion works fine for our > custom classes. The problem I'm trying to solve is "how does one > r

Re: svn commit: r1022250 - /subversion/site/publish/packages.html

2010-10-13 Thread Blair Zajac
On 10/13/2010 12:26 PM, hwri...@apache.org wrote: Author: hwright Date: Wed Oct 13 19:26:49 2010 New Revision: 1022250 +http://www.wandisco.com/subversion/os/downloads";> +WANdisco (professionally supported and certified by What do we mean that it's been "certified". I'm thinking

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Steinar Bang
> "Hyrum K. Wright" : > This is an interesting approach...and parallels what has already been > done. :) > Out of curiosity, have you taken a chance to look at the > existing code here: > http://svn.apache.org/repos/asf/subversion/branches/object-model/subversion/bindings/c++/include/Types.h

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Hyrum K. Wright
On Wed, Oct 13, 2010 at 2:42 PM, Steinar Bang wrote: >> "Hyrum K. Wright" : > >> Refcounting smartpointers are used to avoid duplication of the >> underlying C structures, but they are completely private.  I've got >> serious reservations about exposing that complexity in the external >> objec

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Steinar Bang
> "Hyrum K. Wright" : > Refcounting smartpointers are used to avoid duplication of the > underlying C structures, but they are completely private. I've got > serious reservations about exposing that complexity in the external > object interfaces. Given those reservations, the API would just

Re: svn commit: r1021511 - /subversion/site/publish/source-code.html

2010-10-13 Thread Hyrum Wright
It was already on that page, I just didn't do it when I pushed the release. (Habit, didn't read the page, $EXCUSE, etc.) Thanks for the suggestion anyhow, though. -Hyrum On Mon, Oct 11, 2010 at 8:21 PM, C. Michael Pilato wrote: > If you haven't already, please add this to the list of website s

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Hyrum K. Wright
On Wed, Oct 13, 2010 at 2:28 PM, Steinar Bang wrote: >> Steinar Bang : > >> "Hyrum K. Wright" : >>> 2) Return everything by pointer >>> Pros: can represent the NULL value, potentially less memory overhead >>> Cons: more complex memory management (caller must delete returned value) > >> Um.

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Hyrum K. Wright
On Wed, Oct 13, 2010 at 11:51 AM, Steinar Bang wrote: >> "Hyrum K. Wright" : > >> 2) Return everything by pointer >>    Pros: can represent the NULL value, potentially less memory overhead >>    Cons: more complex memory management (caller must delete returned value) > > Um... why must the cal

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Steinar Bang
> Steinar Bang : > "Hyrum K. Wright" : >> 2) Return everything by pointer >> Pros: can represent the NULL value, potentially less memory overhead >> Cons: more complex memory management (caller must delete returned value) > Um... why must the caller delete the returned value? I thought y

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Hyrum K. Wright
On Wed, Oct 13, 2010 at 11:44 AM, Julien Cugnière wrote: > 2010/10/13 Hyrum K. Wright >> Another option is a custom SVN::String type which looks / smells / >> acts like a string, but also allows wrapping the NULL value, in a >> manner you suggest above. > > Sorry to intrude, but just an additiona

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-10-13 Thread scott mc
Here's the updated patch vs. svn r1022152, feel free to add a "reviewed by" to the message below. Thanks, -scottmc -- This patch makes use of find_directory() on Haiku to locate the proper directori

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Steinar Bang
> "Hyrum K. Wright" : > 2) Return everything by pointer >Pros: can represent the NULL value, potentially less memory overhead >Cons: more complex memory management (caller must delete returned value) Um... why must the caller delete the returned value? I thought you were using refcou

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Julien Cugnière
2010/10/13 Hyrum K. Wright > Another option is a custom SVN::String type which looks / smells / > acts like a string, but also allows wrapping the NULL value, in a > manner you suggest above. Sorry to intrude, but just an additional possibility : can the strings manipulated by SVN contain embedde

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread Hyrum K. Wright
On Tue, Oct 12, 2010 at 5:06 PM, Branko Čibej wrote: >  On 12.10.2010 22:30, Hyrum K. Wright wrote: >> On Tue, Oct 12, 2010 at 2:40 PM, Branko Čibej wrote: >>>  On 12.10.2010 20:35, Hyrum K. Wright wrote: 1) Return everything by value    Pros: simpler memory management, less overhead (?

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-13 Thread C. Michael Pilato
On 10/12/2010 06:06 PM, Branko Čibej wrote: > So typically you'd add a hasAuthor function and throw an exception from > getAuthor if there is no author info for a revision. However, in this > particular case, returning an empty string is just as good, unless you > want to make the fine distinction

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-10-13 Thread Philip Martin
Gavin Beau Baumanis writes: >> --- subversion-1.7.xx-svn/subversion/libsvn_subr/config_impl.h >> (revision >> 1002735) >> +++ subversion-1.7.xx-svn/subversion/libsvn_subr/config_impl.h >> (working copy) >> @@ -114,8 +114,11 @@ >>or svn_config_get_user_config_path() instead. */ >

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-10-13 Thread Gavin Beau Baumanis
Ping. This submission has received no responses in over a week. Gavin "Beau" Baumanis On 05/10/2010, at 5:21 AM, scott mc wrote: > I've attached the 1.6.12 patch and the 1.7.xx-svn patches. >> -scottmc >> >> Scott McCreary >> HaikuPorts >> > > This time as in-line text: > > ---

Re: svn commit: r1021795 - introducing svn_wc_add_from_disk()

2010-10-13 Thread Greg Stein
On Wed, Oct 13, 2010 at 07:16, Julian Foad wrote: > On Tue, 2010-10-12, julianf...@apache.org wrote: >> URL: http://svn.apache.org/viewvc?rev=1021795&view=rev >> Log: >> Introduce svn_wc_add_from_disk() as a new API to replace one task that was >> previously performed by svn_wc_add4().  There are

Re: svn commit: r1021795 - introducing svn_wc_add_from_disk()

2010-10-13 Thread Julian Foad
On Tue, 2010-10-12, julianf...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1021795&view=rev > Log: > Introduce svn_wc_add_from_disk() as a new API to replace one task that was > previously performed by svn_wc_add4(). There are no callers yet. I updated the libsvn_client callers in r