Re: Some tips on profiling

2010-09-29 Thread Daniel Näslund
On Thu, Sep 30, 2010 at 07:58:45AM +0530, Ramkumar Ramachandra wrote: > Stefan Fuhrmann writes: > > At least the results are much more useful when there is > > a tool like Kcachegrind that allows easy navigation though > > the huge amount of information that was gathered. > > Yep! The visualizer

Re: Some tips on profiling

2010-09-29 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Fuhrmann writes: > My measurements seem to support what Philip wrote: > The expensive part is run on the server. Even with my > optimized server, the svnrdump CPU usage is less than > the time taken by the server. Some numbers (hot file > cache): > > svnadmin dump > 1.7 trun

Re: svn commit: r1002898 - in /subversion/trunk: ./ subversion/include/svn_string.h subversion/libsvn_subr/svn_string.c

2010-09-29 Thread Blair Zajac
On 09/29/2010 05:01 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Sep 30 00:01:45 2010 New Revision: 1002898 URL: http://svn.apache.org/viewvc?rev=1002898&view=rev Log: Merge r1001413 from the performance branch. Improve documentation on svn_stringbuf_appendbyte. Approved by: Hyrum K

Re: Some tips on profiling

2010-09-29 Thread Stefan Fuhrmann
On 29.09.2010 10:45, Ramkumar Ramachandra wrote: Hi Philip, Philip Martin writes: The performance of svnrdump is likely to be dominated by IO from the repository, network or disk depending on the RA layer. strace is a useful tool to see opens/reads/writes. You can see what order the calls o

Re: svn commit: r1002839 - /subversion/site/publish/docs/release-notes/index.html

2010-09-29 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Sep 29, 2010 at 22:51:43 +0200: > On Wed, Sep 29, 2010 at 08:38:13PM -, stevek...@apache.org wrote: > > Author: steveking > > Date: Wed Sep 29 20:38:13 2010 > > New Revision: 1002839 > > > > URL: http://svn.apache.org/viewvc?rev=1002839&view=rev > > Log: > > * pub

Re: svn commit: r1002839 - /subversion/site/publish/docs/release-notes/index.html

2010-09-29 Thread Daniel Shahaf
stevek...@apache.org wrote on Wed, Sep 29, 2010 at 20:38:13 -: > Author: steveking > Date: Wed Sep 29 20:38:13 2010 > New Revision: 1002839 > > URL: http://svn.apache.org/viewvc?rev=1002839&view=rev > Log: > * publish/docs/release-notes/index.html > (Supported versions): new section > > Mod

Re: supported versions

2010-09-29 Thread Daniel Shahaf
Stefan Küng wrote on Wed, Sep 29, 2010 at 21:42:55 +0200: > Is there a way to get a preview of the modified html files? Showing them > in a browser doesn't show them properly so it's hard to figure out if > the changes are correct. I preview them in a locally-installed httpd. (I already had o

Re: svn commit: r1002839 - /subversion/site/publish/docs/release-notes/index.html

2010-09-29 Thread Stefan Sperling
On Wed, Sep 29, 2010 at 08:38:13PM -, stevek...@apache.org wrote: > Author: steveking > Date: Wed Sep 29 20:38:13 2010 > New Revision: 1002839 > > URL: http://svn.apache.org/viewvc?rev=1002839&view=rev > Log: > * publish/docs/release-notes/index.html > (Supported versions): new section > +1

Re: supported versions

2010-09-29 Thread Stefan Sperling
On Wed, Sep 29, 2010 at 09:56:33PM +0200, Stefan Küng wrote: > On 29.09.2010 21:27, Hyrum K. Wright wrote: > > >Yeah, something on the download page is probably appropriate. Wanna > >take a whack at it? > > Patch attached. This looks fine. I'd say just commit it. If there's anything wrong with

1.6.13 up for signing/testing

2010-09-29 Thread Hyrum K. Wright
1.6.13 tarballs are up for testing and signing. The magic revision is r1002816: http://people.apache.org/~hwright/svn/1.6.13/ As usual, signatures from full committers please send back to me. Testing by enthusiastic users is also welcomed (but remember that this is not yet a blessed release, with

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-09-29 Thread scott mc
On Wed, Sep 29, 2010 at 5:45 PM, Philip Martin wrote: > Please write a log message: - This patch makes use of find_directory() on Haiku to locate the proper directories to use. Currently B_USER_SETTINGS_DIRECTORY points to /boot/home/config/settings, so this puts the .subversion directo

Re: supported versions

2010-09-29 Thread Stefan Küng
On 29.09.2010 21:27, Hyrum K. Wright wrote: Yeah, something on the download page is probably appropriate. Wanna take a whack at it? Patch attached. Stefan -- ___ oo // \\ "De Chelonian Mobile" (_,\/ \_/ \ TortoiseSVN \ \_/_\_/>The coolest Interface to (Sub)Version

Re: supported versions

2010-09-29 Thread Stefan Küng
On 29.09.2010 21:27, Hyrum K. Wright wrote: Not the easiest to find, but: http://subversion.apache.org/docs/release-notes/1.6.html#svn-1.4-deprecation Thanks, this really isn't easy to find. May I suggest to add a separate page explaining in detail which versions are supported and with what (

Re: supported versions

2010-09-29 Thread Stefan Sperling
On Wed, Sep 29, 2010 at 08:36:18PM +0200, Stefan Küng wrote: > Hi, > > Just had a discussion with WANdisco about the versions that are > supported for TSVN. Since their customer is using an 1.4.x server I > wanted to check which version SVN still supports, i.e., provides at > least security update

Re: supported versions

2010-09-29 Thread Hyrum K. Wright
On Wed, Sep 29, 2010 at 2:16 PM, Stefan Küng wrote: > On 29.09.2010 20:45, Hyrum K. Wright wrote: >> >> On Wed, Sep 29, 2010 at 1:36 PM, Stefan Küng >>  wrote: >>> >>> Hi, >>> >>> Just had a discussion with WANdisco about the versions that are supported >>> for TSVN. Since their customer is using

Re: supported versions

2010-09-29 Thread Stefan Küng
On 29.09.2010 20:45, Hyrum K. Wright wrote: On Wed, Sep 29, 2010 at 1:36 PM, Stefan Küng wrote: Hi, Just had a discussion with WANdisco about the versions that are supported for TSVN. Since their customer is using an 1.4.x server I wanted to check which version SVN still supports, i.e., provid

Re: supported versions

2010-09-29 Thread Hyrum K. Wright
On Wed, Sep 29, 2010 at 1:36 PM, Stefan Küng wrote: > Hi, > > Just had a discussion with WANdisco about the versions that are supported > for TSVN. Since their customer is using an 1.4.x server I wanted to check > which version SVN still supports, i.e., provides at least security updates > for. Bu

supported versions

2010-09-29 Thread Stefan Küng
Hi, Just had a discussion with WANdisco about the versions that are supported for TSVN. Since their customer is using an 1.4.x server I wanted to check which version SVN still supports, i.e., provides at least security updates for. But I couldn't find anything on the web about that. I think

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-09-29 Thread Philip Martin
scott mc writes: Please write a log message: http://subversion.apache.org/docs/community-guide/conventions.html#log-messages Please use spaces rather than tabs for indentation. > Index: subversion/libsvn_subr/config_file.c > === >

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-09-29 Thread scott mc
> Unfortunately this mailing list appears to be silently dropping > attachments in some cases. Can you try again with a .txt extension? > > Also, would it be possible for you to send a patch that's relative > to Subversion's trunk code, rather than 1.6.12? > > Thanks, > Stefan > Sure. Here it is

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-09-29 Thread Stefan Sperling
On Wed, Sep 29, 2010 at 07:37:27AM -0700, scott mc wrote: > Here is the patch we use for building subversion on Haiku. > -scottmc > > Scott McCreary > HaikuPorts Unfortunately this mailing list appears to be silently dropping attachments in some cases. Can you try again with a .txt extension? Al

[PATCH] for building subversion 1.6.12 for haiku

2010-09-29 Thread scott mc
Here is the patch we use for building subversion on Haiku. -scottmc Scott McCreary HaikuPorts

What happened to svndiff1

2010-09-29 Thread Ramkumar Ramachandra
Hi, I'd like to know what happened to svndiff version 1 format. All the specs and code including notes/dump-load-format.txt seem to refer only to svndiff0. -- Ram

Re: [PATCH] don't do autoprops on symbolic links

2010-09-29 Thread Stefan Sperling
On Wed, Sep 29, 2010 at 10:56:17AM +1000, Gavin Beau Baumanis wrote: > As a result of no comments for this patch , I have logged it into the issue > tracker so that it doesn't get lost. > > http://subversion.tigris.org/issue-tracker.html > Issue Number : #3722 I've committed the patch. Thanks ve

Re: svn commit: r1002151 - in /subversion/trunk/subversion: libsvn_auth_kwallet/kwallet.cpp svn/main.c svnsync/main.c

2010-09-29 Thread Stefan Sperling
On Tue, Sep 28, 2010 at 11:21:26AM -0700, Blair Zajac wrote: > On 9/28/2010 6:07 AM, s...@apache.org wrote: > >Author: stsp > >Date: Tue Sep 28 13:07:23 2010 > >New Revision: 1002151 > > > >URL: http://svn.apache.org/viewvc?rev=1002151&view=rev > >Log: > >Remove some goo introduced in r878078 and f

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Dominique Leuenberger
On Wed, 2010-09-29 at 12:42 +0200, Daniel Shahaf wrote: > > > > For me either way is fine: I can update the patch to also detect newer > > versions as suggest by you. Which in turn will still break all the other > > detections of SVN_NEON_0_28 and older. Or we keep them 'in sync' > > together and

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Daniel Shahaf
Dominique Leuenberger wrote on Mon, Sep 27, 2010 at 14:48:20 +0200: > On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > > > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > > needs to be something like: > > > > if test -n ["`echo "$NEON_VERSION" | $EGREP > > '^(([1-

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Jon Foster
Dominique wrote: > On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > > needs to be something like: > > > > if test -n ["`echo "$NEON_VERSION" | $EGREP > > '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then > > > >

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Dominique Leuenberger
On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > needs to be something like: > > if test -n ["`echo "$NEON_VERSION" | $EGREP > '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then > > ? That should match 0.29-0.99 an

Re: add NODES.prior_deleted boolean column

2010-09-29 Thread Philip Martin
Greg Stein writes: > To do this, it seems that we're going to need to expose (from wc_db.h) > a structure containing "all" the row data. Thankfully, this big ol' > structure is *private* to libsvn_wc, and we can change it at will > (unlike svn_wc_status_t). I would suggest that we use a callback

Re: Some tips on profiling

2010-09-29 Thread Ramkumar Ramachandra
Hi Philip, Philip Martin writes: > The performance of svnrdump is likely to be dominated by IO from the > repository, network or disk depending on the RA layer. strace is a > useful tool to see opens/reads/writes. You can see what order the > calls occur, how many there are, how big they are and

Re: svn commit: r1002503 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > == > > --- subversion/trunk/subversion/svnrdump/dump_editor.c (original) > > +++ subversion/trunk/subversion/svnrdump/dump_editor.c Wed Sep 29 07:52:55 > > 2010 > > @@ -143,8 +143,7 @@

Re: svn commit: r1002470 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > So, you use a top-level pool but never destroy it? > > That's not good. > > Can you please find another solution? (Either get the caller to > guarantee something about the lifetime of the pool they provide (there > is precedent for this), or figure out why clo

Re: svn commit: r1002503 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Daniel Shahaf
artag...@apache.org wrote on Wed, Sep 29, 2010 at 07:52:55 -: > Author: artagnon > Date: Wed Sep 29 07:52:55 2010 > New Revision: 1002503 > > URL: http://svn.apache.org/viewvc?rev=1002503&view=rev > Log: > svnrdump: dump_editor: Avoid duplicating strings unnecessarily > > * subversion/svnrdum

Re: svn commit: r1002502 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Daniel Shahaf
artag...@apache.org wrote on Wed, Sep 29, 2010 at 07:44:48 -: > Author: artagnon > Date: Wed Sep 29 07:44:48 2010 > New Revision: 1002502 > > URL: http://svn.apache.org/viewvc?rev=1002502&view=rev > Log: > svnrdump: dump_editor: Followup r1002470 to avoid creating a toplevel > pool by changing

Re: svn commit: r1002470 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Daniel Shahaf
So, you use a top-level pool but never destroy it? That's not good. Can you please find another solution? (Either get the caller to guarantee something about the lifetime of the pool they provide (there is precedent for this), or figure out why close_edit() isn't called (and possibly patch the f