Re: [PATCH 2/3],[PATCH 3/3] atomic-revprop: status

Done in r999179, r999182, r999184 on the branch.

[PATCH 2/3],[PATCH 3/3] atomic-revprop: status

Daniel Shahaf wrote on Tue, Sep 21, 2010 at 01:19:06 +0200: > Thanks for the review. > > As discussed on IRC, I'll proceed as follows: > > 1. Rename the error codes (per Bert and Blair) Done. > 2. Commit your patch 3/3 about using 412 to preserve err->apr_err over DAV Running tests on the atta

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Jon Foster wrote on Tue, Sep 21, 2010 at 00:43:13 +0100: > Hi, > > Updated patch attached. > > [[[ > Signal SVN_ERR_BAD_OLD_VALUE over DAV using a HTTP 412 status > code inside a 207 multi-status response. > > * subversion/mod_dav_svn/util.c > (dav_svn__convert_err): Map SVN_ERR_BAD_OLD_VALUE

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Hi, The error code changed while I was e-mailing the patch. Here's the patch with the new error code. [[[ Signal SVN_ERR_FS_PROP_BASEVALUE_MISMATCH over DAV using a HTTP 412 status code inside a 207 multi-status response. * subversion/mod_dav_svn/util.c (dav_svn__convert_err): Map SVN_ERR_FS_

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Hi, Updated patch attached. [[[ Signal SVN_ERR_BAD_OLD_VALUE over DAV using a HTTP 412 status code inside a 207 multi-status response. * subversion/mod_dav_svn/util.c (dav_svn__convert_err): Map SVN_ERR_BAD_OLD_VALUE to 412. * subversion/libsvn_ra_neon/util.c (multistatus_baton_t): New mem

Re: [PATCH 2/3] atomic-revprop: Change tests

Thanks for the review. As discussed on IRC, I'll proceed as follows: 1. Rename the error codes (per Bert and Blair) 2. Commit your patch 3/3 about using 412 to preserve err->apr_err over DAV 3. Commit my want_error patch (which will pass thanks to #2) I think after this there will be only 1-2 it

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Jon Foster wrote on Mon, Sep 20, 2010 at 22:59:02 +0100: > Daniel Shahaf wrote: > > Jon Foster wrote on Mon, Sep 20, 2010 at 11:01:02 +0100: > > > However, there is a simpler way! The element contains > > > the HTTP error code, usually "500 Internal Server Error". So we > > > could pick a specia

RE: [PATCH 2/3] atomic-revprop: Change tests

Hi, Daniel Shahaf wrote: > Jon Foster wrote on Mon, Sep 20, 2010 at 12:39:31 +0100: > > Daniel Shahaf wrote: > > > Jon Foster wrote on Mon, Sep 20, 2010 at 10:48:44 +0100: > > > > [[[ > > > > Change atomic-revprop tests to look at the error number rather > > > > than parsing the error text. > > >

Re: svn client has inconsistent returnstatus for non-existing local files

Sjon Hortensius wrote on Thu, Sep 16, 2010 at 17:04:19 +0200: > LS, > > Please advise if this is a bug, or a known feature. I have a local > checkout on which I can execute svn commands. However, there seems to > be some inconsistency in the exitcode of the client. > > `svn ls repository/non-exis

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Daniel Shahaf wrote: > Jon Foster wrote on Mon, Sep 20, 2010 at 11:01:02 +0100: > > However, there is a simpler way! The element contains > > the HTTP error code, usually "500 Internal Server Error". So we > > could pick a special HTTP status code to mean SVN_ERR_BAD_OLD_VALUE. > > I think of ol

add NODES.prior_deleted boolean column

After working through the several email messages, and discussion, I believe we're now down to a simple change: * add a "prior_deleted" flag to NODES The flag simply means that a node exists prior to this layer and has been deleted or moved-away. The 'presence' column may say the same thing, but i

Re: [PATCH] NODES table presence values

On Mon, Sep 20, 2010 at 15:36, Greg Stein wrote: >... > Erik and I talked further on IRC... > > I believe the right approach is a simple boolean "prior-deleted", > meaning "the nodes visible just under *this* layer have been deleted". > Examining the root node's moved_to column can refine how the

Re: [PATCH] NODES table presence values

On Mon, Sep 20, 2010 at 14:07, Julian Foad wrote: > On Mon, 2010-09-20 at 18:45 +0100, Julian Foad wrote: >... >> FULL SET OF VALUES >> >> The values listed above cover most of the cases.  Next we must consider >> how to get a full set of values to represent all possible changes. >> >> The possibl

Re: svn commit: r998880 - in /subversion/trunk/subversion: include/svn_error_codes.h include/svn_fs.h libsvn_fs_base/revs-txns.c libsvn_fs_fs/fs_fs.c tests/libsvn_fs/fs-test.c

On 09/20/2010 03:36 AM, danie...@apache.org wrote: Author: danielsh Date: Mon Sep 20 10:36:29 2010 New Revision: 998880 URL: http://svn.apache.org/viewvc?rev=998880&view=rev Log: Use a new, distinct error code if svn_fs_change_rev_prop2's old_value_p doesn't match. * subversion/include/svn_erro

Re: [PATCH] NODES table presence values

On Mon, 2010-09-20 at 18:45 +0100, Julian Foad wrote: > On Mon, 2010-09-20 at 13:17 -0400, Greg Stein wrote: > > On Thu, Sep 16, 2010 at 09:21, Julian Foad wrote: > > > Greg Stein wrote: > > >... > > >> Also, please note that I want to expand the presence values > > >> dramatically with this move

Re: [PATCH] NODES table presence values

On Mon, 2010-09-20 at 13:17 -0400, Greg Stein wrote: > On Thu, Sep 16, 2010 at 09:21, Julian Foad wrote: > > Greg Stein wrote: > >... > >> Also, please note that I want to expand the presence values > >> dramatically with this move to NODES. I suggest the following new > >> values: > > > > Can you

Re: [PATCH] NODES table presence values

On Thu, Sep 16, 2010 at 09:21, Julian Foad wrote: > Greg Stein wrote: >... >> Also, please note that I want to expand the presence values >> dramatically with this move to NODES. I suggest the following new >> values: > > Can you explain what these would mean, and what are the main advantages? Pr

Re: [PATCH] issue #3641: svnsync fails to mirror certain dir replaces

Tino Schwarze wrote on Mon, Sep 20, 2010 at 16:28:23 +0200: > On Mon, Sep 20, 2010 at 02:49:42PM +0200, Daniel Shahaf wrote: > > > > Has anybody reviewed the patch? > > > > > > Too late for 1.6.13, I suppose? > > > > No. I've just added it to STATUS. That's the easiest way to ask for > > revie

Re: UTF-8 NFC/NFD paths issue

Sorry to have left the discussion running so long without contributing to it myself. The reason I started about changing the repository / fs is because it is where we store the dataset that we'll need to support forever: working copies get destroyed and checked out over and over every hour, every d

Re: [PATCH] issue #3641: svnsync fails to mirror certain dir replaces

On Mon, Sep 20, 2010 at 02:49:42PM +0200, Daniel Shahaf wrote: > > Has anybody reviewed the patch? > > > > Too late for 1.6.13, I suppose? > > No. I've just added it to STATUS. That's the easiest way to ask for > reviews here :-) Thanks, but the Justification is not just "Could lead to sync'd

RE: Terminology (was: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code)

> -Original Message- > From: 'Daniel Shahaf' [mailto:d...@daniel.shahaf.name] > Sent: maandag 20 september 2010 12:58 > To: Bert Huijben > Cc: 'Jon Foster'; 'Subversion Development' > Subject: Terminology (was: [PATCH 3/3] atomic-revprop: Signal the error > as a HTTP status code) > > Ber

Re: UTF-8 NFC/NFD paths issue

On 17.09.2010 13:22, Greg Stein wrote: > On Thu, Sep 16, 2010 at 19:26, Daniel Shahaf wrote: >> Greg Stein wrote on Thu, Sep 16, 2010 at 00:59:59 -0400: >>> On Wed, Sep 15, 2010 at 23:35, Daniel Shahaf >>> wrote: >> ... If yes, then we infer that no two in-repository paths (which are

Re: [PATCH] issue #3641: svnsync fails to mirror certain dir replaces

Tino Schwarze wrote on Mon, Sep 20, 2010 at 12:59:46 +0200: > Ping! > > Has anybody reviewed the patch? > > Too late for 1.6.13, I suppose? > No. I've just added it to STATUS. That's the easiest way to ask for reviews here :-) Daniel > Thanks, > > Tino. > > On Fri, Jul 09, 2010 at 12:57:1

Re: [PATCH 2/3] atomic-revprop: Change tests

Jon Foster wrote on Mon, Sep 20, 2010 at 12:39:31 +0100: > Hi, > > Daniel Shahaf wrote: > > Jon Foster wrote on Mon, Sep 20, 2010 at 10:48:44 +0100: > > > Hi, > > > > > > This patch changes the tests for the atomic-revprop feature, so that > > > they test the error number rather than parsing the

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Jon Foster wrote on Mon, Sep 20, 2010 at 11:01:02 +0100: > This patch only does mod_dav_svn and Neon. I don't want to waste > time doing both HTTP libraries if this patch is rejected. You always have the option of discussing your plans here or on IRC before starting to write the patches. :-) Fee

Re: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Jon Foster wrote on Mon, Sep 20, 2010 at 11:01:02 +0100: > Hi, > > For atomic-revprop, the client needs to know if the error was > SVN_ERR_BAD_OLD_VALUE or not. For ra_local and ra_svn this is > already done; this patch does it for DAV (with Neon). > > > With mod_dav, we only have 2 ways to aff

RE: [PATCH 2/3] atomic-revprop: Change tests

Hi, Daniel Shahaf wrote: > Jon Foster wrote on Mon, Sep 20, 2010 at 10:48:44 +0100: > > Hi, > > > > This patch changes the tests for the atomic-revprop feature, so that > > they test the error number rather than parsing the error text. > > This doesn't work with Serf or Neon yet - they're still

Re: svn diff optimization to make blame faster?

On Mon, Sep 20, 2010 at 11:52 AM, Branko Čibej wrote: >  On 15.09.2010 14:20, Johan Corveleyn wrote: >> Some update on this: I have implemented this for svn_diff (excluding >> the identical prefix and suffix of both files, and only then starting >> to fill up the token tree and let the lcs-agorith

Re: [PATCH] issue #3641: svnsync fails to mirror certain dir replaces

Ping! Has anybody reviewed the patch? Too late for 1.6.13, I suppose? Thanks, Tino. On Fri, Jul 09, 2010 at 12:57:16AM +0300, Daniel Shahaf wrote: > Daniel Shahaf wrote on Tue, 22 Jun 2010 at 20:50 -: > > http://subversion.tigris.org/issues/show_bug.cgi?id=3641 > > > > Briefly, the issue

Terminology (was: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code)

Bert Huijben wrote on Mon, Sep 20, 2010 at 12:17:12 +0200: > I think 'SVN_ERR_BAD_OLD_VALUE' could use a better/more generic name though. > ('Old value' is only valid in the specific function context. Maybe extend > this to something more like this 'precondition failed') In the interest of moving

Re: [PATCH 2/3] atomic-revprop: Change tests

Jon Foster wrote on Mon, Sep 20, 2010 at 10:48:44 +0100: > Hi, > > This patch changes the tests for the atomic-revprop feature, so that > they test the error number rather than parsing the error text. > This doesn't work with Serf or Neon yet - they're still TODO. This > gives you a way to test S

Re: [PATCH 1/3] atomic-revprop: Change error name

Jon Foster wrote on Mon, Sep 20, 2010 at 10:47:05 +0100: > Hi, > > I'm keen to get the atomic-revprop feature working, so I've had a > go at writing patches for some of the missing bits. > Hi, and thanks. :-) > This first patch gives a unique error code for the case where the > old_value passed

RE: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

> -Original Message- > From: Jon Foster [mailto:jon.fos...@cabot.co.uk] > Sent: maandag 20 september 2010 12:01 > To: Daniel Shahaf; Subversion Development > Subject: [PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code > > Hi, > > For atomic-revprop, the client needs to k

State of Python Bindings for Windows

Hello, I can't find any binaries for Python bindings for Windows. Previously they were available from tigris.org site, but now there aren't any updates. It will greatly reduce frustration for users of hgsubversion and other Windows tools if up to date official bindings could be available from PyPI

Re: Performance branch review: single revision changes

Stefan Fuhrmann wrote on Mon, Sep 20, 2010 at 11:52:37 +0200: > Hyrum K. Wright wrote: >> On Mon, Sep 20, 2010 at 7:47 AM, Bert Huijben wrote: >> >>> -Original Message- From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] * r982335 Limit the amount

[PATCH 3/3] atomic-revprop: Signal the error as a HTTP status code

Hi, For atomic-revprop, the client needs to know if the error was SVN_ERR_BAD_OLD_VALUE or not. For ra_local and ra_svn this is already done; this patch does it for DAV (with Neon). With mod_dav, we only have 2 ways to affect the 207 multistatus response from a failed PROPPATCH: - We can set t

Re: svn commit: r995475 - /subversion/trunk/subversion/libsvn_repos/load.c

On 15.09.2010 21:03, Stefan Sperling wrote: > On Fri, Sep 10, 2010 at 04:02:52PM +0200, Branko Čibej wrote: >> On 10.09.2010 15:26, Stefan Sperling wrote: >>> I know we're using C89, but maybe it's time to move on and upgrade to C99 >>> where the benefits are desirable? When Subversion was starte

Re: Performance branch review: single revision changes

Hyrum K. Wright wrote: On Mon, Sep 20, 2010 at 7:47 AM, Bert Huijben wrote: -Original Message- From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] Sent: zondag 19 september 2010 21:59 To: Subversion Development Subject: Performance branch review: single revision changes

Re: svn diff optimization to make blame faster?

On 15.09.2010 14:20, Johan Corveleyn wrote: > Some update on this: I have implemented this for svn_diff (excluding > the identical prefix and suffix of both files, and only then starting > to fill up the token tree and let the lcs-agorithm to its thing). It > makes a *huge* difference. On my bigfi

[PATCH 2/3] atomic-revprop: Change tests

Hi, This patch changes the tests for the atomic-revprop feature, so that they test the error number rather than parsing the error text. This doesn't work with Serf or Neon yet - they're still TODO. This gives you a way to test Serf & Neon patches. (You might like to hold off on committing this u

[PATCH 1/3] atomic-revprop: Change error name

Hi, I'm keen to get the atomic-revprop feature working, so I've had a go at writing patches for some of the missing bits. This first patch gives a unique error code for the case where the old_value passed to the revprop change function doesn't match the real old value. This allows it to be detec

Performance branch: Membuffer cache review

Hi devs, To aid the performance branch review process, I've extracted the change that probably gives the largest performance gain. The changes were grouped in a way that eliminated all possibly confusing temporary code. So, without any further ado, please review: /branches/integrate-cache-memb

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 10:35:34 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530: > > > Daniel Shahaf writes: > > > > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > > > > On Sun, Sep 1

Re: Performance branch review: single revision changes

On Mon, Sep 20, 2010 at 7:47 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] >> Sent: zondag 19 september 2010 21:59 >> To: Subversion Development >> Subject: Performance branch review: single revision changes >> >> Hi there,