Issue #3693 -- any ideas?

2010-08-19 Thread C. Michael Pilato
See http://subversion.tigris.org/issues/show_bug.cgi?id=3693 Would it make sense for a multi-target update (such as 'svn update *') to print headers for each of its targets? $ svn up projects/* Updating 'projects/ezt'. At revision 30. Updating 'projects/phidx'. At revision 47. Skipped 'projects/s

Re: [PATCH v2] New dumpstream parser to check version number

2010-08-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > That patch is still an RFC, and it's unlikely to be approved soon I > > think. If I were able to send a series, it would roughly look like > > this: > > 1. Create parse_dumpstream3 to include the logic for checking equality > >in version. > > 2. Note the la

Re: [PATCH] add 'svnadmin verify' pass to hot-backup.py.in

2010-08-19 Thread C. Michael Pilato
On 08/19/2010 04:25 PM, Leo Davis wrote: > Hello, > > I've found it useful to verify my backups using 'svnadmin verify' and > thought it would make a good addition to hot-backup.py. > > [[[ > * tools/backup/hot-backup.py.in > Added command line option "--verify". If flag is present, the > h

Re: Bug: resolve --accept theirs-conflict does not properly handle paths

2010-08-19 Thread Doug Reeder
My apologies; it was the other machine that had the up-to-date copy of Subversion, and I failed to double-check. On Aug 19, 2010, at 4:20 PM, Stefan Sperling wrote: On Thu, Aug 19, 2010 at 08:24:38PM +0100, Philip Martin wrote: Doug Reeder writes: svn, version 1.6.4 (r38063) That's old

[PATCH] add 'svnadmin verify' pass to hot-backup.py.in

2010-08-19 Thread Leo Davis
Hello, I've found it useful to verify my backups using 'svnadmin verify' and thought it would make a good addition to hot-backup.py. [[[ * tools/backup/hot-backup.py.in Added command line option "--verify". If flag is present, the hotcopy will be verified. Added a new pass between the e

Re: svn diff optimization to make blame faster?

2010-08-19 Thread Johan Corveleyn
On Thu, Aug 19, 2010 at 5:13 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Johan Corveleyn [mailto:jcor...@gmail.com] >> Sent: donderdag 19 augustus 2010 4:55 >> To: Subversion Development >> Subject: Re: svn diff optimization to make blame faster? >> > > >> >> I googled aroun

Re: svn diff optimization to make blame faster?

2010-08-19 Thread Johan Corveleyn
On Thu, Aug 19, 2010 at 1:54 PM, Johan Corveleyn wrote: > On Wed, Aug 18, 2010 at 3:44 PM, Johan Corveleyn wrote: >> FWIW, below is the output of a recent run with my instrumented trunk >> build. I've instrumented svn_diff_diff in diff.c and >> svn_diff__get_tokens in token.c. I checked out bigfi

Subversion 1.6.12 and Python 2.7

2010-08-19 Thread Barry Warsaw
Hello folks, I'm a core Python developer and an Ubuntu developer, and I'm currently working on adding Python 2.7 support to Ubuntu. I'm in the process of investigating build problems with various packages against Python 2.7. One such package is Subversion 1.6.12, which appears to build against P

Re: svn commit: r965892 - in /subversion/trunk: notes/dump-load-format.txt subversion/include/svn_repos.h subversion/libsvn_repos/dump.c

2010-08-19 Thread Stefan Sperling
On Thu, Jul 22, 2010 at 10:56:11AM -0400, C. Michael Pilato wrote: > (And I will further suggest that we fix the dump.c code to pass FALSE for > the 'force' parameter of svn_fs_file_checksum() calls, thus restoring the > pre-Hyrums-change behavior.) Picking up on this old topic: I am planning to m

Re: Bug: resolve --accept theirs-conflict does not properly handle paths

2010-08-19 Thread Stefan Sperling
On Thu, Aug 19, 2010 at 08:24:38PM +0100, Philip Martin wrote: > Doug Reeder writes: > > > svn, version 1.6.4 (r38063) > > That's old. > > >compiled Aug 7 2009, 11:08:17 > > running under OS X 10.5.8 on a Intel Core 2 Duo (i.e. a 64-bit > > processor) > > > > resolve --accept theirs-confli

Re: Bug: resolve --accept theirs-conflict does not properly handle paths

2010-08-19 Thread Philip Martin
Doug Reeder writes: > svn, version 1.6.4 (r38063) That's old. >compiled Aug 7 2009, 11:08:17 > running under OS X 10.5.8 on a Intel Core 2 Duo (i.e. a 64-bit > processor) > > resolve --accept theirs-conflict fails on a CONFLICTED-PATH with a > directory component, but works fine when CONFL

Re: svn_client_status5() and depth

2010-08-19 Thread C. Michael Pilato
On 08/19/2010 09:15 AM, Stefan Küng wrote: > What's the harm in leaving the behavior in the old APIs even though it's > not what you intended? Please read the docs for the API again - that > intention isn't documented so the old API works as documented. As someone who was close to the project when

Bug: resolve --accept theirs-conflict does not properly handle paths

2010-08-19 Thread Doug Reeder
svn, version 1.6.4 (r38063) compiled Aug 7 2009, 11:08:17 running under OS X 10.5.8 on a Intel Core 2 Duo (i.e. a 64-bit processor) resolve --accept theirs-conflict fails on a CONFLICTED-PATH with a directory component, but works fine when CONFLICTED-PATH is just a filename: ~/webOS/

Re: dev@ and users@ need more moderators?

2010-08-19 Thread Greg Stein
I normally moderate messages through quite actively, but have been remiss this week. IOW, "normally" messages shouldn't ever hang out for very long. I slacked off this week, thinking others would pick up the slack. Guess I was wrong :-P More moderators never hurts, of course. For those wondering,

Re: svnrdump: The BIG update

2010-08-19 Thread 'Daniel Shahaf'
(sorry for the delay; didn't want to reply while sleepy) Bert Huijben wrote on Tue, Aug 17, 2010 at 09:30:08 -0700: > > > > -Original Message- > > From: Ramkumar Ramachandra [mailto:artag...@gmail.com] > > Sent: dinsdag 17 augustus 2010 9:09 > > To: Daniel Shahaf > > Cc: Subversion-dev M

Re: dev@ and users@ need more moderators?

2010-08-19 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Aug 19, 2010 at 20:51:08 +0300: > @all, do we need more moderators on us...@? By the way, exactly the same people moderate dev@ and us...@. (i.e., users-owner@ and dev-owner@ both go to the same 4 people.) So I imagine that, inasmuch there is a problem, it would apply

dev@ and users@ need more moderators?

2010-08-19 Thread Daniel Shahaf
So, artagnon mailed yesterday a note to users@, CCing me. And now, 23 hours later, I notice it isn't on the list yet. Joe Schaefer from ASF Infra confirms that there are quite a few legitimate messages pending moderation on the us...@subversion.apache.org list. In other words, it seems that the

Re: [PATCH v2] New dumpstream parser to check version number

2010-08-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 21:28:37 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > > - SVN_ERR(svn_repos_parse_dumpstream2(stream, parser, parse_baton, > > > - NULL, NULL, pool)); > > > + SVN_ERR(svn_repos_parse_dumpstream3(stream,

Re: svn commit: r986510 - in /subversion/trunk/subversion: bindings/javahl/native/SVNClient.cpp include/svn_client.h libsvn_client/delete.c libsvn_client/deprecated.c libsvn_client/externals.c libsvn_

2010-08-19 Thread Stefan Küng
On 19.08.2010 19:10, Daniel Shahaf wrote: rhuij...@apache.org wrote on Tue, Aug 17, 2010 at 22:25:09 -: +++ subversion/trunk/subversion/include/svn_client.h Tue Aug 17 22:25:09 2010 @@ -2162,6 +2166,7 @@ svn_client_status5(svn_revnum_t *result_ + svn_boolean_t depth_as_stic

Re: svn commit: r986510 - in /subversion/trunk/subversion: bindings/javahl/native/SVNClient.cpp include/svn_client.h libsvn_client/delete.c libsvn_client/deprecated.c libsvn_client/externals.c libsvn_

2010-08-19 Thread Daniel Shahaf
rhuij...@apache.org wrote on Tue, Aug 17, 2010 at 22:25:09 -: > +++ subversion/trunk/subversion/include/svn_client.h Tue Aug 17 22:25:09 2010 > @@ -2162,6 +2166,7 @@ svn_client_status5(svn_revnum_t *result_ > + svn_boolean_t depth_as_sticky, s/depth_as_sticky/depth_is_sticky/

Re: svn_client_status5() and depth

2010-08-19 Thread Stefan Küng
On 18.08.2010 21:58, Bert Huijben wrote: I've checked r986510 and I like to add some comments: In libsvn_client/deprecated.c, svn_client_status4() you pass FALSE for the new sticky param. But that's wrong: in 1.6.x and previous versions, the depth was always respected/enforced. That's why I noti

Re: [PATCH v2] New dumpstream parser to check version number

2010-08-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > - SVN_ERR(svn_repos_parse_dumpstream2(stream, parser, parse_baton, > > - NULL, NULL, pool)); > > + SVN_ERR(svn_repos_parse_dumpstream3(stream, parser, parse_baton, > > + NULL, NULL, > >

Re: svn commit: r986865 - /subversion/trunk/notes/wc-ng/node-data

2010-08-19 Thread Philip Martin
"Bert Huijben" writes: > How would this handle deleted nodes in one layer (then some overlays) and > then calling _read_children(). I think that would become a union/select over > multiple layers? We already had some performance issues there in the past > and I hope this only makes this query eas

RE: svn diff optimization to make blame faster?

2010-08-19 Thread Bert Huijben
> -Original Message- > From: Johan Corveleyn [mailto:jcor...@gmail.com] > Sent: donderdag 19 augustus 2010 4:55 > To: Subversion Development > Subject: Re: svn diff optimization to make blame faster? > > > I googled around a bit for C profilers on Windows. I found several > which seem

RE: svn commit: r986865 - /subversion/trunk/notes/wc-ng/node-data

2010-08-19 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: donderdag 19 augustus 2010 3:39 > To: Greg Stein > Cc: Bert Huijben; dev@subversion.apache.org; phi...@apache.org > Subject: Re: svn commit: r986865 - /subversion/trunk/notes/wc-ng/node- > data > > Gre

Re: svn diff optimization to make blame faster?

2010-08-19 Thread Johan Corveleyn
On Wed, Aug 18, 2010 at 3:44 PM, Johan Corveleyn wrote: > On Wed, Aug 18, 2010 at 12:49 PM, Stefan Sperling wrote: >> Can you show a profiler run that illustrates where the client is >> spending most of its time during diff? That would probably help with >> getting opinions from people, because i

Re: svn commit: r986865 - /subversion/trunk/notes/wc-ng/node-data

2010-08-19 Thread Philip Martin
Greg Stein writes: > But that said, there is an argument for combining all three conceptual > tables into one. Is that was you guys were suggesting? Yes. The tables are so similar. For example, base_node's repos_id/repos_relpath/revnum and the working_node's copyfrom_id/copyfrom_relpath/copyfr

Re: [RFC/PATCH] Create a fresh svn_repos_parse_fns3_t

2010-08-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:12:14 +0530: > Hi, > > I sent a patch a while ago for svn_repos_parse_dumpstream3. While I > wait for approval, this is an RFC patch describing my future plan once > that patch gets approved. It can be described tersely as "While at it > (addin

Re: [PATCH v2] New dumpstream parser to check version number

2010-08-19 Thread Daniel Shahaf
(read the last review hunk first) Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:17:55 +0530: > [[[ > * subversion/libsvn_repos/load.c > (svn_repos_parse_dumpstream2, svn_repos_parse_dumpstream3): Rename > the older function and add a version_number argument; error out if > there's a

Re: [PATCH] New dumpstream parser to check version number

2010-08-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 02:38:25 +0530: > Daniel Shahaf wrote: > > svnrdump needs an inequality check here. But 'svnadmin load', for > > example, needs an "is at most" check. So I don't think this is generic > > enough: it would be better to provide something that 'svna