"subversion/libsvn_client/status.c:409: 'replaced' may be used
uninitialized in this function"
- Julian
On Fri, 2010-04-23, cmpil...@apache.org wrote:
[...]
> + if (added)
> +{
> + svn_boolean_t replaced;
> +
> + SVN_ERR(svn_wc__node_is_replaced(&ad
On Fri, Apr 23, 2010 at 4:24 PM, Stefan Sperling wrote:
> ...
>
> We should also consider changing the way "^/" is interpreted.
> Maybe only commands that expect URLs as arguments should expand "^/"
> to a URL? That way the above error would become:
>
> $ svn add ^/
> svn: warning: '/path/to/work
On Fri, Apr 23, 2010 at 12:46:44PM -0400, C. Michael Pilato wrote:
> As I noted, the check needs to happen inside the client API. The question
> becomes "Do we patch svn_client_addX() and svn_client_statusX() and
> svn_client_updateX() and ..." or is there a more general fix to be made
> (like per
> -Original Message-
> From: dan...@apache.org [mailto:dan...@apache.org]
> Sent: vrijdag 23 april 2010 21:12
> To: comm...@subversion.apache.org
> Subject: svn commit: r937475 -
> /subversion/trunk/subversion/libsvn_wc/util.c
>
> Author: dannas
> Date: Fri Apr 23 19:11:34 2010
> New Rev
Greg Stein writes:
> Is this conversion still going to work, noting the earlier discussion
> about children having entry->copyfrom_url == NULL, yet the node
> function returns non-NULL for all copied children?
I could not see why the code would care whether this was the root of
the copy or not.
On Fri, Apr 23, 2010 at 11:01, Daniel Näslund wrote:
> On Fri, Apr 23, 2010 at 06:23:49AM -0400, Greg Stein wrote:
>> On Fri, Apr 23, 2010 at 05:38, Daniel Näslund wrote:
>> > I wanted to keep the current behaviour since the status code is involved
>> > in so _many_ tests and rewriting all of tho
On Fri, Apr 23, 2010 at 09:25, Stefan Sperling wrote:
> On Fri, Apr 23, 2010 at 01:04:37PM -, gst...@apache.org wrote:
>> Author: gstein
>> Date: Fri Apr 23 13:04:37 2010
>> New Revision: 937276
>
>> This breaks schedule_tests 7, to be fixed in a larger and distinct
>> semantic change/revision
On Fri, Apr 23, 2010 at 13:28, wrote:
>...
> +++ subversion/trunk/subversion/libsvn_client/copy.c Fri Apr 23 17:28:02 2010
> @@ -2037,33 +2037,37 @@ try_copy(svn_commit_info_t **commit_info
>
> for (i = 0; i < copy_pairs->nelts; i++)
> {
> - const ch
Greg Stein wrote:
> On Fri, Apr 23, 2010 at 11:58, C. Michael Pilato wrote:
>> Uwe Stuehler wrote:
>>> [[[
>>> Fix issue #3620: svn add ^/ triggers assertion failure
>>>
>>> * subversion/svn/add-cmd.c:
>>> (svn_cl__add): Raise an error if a target argument isn't a working
>>> copy path before
On Fri, Apr 23, 2010 at 11:58, C. Michael Pilato wrote:
> Uwe Stuehler wrote:
>> [[[
>> Fix issue #3620: svn add ^/ triggers assertion failure
>>
>> * subversion/svn/add-cmd.c:
>> (svn_cl__add): Raise an error if a target argument isn't a working
>> copy path before calling svn_client_add4(),
Uwe Stuehler wrote:
> [[[
> Fix issue #3620: svn add ^/ triggers assertion failure
>
> * subversion/svn/add-cmd.c:
> (svn_cl__add): Raise an error if a target argument isn't a working
> copy path before calling svn_client_add4(), which would trigger an
> assertion.
>
> Found by: stsp
> Patc
On Fri, Apr 23, 2010 at 06:23:49AM -0400, Greg Stein wrote:
> On Fri, Apr 23, 2010 at 05:38, Daniel Näslund wrote:
> > I wanted to keep the current behaviour since the status code is involved
> > in so _many_ tests and rewriting all of those would cause me to loose
> > momentum. Guess, what? I've
On Wed, 2010-04-21, Julian Foad wrote:
> Greg Stein wrote:
> > On Wed, Apr 21, 2010 at 05:09, Philip Martin
> > wrote:
> > > Julian Foad writes:
> > >
> > >> COMPATIBILITY
> > >> =
> > >>
> > >> We need to keep the old WC interface working:
> > >>
> > >> svn_wc_transmit_text_deltas
On Fri, Apr 23, 2010 at 01:01:24PM -, s...@apache.org wrote:
> Author: stsp
> Date: Fri Apr 23 13:01:23 2010
> New Revision: 937275
>
> URL: http://svn.apache.org/viewvc?rev=937275&view=rev
> Log:
> Pool usage fixes in the translation stream.
>
> Do not maintain a private pool for each transl
On Fri, Apr 23, 2010 at 4:14 AM, Bert Huijben wrote:
>> -Original Message-
>> From: pbu...@apache.org [mailto:pbu...@apache.org]
>> Sent: donderdag 22 april 2010 21:40
>> To: comm...@subversion.apache.org
>> Subject: svn commit: r937033 -
>> /subversion/trunk/subversion/libsvn_repos/dump.c
On Fri, Apr 23, 2010 at 01:04:37PM -, gst...@apache.org wrote:
> Author: gstein
> Date: Fri Apr 23 13:04:37 2010
> New Revision: 937276
> This breaks schedule_tests 7, to be fixed in a larger and distinct
> semantic change/revision.
Why not mark it XFAIL in the meantime?
Stefan
On Thu, Mar 11, 2010 at 00:15, Greg Stein wrote:
>...
>>> I want both the base and the working presence, the base presence comes
>>> from base_get_info but I couldn't see how to reliably distinguish
>>> working presence from base presence when using _read_info. I get
>>> SVN_ERR_WC_PATH_NOT_FOUND
On 23.04.2010 00:06, Hyrum K. Wright wrote:
> With the increased integration of build tools and other notification
> systems which desire knowledge of commit activity, it would be useful
> to provide an easier mechanism of installing post-commit notification,
> without having to use the hook inf
Greg Stein wrote on Fri, 23 Apr 2010 at 07:17 -0400:
> And I'll go one further: also provide a (sample) CGI script to
> *accept* those POST requests, and "do something". At the ASF, our
> website is updated after a commit. The code that does that today is
> apparently a little flaky, so having an o
On Fri, Apr 23, 2010 at 07:07, Stefan Küng wrote:
>...
>>> On 23.04.2010 00:06, Hyrum K. Wright wrote:
With the increased integration of build tools and other notification
systems
which desire knowledge of commit activity, it would be useful to provide
an
easier mecha
Greg Stein writes:
>> I understand all that. My question is in the (few) cases where we
>> don't have an URL will we have a copyfrom URL. It seems unlikely to
>> me.
>
> I will state, "in any potential case where a URL is not available...
> NO, we will not have a copyfrom."
OK. The other plac
On 23.04.2010 13:00, Greg Stein wrote:
On Fri, Apr 23, 2010 at 06:53, Stefan Küng wrote:
On 23.04.2010 00:06, Hyrum K. Wright wrote:
With the increased integration of build tools and other notification
systems
which desire knowledge of commit activity, it would be useful to provide
an
easier
On Fri, Apr 23, 2010 at 06:53, Stefan Küng wrote:
> On 23.04.2010 00:06, Hyrum K. Wright wrote:
>>
>> With the increased integration of build tools and other notification
>> systems
>> which desire knowledge of commit activity, it would be useful to provide
>> an
>> easier mechanism of installing
On Fri, Apr 23, 2010 at 06:56, Philip Martin wrote:
> Greg Stein writes:
>
>>> Are there any circumstances today when a node will not have an URL but
>>> will have a copyfrom URL? Everything seems to work if I remove the
>>> copyfrom stuf from convert_to_url.
>>
>> entry->url "does not exist"...
Greg Stein writes:
>> Are there any circumstances today when a node will not have an URL but
>> will have a copyfrom URL? Everything seems to work if I remove the
>> copyfrom stuf from convert_to_url.
>
> entry->url "does not exist"... today, we call a function to provide a
> URL. That means we
On Fri, Apr 23, 2010 at 06:48, Philip Martin wrote:
> gst...@apache.org writes:
>
>> Author: gstein
>> Date: Fri Apr 23 01:39:05 2010
>> New Revision: 937128
>>
>> URL: http://svn.apache.org/viewvc?rev=937128&view=rev
>> Log:
>> Change some basics around the svn_wc__merge_props before digging in f
On 23.04.2010 00:06, Hyrum K. Wright wrote:
With the increased integration of build tools and other notification systems
which desire knowledge of commit activity, it would be useful to provide an
easier mechanism of installing post-commit notification, without having to
use the hook infrastructu
On 23.04.2010 11:45, Bert Huijben wrote:
>> -Original Message-
>> From: Greg Stein [mailto:gst...@gmail.com]
>> Sent: vrijdag 23 april 2010 0:57
>> To: Hyrum K. Wright
>> Cc: Subversion Development
>> Subject: Re: Feature idea: user-configurable post-commit notifications
>>
>> Write a hook
gst...@apache.org writes:
> Author: gstein
> Date: Fri Apr 23 01:39:05 2010
> New Revision: 937128
>
> URL: http://svn.apache.org/viewvc?rev=937128&view=rev
> Log:
> Change some basics around the svn_wc__merge_props before digging in for
> some further work.
>
> Note: this restricts svn_wc_merge_p
On Fri, Apr 23, 2010 at 06:37, Philip Martin wrote:
> Greg Stein writes:
>
>> Specifically: in the particular case that *you* created the function
>> for, the copyfrom-fetching would most likely *never* be invoked.
>> node_get_url() should return a URL in almost every situation.
>
> The copyfrom
Greg Stein writes:
> Specifically: in the particular case that *you* created the function
> for, the copyfrom-fetching would most likely *never* be invoked.
> node_get_url() should return a URL in almost every situation.
The copyfrom stuff in libsvn_client/diff.c:convert_to_url dates to
pre-1.0
On Fri, Apr 23, 2010 at 05:38, Daniel Näslund wrote:
>...
> I set out to replace the entry field in svn_wc_statusX_t. I thought that
> ideally I could just keep the semantics from the entry but move out the
> fields to svn_wc_status2_t.
Yikes.
I would say, "if callers want entry_t semantics, the
> -Original Message-
> From: Greg Stein [mailto:gst...@gmail.com]
> Sent: vrijdag 23 april 2010 0:57
> To: Hyrum K. Wright
> Cc: Subversion Development
> Subject: Re: Feature idea: user-configurable post-commit notifications
>
> Write a hook script to do exactly that, and make it part of t
On Thu, Apr 22, 2010 at 05:07:56PM -0400, Greg Stein wrote:
> On Thu, Apr 22, 2010 at 15:48, Daniel Näslund wrote:
>
> >> read_info() returns changed_* information for copied nodes. A copied
> >> node has a corresponding node in the repository, and the changed_*
> >> information reflects that. (t
> -Original Message-
> From: pbu...@apache.org [mailto:pbu...@apache.org]
> Sent: donderdag 22 april 2010 21:40
> To: comm...@subversion.apache.org
> Subject: svn commit: r937033 -
> /subversion/trunk/subversion/libsvn_repos/dump.c
>
> Author: pburba
> Date: Thu Apr 22 19:40:07 2010
> New
35 matches
Mail list logo
