Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

2010-04-22 Thread C. Michael Pilato
Scratch that -- Philip already made that change. C. Michael Pilato wrote: > Greg Stein wrote: >> Yes, you hit the nail on the head. I had a similar concern, but wasn't >> sure whether to bring it up. >> >> Specifically: in the particular case that *you* created the function >> for, the copyfrom-fe

Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

2010-04-22 Thread C. Michael Pilato
Greg Stein wrote: > Yes, you hit the nail on the head. I had a similar concern, but wasn't > sure whether to bring it up. > > Specifically: in the particular case that *you* created the function > for, the copyfrom-fetching would most likely *never* be invoked. > node_get_url() should return a URL

Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

2010-04-22 Thread Greg Stein
Yes, you hit the nail on the head. I had a similar concern, but wasn't sure whether to bring it up. Specifically: in the particular case that *you* created the function for, the copyfrom-fetching would most likely *never* be invoked. node_get_url() should return a URL in almost every situation. In

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

2010-04-22 Thread C. Michael Pilato
Uwe Stuehler wrote: > [[[ > Fix issue #3620: svn add ^/ triggers assertion failure > > * subversion/svn/add-cmd.c: > (svn_cl__add): Raise an error if a target argument isn't a working > copy path before calling svn_client_add4(), which would trigger an > assertion. > > Found by: stsp > Patc

Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

2010-04-22 Thread C. Michael Pilato
I *think* there's a bigger problem with this change. When I created svn_wc__node_get_copyfrom_info(), I specifically wanted the behavior that svn_wc_entry_t promised with respect to copyfrom information, which is that it was set on the targets of a copy operation but *not* on the children of that

Re: svn commit: r937098 - /subversion/trunk/subversion/libsvn_subr/subst.c

2010-04-22 Thread Greg Stein
Cool! Much better. On Thu, Apr 22, 2010 at 19:11, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/subst.c Thu Apr 22 23:11:48 2010 >... > +  mt->saved_baton.in_baton = dup_translation_baton(b->in_baton, pool); > +  mt->saved_baton.out_baton = dup_translation_baton(b->out_baton, pool)

[PATCH] issue #3620: svn add ^/ triggers assertion failure

2010-04-22 Thread Uwe Stuehler
[[[ Fix issue #3620: svn add ^/ triggers assertion failure * subversion/svn/add-cmd.c: (svn_cl__add): Raise an error if a target argument isn't a working copy path before calling svn_client_add4(), which would trigger an assertion. Found by: stsp Patch by: Uwe Stuehler (subversion-li...@bsd

Re: Feature idea: user-configurable post-commit notifications

2010-04-22 Thread Greg Stein
Write a hook script to do exactly that, and make it part of the standard release. In some future release, after that script and its features stabilize, *then* we can consider placing into into the core code. I fear the security aspects of something like you talk about: anybody with commit access

Feature idea: user-configurable post-commit notifications

2010-04-22 Thread Hyrum K. Wright
With the increased integration of build tools and other notification systems which desire knowledge of commit activity, it would be useful to provide an easier mechanism of installing post-commit notification, without having to use the hook infrastructure. Imagine a user being able to set up commi

Re: svn commit: r937033 - /subversion/trunk/subversion/libsvn_repos/dump.c

2010-04-22 Thread Greg Stein
On Thu, Apr 22, 2010 at 15:40, wrote: >... > +++ subversion/trunk/subversion/libsvn_repos/dump.c Thu Apr 22 19:40:07 2010 >... > @@ -1109,6 +1114,23 @@ svn_repos_dump_fs3(svn_repos_t *repos, >     loop_end: >       if (progress_func) >         SVN_ERR(progress_func(progress_baton, to_rev, NULL, s

Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

2010-04-22 Thread Greg Stein
On Thu, Apr 22, 2010 at 14:59, wrote: >... > +++ subversion/trunk/subversion/libsvn_client/diff.c Thu Apr 22 18:59:01 2010 > @@ -894,6 +894,11 @@ convert_to_url(const char **url, >       SVN_ERR(svn_wc__node_get_copyfrom_info(url, ©from_rev, >                                              wc_ctx,

Re: [PATCH] Don't use entries for checking status in svn_wc_status3_t. Was: Re: [WIP] Some quirky parts of libsvn_wc/status.c:assemble_status() for retrieving revisions

2010-04-22 Thread Greg Stein
On Thu, Apr 22, 2010 at 15:48, Daniel Näslund wrote: > On Thu, Apr 22, 2010 at 02:45:08PM -0400, Greg Stein wrote: >> On Thu, Apr 22, 2010 at 10:05, Daniel Näslund wrote: >... >> > * subversion/tests/cmdline/stat_tests.py >> >  (status_with_tree_conflicts): An copied node should not have a >> >  

Re: [RFC] Proposal for GSoC project - extend 'svn {patch,diff}' with git unidiff format

2010-04-22 Thread Daniel Näslund
On Mon, Apr 05, 2010 at 01:41:03PM +0200, Stefan Sperling wrote: > On Mon, Apr 05, 2010 at 10:02:56AM +0200, Daniel Näslund wrote: > > Git unidiff format extension to 'svn patch' and 'svn diff' > > === [..] > > 2) Add the ability to track r

Re: [PATCH] Don't use entries for checking status in svn_wc_status3_t. Was: Re: [WIP] Some quirky parts of libsvn_wc/status.c:assemble_status() for retrieving revisions

2010-04-22 Thread Daniel Näslund
On Thu, Apr 22, 2010 at 02:45:08PM -0400, Greg Stein wrote: > On Thu, Apr 22, 2010 at 10:05, Daniel Näslund wrote: > > [[[ > > As part of WC-NG, replace entry calls for revisions from > > svn_wc_status2_t related code. > > > > The entries code set the revision of newly added nodes to 0 but the db

Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

2010-04-22 Thread C. Michael Pilato
phi...@apache.org wrote: > Author: philip > Date: Thu Apr 22 18:59:01 2010 > New Revision: 937010 > > URL: http://svn.apache.org/viewvc?rev=937010&view=rev > Log: > Move some code. > > * subversion/libsvn_wc/copy.c > (determine_copyfrom_info): Delete. > (copy_file_administratively, copy_dir_a

Re: [PATCH] Don't use entries for checking status in svn_wc_status3_t. Was: Re: [WIP] Some quirky parts of libsvn_wc/status.c:assemble_status() for retrieving revisions

2010-04-22 Thread Greg Stein
On Thu, Apr 22, 2010 at 10:05, Daniel Näslund wrote: > Hi! > > [[[ > As part of WC-NG, replace entry calls for revisions from > svn_wc_status2_t related code. > > The entries code set the revision of newly added nodes to 0 but the db > sets them to -1. Since too many tests needs to be changed and

Re: svn commit: r936844 - in /subversion/trunk/subversion: libsvn_subr/subst.c tests/libsvn_subr/stream-test.c

2010-04-22 Thread Greg Stein
On Thu, Apr 22, 2010 at 09:49, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/subst.c Thu Apr 22 13:49:14 2010 >... > @@ -1164,13 +1201,40 @@ translated_stream_reset(void *baton) >   return svn_error_return(err); >  } > > +/* svn_stream_mark_t for translation streams. */ > +typedef str

Re: svn commit: r936802 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-04-22 Thread Greg Stein
On Thu, Apr 22, 2010 at 08:03, wrote: > Author: stsp > Date: Thu Apr 22 12:03:40 2010 > New Revision: 936802 > > URL: http://svn.apache.org/viewvc?rev=936802&view=rev > Log: > * subversion/tests/svn_test_main.c >  (main): Override the default malfunction handler to avoid abort() >   in the C test

Re: svn commit: r936240 - /subversion/trunk/subversion/libsvn_wc/entries.c

2010-04-22 Thread Greg Stein
On Wed, Apr 21, 2010 at 10:32, Greg Stein wrote: > On Wed, Apr 21, 2010 at 07:22, Philip Martin > wrote: >> Philip Martin writes: >> >>> Greg Stein writes: >>> With this change, our code no longer reads "all entries", nor does it attempt to cache that hash of entries. The o

svn log -g performance for large commits

2010-04-22 Thread Becker, Thomas
This is from an email conversation with C. Michael Pilato about the performance degradation of 'svn log -g' involving revisions with plenty of changed paths. BTW: as a workaround would it help to split a large commit into several smaller ones so that mergeinfo examination can be skipped for revisi

[PATCH] Don't use entries for checking status in svn_wc_status3_t. Was: Re: [WIP] Some quirky parts of libsvn_wc/status.c:assemble_status() for retrieving revisions

2010-04-22 Thread Daniel Näslund
Hi! [[[ As part of WC-NG, replace entry calls for revisions from svn_wc_status2_t related code. The entries code set the revision of newly added nodes to 0 but the db sets them to -1. Since too many tests needs to be changed and 'svn info' also uses 0, I'll change those values in a follow-up patc