On Wed, Apr 21, 2010 at 10:32, Greg Stein <gst...@gmail.com> wrote: > On Wed, Apr 21, 2010 at 07:22, Philip Martin <philip.mar...@wandisco.com> > wrote: >> Philip Martin <philip.mar...@wandisco.com> writes: >> >>> Greg Stein <gst...@gmail.com> writes: >>> >>>> With this change, our code no longer reads "all entries", nor does it >>>> attempt to cache that hash of entries. >>>> >>>> The only way to do so, is with svn_wc_entries_read(), >>>> svn_wc_walk_entries3(), or svn_wc_entry(). All three are deprecated >>>> and not used by trunk. >>>> >>>> Not seeing much of a performance gain, though. (I suspect SQLite >>>> caching was helping us before) >>>> >>>> Cheers, >>>> -g >>>> >>>> ps. this breaks special_tests 12 and stat_tests 5. I'll fix after sleep... >>> >>> A lot more than that here, e.g. basic_tests 1, 2, 3, 4, 5, 6, 7, 8, 9, >>> 10, 11, 12, 13, 14, 15, 16, 17, 23, 31, 32, 35, 38, 40 and 48 all >>> fail. A typical failure is: >> >> This might be because 'svn status -u' now fails on the root of a >> working copy: >> >> $ subversion/svn/svn co file://`pwd`/repo1 wc1 >> Checked out revision 0. >> $ subversion/svn/svn st -u wc1 >> svn: warning: '/home/pm/sw/subversion/obj' is not a working copy >> >> but works if the working copy is inside another 1.7 working copy: >> >> $ subversion/svn/svn co file://`pwd`/repo1 wc1/wc2 >> Checked out revision 0. >> $ subversion/svn/svn st -u wc1/wc2 >> S 0 wc1/wc2 >> Status against revision: 0 >> >> Greg, are you building and running your tests within a 1.7 source >> tree? > > You bet. "svn" is trunk, baby!! :-P > > Let me dig into this... >
There were a couple things, but it looks like r936970 fixed the last of the issues. Cheers, -g