Re: svn_wc__db_base_get_info() vs. svn_wc__db_read_info() ?

2010-01-27 Thread Greg Stein
On Wed, Jan 27, 2010 at 16:51, Neels J Hofmeyr wrote: > Greg Stein wrote: >... >> and recall that BASE == what you checked out from the repository. >> WORKING corresponds to added/removed/copied/moved nodes. For nodes in > > Yes, I learnt this from Bert last week, and also that the current *...@ba

Re: svn_wc__db_base_get_info() vs. svn_wc__db_read_info() ?

2010-01-27 Thread Greg Stein
On Wed, Jan 27, 2010 at 18:15, Neels J Hofmeyr wrote: > > Neels J Hofmeyr wrote: >> So when read_info returns a non-"empty" revision, repos_relpath or root_url, >> then these values have definitely come from the BASE tree? > > I see in the code that that's not the case. > So the two calls are only

Re: http://svn.collab.net/repos/svn dead.

2010-01-27 Thread C. Michael Pilato
Daniel Shahaf wrote: > The repository on , and its viewvc > instance, seem to be gone. (The other repositories there are still > alive.) > > We have many links to update now... Call off the fire engines. Links to resources in that repository should hit my cust

Re: [PATCH] #3460 -v2

2010-01-27 Thread Julian Foad
Daniel Näslund wrote: > Removed some debug statements. > > On Wed, Jan 27, 2010 at 08:59:02PM +0100, Daniel Näslund wrote: > [[[ > Fix #3460 - svn patch is not fuzzy when applying unidiffs. > [...] Hi Daniel. Just one quick kind of comment from me: can you make sure all the functions have doc st

Re: svn commit: r903896 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-01-27 Thread Daniel Shahaf
danie...@apache.org wrote on Wed, 27 Jan 2010 at 22:58 -: > Author: danielsh > Date: Wed Jan 27 22:58:11 2010 > New Revision: 903896 > > URL: http://svn.apache.org/viewvc?rev=903896&view=rev > Log: > Fix packing of format-4 FSFS repositories. > > * subversion/libsvn_fs_fs/fs_fs.c > (pack_bo

http://svn.collab.net/repos/svn dead.

2010-01-27 Thread Daniel Shahaf
The repository on , and its viewvc instance, seem to be gone. (The other repositories there are still alive.) We have many links to update now... Daniel

Re: svn commit: r903735 - in /subversion/trunk/subversion: libsvn_client/copy.c libsvn_wc/wc_db.c

2010-01-27 Thread Philip Martin
"Bert Huijben" writes: >> * subversion/libsvn_wc/wc_db.c >> (kind_map): Add "none". > > Why did you add a 'none' value? > > svn_wc__db_kind_t doesn't have a none value, and the database schema > doesn't allow a none value? The code allows the value "none" to get into the database. The path is

Re: svn_wc__db_base_get_info() vs. svn_wc__db_read_info() ?

2010-01-27 Thread Neels J Hofmeyr
Neels J Hofmeyr wrote: > So when read_info returns a non-"empty" revision, repos_relpath or root_url, > then these values have definitely come from the BASE tree? I see in the code that that's not the case. So the two calls are only identical when there is no WORKING node for that path. nm / sor

RE: svn commit: r903735 - in /subversion/trunk/subversion: libsvn_client/copy.c libsvn_wc/wc_db.c

2010-01-27 Thread Bert Huijben
> -Original Message- > From: phi...@apache.org [mailto:phi...@apache.org] > Sent: woensdag 27 januari 2010 17:54 > To: comm...@subversion.apache.org > Subject: svn commit: r903735 - in /subversion/trunk/subversion: > libsvn_client/copy.c libsvn_wc/wc_db.c > > Author: philip > Date: Wed J

Re: JavaHL package name? (was: Discussion: graduating Subversion)

2010-01-27 Thread Hyrum K. Wright
On Jan 26, 2010, at 2:08 PM, Martin Furter wrote: > > > On Mon, 25 Jan 2010, Justin Erenkrantz wrote: > >> My take is deprecate the old package names (org.tigris.*), add the new >> package name (org.apache.subversion.*), and remove the deprecated >> names whenever we go to 2.0. >> >> I'm mode

Re: svn_wc__db_base_get_info() vs. svn_wc__db_read_info() ?

2010-01-27 Thread Neels J Hofmeyr
Greg Stein wrote: > base_get_info returns information about the BASE tree. > > read_info returns information about the WORKING tree, or if a > specified node is not present in WORKING, then info from the BASE > tree. Nice, thanks for the clear info. > and recall that BASE == what you checked out

[PATCH] conflict notifications hunks has wrong modified_length

2010-01-27 Thread Daniel Näslund
Hi! [[[ Fix wrong modified_length for hunk notifications. * subversion/libsvn_client/patch.c (maybe_send_patch_notification): See above. Patch by: Daniel Näslund ]]] Index: subversion/libsvn_client/patch.c === --- subversion/libs

Re: JavaHL package name? (was: Discussion: graduating Subversion)

2010-01-27 Thread Роман Донченко
Greg Stein писал в своём письме Tue, 26 Jan 2010 01:32:29 +0300: See below... -- Forwarded message -- From: Greg Stein Date: Mon, Jan 25, 2010 at 17:32 Subject: Re: Discussion: graduating Subversion To: gene...@incubator.apache.org On Mon, Jan 25, 2010 at 17:21, Craig L R

[PATCH] #3460 -v2

2010-01-27 Thread Daniel Näslund
Removed some debug statements. On Wed, Jan 27, 2010 at 08:59:02PM +0100, Daniel Näslund wrote: > Hi! > [[[ Fix #3460 - svn patch is not fuzzy when applying unidiffs. * subversion/include/private/svn_diff_private.h (svn_hunk_t): Add fields context_before and context_before. They are used fo

Re: JavaHL package name? (was: Discussion: graduating Subversion)

2010-01-27 Thread C. Michael Pilato
Martin Furter wrote: > > > On Mon, 25 Jan 2010, Justin Erenkrantz wrote: > >> My take is deprecate the old package names (org.tigris.*), add the new >> package name (org.apache.subversion.*), and remove the deprecated >> names whenever we go to 2.0. >> >> I'm moderately ambivalent on whether thi

[PATCH] #3460 svn patch is not fuzzy when applying unidiffs

2010-01-27 Thread Daniel Näslund
Hi! [[[ Fix #3460 - svn patch is not fuzzy when applying unidiffs. * subversion/include/private/svn_diff_private.h (svn_hunk_t): Add fields context_before and context_before. They are used for determining if there is enough context to apply a patch with fuzz. * subversion/libsvn_diff/p

Re: svn commit: r903153 - /subversion/trunk/subversion/libsvn_ra_neon/util.c

2010-01-27 Thread Ivan Zhakov
On Tue, Jan 26, 2010 at 3:23 PM, Greg Stein wrote: > On Tue, Jan 26, 2010 at 07:13, Ivan Zhakov wrote: >> On Tue, Jan 26, 2010 at 3:01 PM, Greg Stein wrote: >>> On Tue, Jan 26, 2010 at 06:59, Ivan Zhakov wrote: On Tue, Jan 26, 2010 at 2:41 PM, Greg Stein wrote: > On Tue, Jan 26, 2010

Re: svn commit: r903507 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

2010-01-27 Thread Hyrum K. Wright
On Jan 27, 2010, at 12:22 AM, Stefan Sperling wrote: > On Tue, Jan 26, 2010 at 05:11:46PM -0800, Hyrum K. Wright wrote: >> >> On Jan 26, 2010, at 4:04 PM, ne...@apache.org wrote: >> >>> Author: neels >>> Date: Wed Jan 27 00:04:16 2010 >>> New Revision: 903507 >>> >>> URL: http://svn.apache.org

Re: Multiple matching lines in authz file

2010-01-27 Thread Mark Cammidge
Stefan Sperling wrote: >> Does anybody object if I create an issue in the documentation issue >> tracker? I'll create a patch to the English documentation to go with >> the issue. > > Please go ahead and file an issue. http://code.google.com/p/svnbook/issues/detail?id=71 Disclaimer: http://ww

Re: svn commit: r902303 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_wc/lock.c

2010-01-27 Thread Stefan Sperling
On Wed, Jan 27, 2010 at 10:35:55AM +, Philip Martin wrote: > Stefan Sperling writes: > > Can we apply your patch to fix the ordering problem? > > I think we should apply it, but the patch tests fail. I will take a look. > It raises the question: why are the patch tests taking a lock? They

Re: svn commit: r902303 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_wc/lock.c

2010-01-27 Thread Philip Martin
Stefan Sperling writes: >> --- subversion/libsvn_wc/lock.c (revision 903527) >> +++ subversion/libsvn_wc/lock.c (working copy) >> @@ -1857,9 +1857,10 @@ >> apr_pool_t *result_pool, >> apr_pool_t *scratch_pool) >> { >> + svn_e

Re: svn commit: r902303 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_wc/lock.c

2010-01-27 Thread Stefan Sperling
On Wed, Jan 27, 2010 at 02:39:05AM +, Philip Martin wrote: > s...@apache.org writes: > > > Author: stsp > > Date: Fri Jan 22 22:50:42 2010 > > New Revision: 902303 > > > +svn_error_t * > > +svn_wc__call_with_write_lock(svn_wc__with_write_lock_func_t func, > > + voi

Re: svn commit: r903507 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

2010-01-27 Thread Stefan Sperling
On Tue, Jan 26, 2010 at 05:11:46PM -0800, Hyrum K. Wright wrote: > > On Jan 26, 2010, at 4:04 PM, ne...@apache.org wrote: > > > Author: neels > > Date: Wed Jan 27 00:04:16 2010 > > New Revision: 903507 > > > > URL: http://svn.apache.org/viewvc?rev=903507&view=rev > > Log: > > * tools/dev/unix-bu