[PR] #1448 url encoding with lower case letters [incubator-stormcrawler]

2025-01-27 Thread via GitHub
mstrewe opened a new pull request, #1456: URL: https://github.com/apache/incubator-stormcrawler/pull/1456 Will fix #1448 the lower case url encoding error. Test added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] BasicUrlNomalizer Double Encoding of % when code is written in smaller letters [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on issue #1448: URL: https://github.com/apache/incubator-stormcrawler/issues/1448#issuecomment-2615424969 Thanks for the report. Do you want to provide a PR with test for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] asynchronous queries and updates in SOLR? [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on issue #621: URL: https://github.com/apache/incubator-stormcrawler/issues/621#issuecomment-2615436094 @mvolikas I am not a SOLR user but sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Add "Task" to the ISSUE_TEMPLATE.md [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on issue #1411: URL: https://github.com/apache/incubator-stormcrawler/issues/1411#issuecomment-2615430687 Sounds good. Feel free @tballison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump storm-client.version from 2.7.1 to 2.8.0 [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on PR #1453: URL: https://github.com/apache/incubator-stormcrawler/pull/1453#issuecomment-2615434047 Storm 2.8.0 will require a JDK 17 baseline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Bump com.github.ben-manes.caffeine:caffeine from 3.1.8 to 3.2.0 [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 merged PR #1450: URL: https://github.com/apache/incubator-stormcrawler/pull/1450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@st

[PR] Regenerated License file after dependency upgrades [incubator-stormcrawler]

2025-01-27 Thread via GitHub
github-actions[bot] opened a new pull request, #1455: URL: https://github.com/apache/incubator-stormcrawler/pull/1455 Found some uncommited changes (from license regeneration) after running build on StormCrawler main -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Bump org.jetbrains:annotations from 26.0.1 to 26.0.2 [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 merged PR #1454: URL: https://github.com/apache/incubator-stormcrawler/pull/1454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@st

Re: [I] asynchronous queries and updates in SOLR? [incubator-stormcrawler]

2025-01-27 Thread via GitHub
jnioche commented on issue #621: URL: https://github.com/apache/incubator-stormcrawler/issues/621#issuecomment-2615603049 Same, go for what you think is best On Mon, 27 Jan 2025, 10:57 Richard Zowalla, ***@***.***> wrote: > @mvolikas I am not a

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2025-01-27 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user mstrewe (triggered by rzo1). Head commit for run: e36a0385c1c9bf6da3f1c56aba22ad56ddb63141 / Maik Piel Update BasicURLNormalizerTest.java: forgot to change to example.com Report U

Re: [PR] #1448 url encoding with lower case letters [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on code in PR #1456: URL: https://github.com/apache/incubator-stormcrawler/pull/1456#discussion_r1931052585 ## core/src/main/java/org/apache/stormcrawler/filtering/basic/BasicURLNormalizer.java: ## @@ -145,7 +145,7 @@ public class BasicURLNormalizer extends URLFi

Re: [PR] #1448 url encoding with lower case letters [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on code in PR #1456: URL: https://github.com/apache/incubator-stormcrawler/pull/1456#discussion_r1931052585 ## core/src/main/java/org/apache/stormcrawler/filtering/basic/BasicURLNormalizer.java: ## @@ -145,7 +145,7 @@ public class BasicURLNormalizer extends URLFi

Re: [PR] #1448 url encoding with lower case letters [incubator-stormcrawler]

2025-01-27 Thread via GitHub
rzo1 commented on PR #1456: URL: https://github.com/apache/incubator-stormcrawler/pull/1456#issuecomment-2616665172 Formatting seems to be off. Think you can resolve that by running ``` mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false ``` --

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2025-01-27 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user mstrewe (triggered by rzo1). Head commit for run: 00c854bc43a0abc62bcd84dd379489898dcc0c0b / Maik Piel BasicURLNormalizerTest.java: fix code formatting Report URL: https://github

Re: [PR] #1448 url encoding with lower case letters [incubator-stormcrawler]

2025-01-27 Thread via GitHub
mstrewe commented on code in PR #1456: URL: https://github.com/apache/incubator-stormcrawler/pull/1456#discussion_r1931114610 ## core/src/main/java/org/apache/stormcrawler/filtering/basic/BasicURLNormalizer.java: ## @@ -145,7 +145,7 @@ public class BasicURLNormalizer extends UR