rzo1 commented on code in PR #1456:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1456#discussion_r1931052585
##########
core/src/main/java/org/apache/stormcrawler/filtering/basic/BasicURLNormalizer.java:
##########
@@ -145,7 +145,7 @@ public class BasicURLNormalizer extends URLFilter {
// properly encode characters in path/file using percent-encoding
String file2 = unescapePath(file);
file2 = escapePath(file2);
- if (!file.equals(file2)) {
+ if (!file.toLowerCase().equals(file2.toLowerCase())) {
Review Comment:
why not `equalsIgnoreCase(...)` ? (to avoid the creation of two new String
objects)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
