[GitHub] sqoop pull request #38: Metastore

2017-07-26 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r129511691 --- Diff: src/java/com/cloudera/sqoop/metastore/GeneralJobStorage.java --- @@ -15,22 +15,22 @@ * See the License for the specific language governing

[GitHub] sqoop pull request #38: Metastore

2017-07-26 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r129515098 --- Diff: src/docs/user/metastore-purpose.txt --- @@ -22,6 +22,8 @@ Multiple users and/or remote users can define and execute saved jobs (created with

[GitHub] sqoop pull request #39: Testpullrequest

2017-07-26 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/39 Testpullrequest You can merge this pull request into a Git repository by running: $ git pull https://github.com/szvasas/sqoop testpullrequest Alternatively you can review and apply these

[GitHub] sqoop pull request #39: Testpullrequest

2017-07-26 Thread szvasas
Github user szvasas closed the pull request at: https://github.com/apache/sqoop/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130082337 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130057718 --- Diff: src/docs/user/metastore-purpose.txt --- @@ -22,6 +22,8 @@ Multiple users and/or remote users can define and execute saved jobs (created with

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130063002 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130059198 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -113,11 +121,14 @@ private static final String SQOOP_TOOL_KEY = "sqoop

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062567 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062813 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062375 --- Diff: src/java/org/apache/sqoop/tool/JobTool.java --- @@ -346,8 +361,21 @@ public void applyOptions(CommandLine in, SqoopOptions out

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130084482 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -666,6 +681,14 @@ private void createJobTable() throws SQLException

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130057397 --- Diff: src/docs/Makefile --- @@ -24,8 +24,7 @@ VERSION=Unknown # Building documentation under CentOS causes xmlto to have issues # with

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130082318 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062575 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062627 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130098876 --- Diff: src/test/com/cloudera/sqoop/JobToolTest.java --- @@ -0,0 +1,258 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130098767 --- Diff: src/test/com/cloudera/sqoop/JobToolTest.java --- @@ -0,0 +1,258 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130807571 --- Diff: src/java/org/apache/sqoop/manager/CubridManager.java --- @@ -44,7 +44,7 @@ // driver class to ensure is loaded when making db connection

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130806000 --- Diff: src/docs/user/metastore-purpose.txt --- @@ -22,6 +22,7 @@ Multiple users and/or remote users can define and execute saved jobs (created with

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130812016 --- Diff: src/java/org/apache/sqoop/tool/JobTool.java --- @@ -369,6 +366,61 @@ public void applyOptions(CommandLine in, SqoopOptions out

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130810721 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -666,6 +722,11 @@ private void createJobTable() throws SQLException

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130811043 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -675,6 +736,14 @@ private void initV0Schema() throws SQLException

[GitHub] sqoop pull request #41: Sqoop-3224: Binary ftp transfer mode

2017-12-22 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/41#discussion_r158502479 --- Diff: src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java --- @@ -61,6 +62,9 @@ private void writeObject(Object o) throws IOException

[GitHub] sqoop pull request #41: Sqoop-3224: Binary ftp transfer mode

2017-12-22 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/41#discussion_r158502339 --- Diff: src/java/org/apache/sqoop/SqoopOptions.java --- @@ -308,7 +308,9 @@ public String toString() { // Indicates if the data set is on tape to use

[GitHub] sqoop pull request #41: Sqoop-3224: Binary ftp transfer mode

2017-12-22 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/41#discussion_r158502914 --- Diff: src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java --- @@ -0,0 +1,128 @@ +/** --- End diff -- I am

[GitHub] sqoop pull request #42: Cloudera package removal

2018-01-08 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/42 Cloudera package removal This pull request is created for: https://issues.apache.org/jira/browse/SQOOP-3273 Corresponding RD review is: https://reviews.apache.org/r/65017 You can merge this pull

[GitHub] sqoop pull request #45: Hs2tools

2018-03-20 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/45 Hs2tools You can merge this pull request into a Git repository by running: $ git pull https://github.com/szvasas/sqoop hs2tools Alternatively you can review and apply these changes as the

[GitHub] sqoop pull request #45: Hs2tools

2018-03-20 Thread szvasas
Github user szvasas closed the pull request at: https://github.com/apache/sqoop/pull/45 ---

[GitHub] sqoop pull request #51: Sqoop 3411: PostgresMetaConnectIncrementalImportTest...

2018-11-26 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/51 Sqoop 3411: PostgresMetaConnectIncrementalImportTest fails if metastore tables are absent from the database It turned out that if the DROP TABLE command in

[GitHub] sqoop pull request #52: SQOOP-3413: TestMainframeManager does not restore th...

2018-11-27 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/52 SQOOP-3413: TestMainframeManager does not restore the inner state of AccumuloUtil …loJarPresent now restores the inner state of AccumuloUtil. You can merge this pull request into a Git repository

[GitHub] sqoop pull request #59: SQOOP-3414: Introduce a Gradle build parameter to se...

2018-11-27 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/59 SQOOP-3414: Introduce a Gradle build parameter to set the ignoreTestFailures of the test tasks You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] sqoop pull request #42: Cloudera package removal

2018-11-28 Thread szvasas
Github user szvasas closed the pull request at: https://github.com/apache/sqoop/pull/42 ---

[GitHub] sqoop issue #42: Cloudera package removal

2018-11-28 Thread szvasas
Github user szvasas commented on the issue: https://github.com/apache/sqoop/pull/42 This was committed a long time ago from a patch uploaded to RB so I am resolving this PR> ---

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237795529 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -37,16 +42,28 @@ private static final String HIVE_TYPE_STRING = "STRING";

[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...

2018-11-30 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/62#discussion_r237896212 --- Diff: build.gradle --- @@ -356,6 +359,15 @@ tasks.withType(Test) { ignoreFailures ignoreTestFailures } +project.tasks.each

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238334580 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java --- @@ -65,240 +46,79 @@ * 2. Decimal padding during avro or

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238318482 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -83,27 +89,58 @@ public static String toHiveType(int sqlType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238317375 --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java --- @@ -38,29 +40,30 @@ public class TestHiveTypesForAvroTypeMapping

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238331922 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java --- @@ -65,240 +46,79 @@ * 2. Decimal padding during avro or

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237907910 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -79,8 +85,42 @@ public static String toHiveType(int sqlType) { default

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238326484 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -83,27 +89,58 @@ public static String toHiveType(int sqlType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238331788 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesAvroImportTestBase.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238332023 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesParquetImportTestBase.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237907664 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -79,8 +85,42 @@ public static String toHiveType(int sqlType) { default

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-03 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238334653 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java --- @@ -65,240 +46,79 @@ * 2. Decimal padding during avro or

[GitHub] sqoop pull request #65: SQOOP-3417: Execute Oracle XE tests on Travis CI

2018-12-04 Thread szvasas
GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/65 SQOOP-3417: Execute Oracle XE tests on Travis CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/szvasas/sqoop SQOOP-3417 Alternatively you can

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-04 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238731504 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -83,27 +89,58 @@ public static String toHiveType(int sqlType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-05 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238984816 --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java --- @@ -41,30 +44,49 @@ private final String hiveType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-05 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238984324 --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java --- @@ -41,30 +44,49 @@ private final String hiveType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-05 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238984033 --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java --- @@ -41,30 +44,49 @@ private final String hiveType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-05 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238984411 --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java --- @@ -41,30 +44,49 @@ private final String hiveType

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-05 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r239107983 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesParquetImportTestBase.java --- @@ -0,0 +1,83 @@ +/** + * Licensed to the

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-12-05 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r239108068 --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesParquetImportTestBase.java --- @@ -0,0 +1,83 @@ +/** + * Licensed to the

[GitHub] sqoop pull request #66: SQOOP-3418: Document decimal support in Hive externa...

2018-12-12 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/66#discussion_r240966974 --- Diff: src/docs/user/import.txt --- @@ -838,20 +850,27 @@ $ sqoop import --connect jdbc:mysql://db.foo.com/corp \ Enabling logical

[GitHub] sqoop pull request #66: SQOOP-3418: Document decimal support in Hive externa...

2018-12-12 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/66#discussion_r240958193 --- Diff: src/docs/user/import.txt --- @@ -472,36 +472,48 @@ Enabling Logical Types in Avro and Parquet import for numbers