Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238984033
  
    --- Diff: 
src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java ---
    @@ -41,30 +44,49 @@
     
       private final String hiveType;
       private final Schema schema;
    +  private final SqoopOptions options;
     
    -  @Parameters(name = "hiveType = {0}, schema = {1}")
    +  @Parameters(name = "hiveType = {0}, schema = {1}, options = {2}")
    --- End diff --
    
    I would not add options here, because SqoopOptions does not have a nice 
toString() method so we won't see anything meaningful in the test output.


---

Reply via email to