Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer

2018-11-29 Thread Chris Teoh
> On Nov. 8, 2018, 9:34 p.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java > > Lines 86 (patched) > > > > > > Shouldn't this condition be negated? StringUtils.isBalnk

Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer

2018-11-29 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62523/ --- (Updated Nov. 29, 2018, 10:46 p.m.) Review request for Sqoop. Changes ---

Re: Sqoop build infrastructure improvements

2018-11-29 Thread Boglarka Egyed
Thank you Szabolcs for driving these efforts! +1 for using pull requests from now. Thanks, Bogi On Wed, Nov 28, 2018 at 4:54 PM Szabolcs Vasas wrote: > Dear Sqoop community, > > We have been working on quite a few exciting build infrastructure > improvements recently, I am sending this email t

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-29 Thread fszabo2
GitHub user fszabo2 opened a pull request: https://github.com/apache/sqoop/pull/60 SQOOP-3396: Add parquet numeric support for Parquet in Hive import You can merge this pull request into a Git repository by running: $ git pull https://github.com/fszabo2/sqoop SQOOP-3396 Alter

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703396#comment-16703396 ] ASF GitHub Bot commented on SQOOP-3396: --- GitHub user fszabo2 opened a pull request:

Re: Next release

2018-11-29 Thread Fero Szabo
Hi Attila, Ferenc I would be happy to drive the next release! As for scoping, there is another thread that discusses this topic with the subject: Release to support Hadoop 3 There is only one item missing from that original scope: upgrading Hadoop to 3.x. We'll need to make this upgrade in order

Re: Next release

2018-11-29 Thread Boglarka Egyed
Hi All, +1 for Fero as the release manager of the next release. Here is the link for the previous discussion: https://lists.apache.org/thread.html/f2b3477f4c904ec150c6046f2e230733b2a17c12136618734c3ec1c7@%3Cdev.sqoop.apache.org%3E Based on it Hadoop/Hive/HBase upgrades are missing from the origin

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-29 Thread maugly24
Github user maugly24 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237698979 --- Diff: src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java --- @@ -65,4 +66,21 @@ public String toString() {

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-29 Thread maugly24
Github user maugly24 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237699087 --- Diff: src/test/org/apache/sqoop/importjob/configuration/OracleImportJobTestConfigurationForNumber.java --- @@ -68,4 +68,14 @@ public String toStri

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704038#comment-16704038 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user maugly24 commented on a diff i

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704041#comment-16704041 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user maugly24 commented on a diff i

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-29 Thread maugly24
Github user maugly24 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237698797 --- Diff: src/test/org/apache/sqoop/hive/numerictypes/NumericTypesHiveImportTest.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software F

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704040#comment-16704040 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user maugly24 commented on a diff i

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-29 Thread maugly24
Github user maugly24 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237701227 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -37,16 +42,28 @@ private static final String HIVE_TYPE_STRING = "STRING"; private

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704039#comment-16704039 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user maugly24 commented on a diff i

[jira] [Created] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes

2018-11-29 Thread Attila Szabo (JIRA)
Attila Szabo created SQOOP-3415: --- Summary: Fix gradle test+build when clean applied as the first command + warning issue fixes Key: SQOOP-3415 URL: https://issues.apache.org/jira/browse/SQOOP-3415 Proje

[GitHub] sqoop pull request #61: SQOOP-3415: Fixing gradle clean unittest and gradle ...

2018-11-29 Thread maugly24
GitHub user maugly24 opened a pull request: https://github.com/apache/sqoop/pull/61 SQOOP-3415: Fixing gradle clean unittest and gradle warning issues (Attila Szabo) You can merge this pull request into a Git repository by running: $ git pull https://github.com/maugly24/sqoop S

[jira] [Commented] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704149#comment-16704149 ] ASF GitHub Bot commented on SQOOP-3415: --- GitHub user maugly24 opened a pull request

Re: Sqoop build infrastructure improvements

2018-11-29 Thread Attila Szabó
Hi Szabi, First of all: Big Kudos for the more mature gradle build! I think this is a great step for the whole project! On the front of PRs: I would only make it official if the user management / authorization handling could be somehow automatically bound to the id.apache.org + project privileges

[GitHub] sqoop pull request #61: SQOOP-3415: Fixing gradle clean unittest and gradle ...

2018-11-29 Thread maugly24
Github user maugly24 closed the pull request at: https://github.com/apache/sqoop/pull/61 ---

[jira] [Commented] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704156#comment-16704156 ] ASF GitHub Bot commented on SQOOP-3415: --- Github user maugly24 closed the pull reque

[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...

2018-11-29 Thread maugly24
GitHub user maugly24 opened a pull request: https://github.com/apache/sqoop/pull/62 SQOOP-3415: Fixing gradle clean unittest and gradle warning issues (Attila Szabo) You can merge this pull request into a Git repository by running: $ git pull https://github.com/maugly24/sqoop S

[jira] [Commented] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704158#comment-16704158 ] ASF GitHub Bot commented on SQOOP-3415: --- GitHub user maugly24 opened a pull request

[GitHub] sqoop pull request #63: SQOOP-3393 TestNetezzaExternalTableExportMapper hang...

2018-11-29 Thread dvoros
GitHub user dvoros opened a pull request: https://github.com/apache/sqoop/pull/63 SQOOP-3393 TestNetezzaExternalTableExportMapper hangs Looks like this test only fails when run with all other uniTests. From the logs I've found, that there's already a task_attempt directory (which we

[jira] [Commented] (SQOOP-3393) TestNetezzaExternalTableExportMapper hangs

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704377#comment-16704377 ] ASF GitHub Bot commented on SQOOP-3393: --- GitHub user dvoros opened a pull request: