Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-08-17 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/#review207485 --- Hi Chris, Thank you for the improvements, I have not found any ma

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-08-17 Thread Szabolcs Vasas
> On Aug. 17, 2018, 12:56 p.m., Szabolcs Vasas wrote: > > Hi Chris, > > > > Thank you for the improvements, I have not found any major issues with your > > patch, so I think if you fix the below small things we will be good to go. > > > > Thanks, > > Szabolcs And I have ran the test and third

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-08-17 Thread Chris Teoh
> On Aug. 17, 2018, 10:56 p.m., Szabolcs Vasas wrote: > > Hi Chris, > > > > Thank you for the improvements, I have not found any major issues with your > > patch, so I think if you fix the below small things we will be good to go. > > > > Thanks, > > Szabolcs > > Szabolcs Vasas wrote: > A

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-08-17 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/ --- (Updated Aug. 17, 2018, 11:39 p.m.) Review request for Sqoop. Changes ---

[jira] [Commented] (SQOOP-2649) Support for importing data onto Apache Phoenix tables

2018-08-17 Thread Venkat Ranganathan (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584202#comment-16584202 ] Venkat Ranganathan commented on SQOOP-2649: --- [~danielzafar]  - It would have be