----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/#review207485 -----------------------------------------------------------
Hi Chris, Thank you for the improvements, I have not found any major issues with your patch, so I think if you fix the below small things we will be good to go. Thanks, Szabolcs src/java/org/apache/sqoop/SqoopOptions.java Lines 34 (patched) <https://reviews.apache.org/r/62492/#comment290886> Unused import, please remove it. src/java/org/apache/sqoop/tool/MainframeImportTool.java Line 74 (original) <https://reviews.apache.org/r/62492/#comment290885> This is an unrelated whitespace change, please restore the original state. src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java Lines 46 (patched) <https://reviews.apache.org/r/62492/#comment290888> I don't see any other changes in this class so please restore its original state. src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java Line 24 (original) <https://reviews.apache.org/r/62492/#comment290889> I don't see any other change in this class so please restore the original state. src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java Line 27 (original) <https://reviews.apache.org/r/62492/#comment290890> I don't see any other change in this class so please restore the original state. src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java Lines 22 (patched) <https://reviews.apache.org/r/62492/#comment290887> Unused import. - Szabolcs Vasas On Aug. 13, 2018, 10:52 a.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62492/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2018, 10:52 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3224 > https://issues.apache.org/jira/browse/SQOOP-3224 > > > Repository: sqoop-trunk > > > Description > ------- > > Added --as-binaryfile and --buffersize to support FTP transfer mode switching. > > > Diffs > ----- > > build.xml 084823cf > src/docs/user/import-mainframe.txt abeb7cde > src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf > src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8 > src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21 > > src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java > ea54b07f > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java > 1f78384b > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java > 0b7b5b85 > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java > 8ef30d38 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59 > src/java/org/apache/sqoop/tool/ImportTool.java 478f1748 > src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0 > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb > src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java > 041dfb78 > src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java > PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java > 3547294f > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java > 9b277b2a > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java > be62efd0 > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34 > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194 > > > Diff: https://reviews.apache.org/r/62492/diff/20/ > > > Testing > ------- > > Unit tests. > > Functional testing on mainframe. > > > Thanks, > > Chris Teoh > >
