[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10183527 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala --- @@ -415,6 +415,7 @@ class JavaSparkContext(val sc: SparkContext) extends

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10183713 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -194,12 +194,19 @@ class DAGScheduler

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10184513 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -17,21 +17,23 @@ package org.apache.spark.executor

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10186518 --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10186680 --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10186874 --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10186902 --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10186927 --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/11#discussion_r10188570 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -712,6 +713,10 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD

[GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...

2014-02-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/43#issuecomment-36413341 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1151: Update dev merge script to use spa...

2014-02-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/47#issuecomment-36413458 Thanks tom - merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1121: Use 'avro' profile in Maven.

2014-02-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/49#issuecomment-36414262 Your suggestion of @tgravescs tying this yarn-alpha I think is strictly better. Just updated the patch. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/43#discussion_r10188851 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -84,12 +84,27 @@ private class DiskStore(blockManager: BlockManager, diskManager

[GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...

2014-02-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/43#discussion_r10188872 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -84,12 +84,27 @@ private class DiskStore(blockManager: BlockManager, diskManager

[GitHub] spark pull request: SPARK-1121: Use 'avro' profile in Maven.

2014-02-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/49#issuecomment-36419075 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1084.2 (resubmitted)

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/32#issuecomment-36432409 Hey @srowen I looked through this and it looks good to me. I think there is a merge conflict though, mind bringing this up to master? Then I can merge it. Thanks

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/11#discussion_r10191952 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -712,6 +713,16 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/11#discussion_r10191970 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -208,4 +209,25 @@ class FileSuite extends FunSuite with LocalSparkContext

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/17#discussion_r10192134 --- Diff: docs/java-programming-guide.md --- @@ -127,11 +132,20 @@ class Split extends FlatMapFunction { JavaRDD words = lines.flatMap(new Split

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/17#discussion_r10192261 --- Diff: docs/building-with-maven.md --- @@ -76,3 +78,11 @@ The maven build includes support for building a Debian package containing the as $ mvn

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/17#discussion_r10192279 --- Diff: docs/java-programming-guide.md --- @@ -30,6 +30,12 @@ There are a few key differences between the Java and Scala APIs: classes for key-value

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/17#discussion_r10192306 --- Diff: docs/building-with-maven.md --- @@ -76,3 +78,11 @@ The maven build includes support for building a Debian package containing the as $ mvn

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36436518 Hey @ScrapCodes - this is really cool! It's great that we will get this into Spark 1.0 so that we can support Java 8 lambdas moving forward. I have some high

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/17#discussion_r10192610 --- Diff: docs/building-with-maven.md --- @@ -76,3 +78,11 @@ The maven build includes support for building a Debian package containing the as $ mvn

[GitHub] spark pull request: fix #SPARK-1149 Bad partitioners can cause Spa...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/44#discussion_r10192944 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -847,6 +847,8 @@ class SparkContext( partitions: Seq[Int

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/11#discussion_r10193104 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -642,7 +643,7 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/11#issuecomment-36440024 Hey @CodingCat found a tiny issue but otherwise LGTM - if you patch it I can merge. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/11#issuecomment-36441402 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1150] fix repo location in create scrip...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/48#issuecomment-36441593 thanks, merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Remove remaining references to incubation

2014-03-01 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/51 Remove remaining references to incubation This removes some loose ends not caught by the other (incubating -> tlp) patches. @markhamstra this updates the version as you mentioned earlier. You

[GitHub] spark pull request: [SPARK-1150] fix repo location in create scrip...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/48#issuecomment-36442725 @CodingCat do you mind re-opening this? Something happened and the merge got screwed up so I had to revert it. Somehow the merge script was pulling in a different patch

[GitHub] spark pull request: [SPARK-1150] fix repo location in create scrip...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/52#issuecomment-36442879 Thanks, merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-1100] prevent Spark from overwriting di...

2014-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/11#issuecomment-36442931 Thanks, merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: fix #SPARK-1149 Bad partitioners can cause Spa...

2014-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/44#discussion_r10194343 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -847,6 +847,8 @@ class SparkContext( partitions: Seq[Int

[GitHub] spark pull request: Add Shortest-path computations to graphx.lib w...

2014-03-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/10#issuecomment-36460773 @andy327 would you mind making a JIRA for this? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: Ignore RateLimitedOutputStreamSuite for now.

2014-03-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/54#issuecomment-36469694 Sounds good, merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1084.2 (resubmitted)

2014-03-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/32#issuecomment-36469726 Thanks, merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1121: Include avro for yarn-alpha builds

2014-03-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/49#issuecomment-36471394 Hey guys, I tried building for YARN with 2.2.0 and 0.23.9 and seems like it's working. I'd like to get this in as a build fix, but please re-open SPARK-1121 i

[GitHub] spark pull request: Add Jekyll tag to isolate "production-only" do...

2014-03-02 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/56 Add Jekyll tag to isolate "production-only" doc components. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pwendell/spark j

[GitHub] spark pull request: Add Jekyll tag to isolate "production-only" do...

2014-03-02 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/57 Add Jekyll tag to isolate "production-only" doc components. (0.9 version) You can merge this pull request into a Git repository by running: $ git pull https://github.com/pwendell/sp

[GitHub] spark pull request: Add Jekyll tag to isolate "production-only" do...

2014-03-02 Thread pwendell
Github user pwendell closed the pull request at: https://github.com/apache/spark/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36480448 Hey @ScrapCodes I thought about this a bit more - do you mind moving the java8-tests folder into a new folder called `/extras`? We can put things there that aren&#

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10219868 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/43#discussion_r10226896 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala --- @@ -146,6 +146,12 @@ object BlockFetcherIterator

[GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/43#discussion_r10226983 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala --- @@ -146,6 +146,12 @@ object BlockFetcherIterator

[GitHub] spark pull request: Remove the remoteFetchTime metric.

2014-03-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/62#issuecomment-36575370 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36576064 Hey @ScrapCodes I had some more feedback on documentation and the build stuff. Instead of putting a bunch of comments I just made this pull request into your branch. Do

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36576111 I think once those are in this is basically ready to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10237907 --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10238309 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -17,38 +17,80 @@ package org.apache.spark.ui +import java.io

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10238385 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -17,38 +17,80 @@ package org.apache.spark.ui +import java.io

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10238954 --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10239640 --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36591694 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36592033 @matiez this looks good to me. Any final thoughts? If not I'll merge this in a bit. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [java8API] SPARK-964 Investigate the potential...

2014-03-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/17#issuecomment-36595932 @ScrapCodes hey sure feel free to submit a follow on PR. I'm going to merge this for now. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272169 --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272195 --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272629 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -17,38 +17,80 @@ package org.apache.spark.ui +import java.io

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272659 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -17,38 +17,80 @@ package org.apache.spark.ui +import java.io

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272735 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -17,38 +17,80 @@ package org.apache.spark.ui +import java.io

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272860 --- Diff: core/src/main/scala/org/apache/spark/ui/UISparkListener.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10272892 --- Diff: docs/configuration.md --- @@ -444,7 +444,21 @@ Apart from these, the following properties are also available, and may be useful spark.logConf

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10273534 --- Diff: core/src/main/scala/org/apache/spark/ui/UIReloader.scala --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [WIP] [SPARK-1132] Persisting Web UI through r...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/42#discussion_r10273889 --- Diff: core/src/main/scala/org/apache/spark/ui/UIReloader.scala --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: fix #SPARK-1149 Bad partitioners can cause Spa...

2014-03-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/44#discussion_r10283043 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -847,6 +847,8 @@ class SparkContext( partitions: Seq[Int

[GitHub] spark pull request: Fixed link for latest pyspark api guide

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/83#discussion_r10306225 --- Diff: docs/python-programming-guide.md --- @@ -146,7 +146,7 @@ sc = SparkContext(conf = conf) # API Docs -[API documentation](api

[GitHub] spark pull request: SPARK-1189: Add Security to Spark - Akka, Http...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36762162 Hey @tgravescs I noticed the `SecurityManager` still reads the system properties directly. Any reason this can't be changed to take a `SparkConf` on instantiation

[GitHub] spark pull request: SPARK-1189: Add Security to Spark - Akka, Http...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36762448 Ah I see from your earlier comment that's still a "TODO" perhaps. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: SPARK-1189: Add Security to Spark - Akka, Http...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36778996 @tgravescs Sure thing - but could you make the JIRA a blocker for Spark 1.0? It would be great if you could enumerate what assumptions are broken in the current model

[GitHub] spark pull request: Fixed link for latest pyspark api guide

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/83#discussion_r10317227 --- Diff: docs/python-programming-guide.md --- @@ -146,7 +146,7 @@ sc = SparkContext(conf = conf) # API Docs -[API documentation](api

[GitHub] spark pull request: Improve building with maven docs

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/70#issuecomment-36812734 Thanks, merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [WIP] SPARK-1192: The document for most of the...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/85#issuecomment-36813035 Hey @CodingCat not all of the configs in spark are meant to be externally documented so we'll have to take a bit of time and look through this list. Thanks for

[GitHub] spark pull request: SPARK-1184: Update the distribution tar.gz to ...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/78#issuecomment-36813329 @markgrover Thanks for addressing these issues. I actually didn't realize that downstream integrator were using `maven dist` to build packages. Would you mind add

[GitHub] spark pull request: SPARK-1184: Update the distribution tar.gz to ...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/78#issuecomment-36813430 Hey actually I'll just add this comment in the merge. I'll merge this into master and 0.9 now. --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10330438 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10330672 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10330832 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala --- @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10330871 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala --- @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10331035 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10331185 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkApp.scala --- @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] spark pull request: SPARK-1126. spark-app preliminary

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/86#discussion_r10331562 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkAppArguments.scala --- @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-1189: Add Security to Spark - Akka, Http...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36824999 @tgravescs let me know when you've stopped changing things around. I can do a final pass. If there are just small things we can punt them to a subsequent PR to

[GitHub] spark pull request: Example for cassandra CQL read/write from spar...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/87#issuecomment-36825120 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Example for cassandra CQL read/write from spar...

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/87#discussion_r10331678 --- Diff: examples/src/main/scala/org/apache/spark/examples/CassandraCQLTest.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: Example for cassandra CQL read/write from spar...

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/87#issuecomment-36825193 Hey @anitatailor thanks for contributing this example! Would you mind cleaning up the style a bit (most likely the build will fail due to style issues). The main issue is

[GitHub] spark pull request: Example for cassandra CQL read/write from spar...

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/87#discussion_r10331703 --- Diff: examples/src/main/scala/org/apache/spark/examples/CassandraCQLTest.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: Example for cassandra CQL read/write from spar...

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/87#discussion_r10331715 --- Diff: examples/src/main/scala/org/apache/spark/examples/CassandraCQLTest.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/90#discussion_r10332066 --- Diff: core/pom.xml --- @@ -269,6 +269,37

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/90#discussion_r10332070 --- Diff: core/pom.xml --- @@ -269,6 +269,37

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/90#discussion_r10332109 --- Diff: graphx/pom.xml --- @@ -70,6 +70,10 @@ scalacheck_${scala.binary.version} test + --- End diff

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/90#discussion_r10332154 --- Diff: graphx/pom.xml --- @@ -70,6 +70,10 @@ scalacheck_${scala.binary.version} test + --- End diff

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/90#issuecomment-36827214 Hey @sryza I have a question here. If we shade like this for the `package` target of core, then as far as I understand this will embed a shaded version of `asm` inside of

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/90#issuecomment-36827278 @sryza or maybe if we shade _both_ kryo and asm in the package jar, the shader plug-in is good enough to figure out that one is a dependency of the other and embed both

[GitHub] spark pull request: SPARK-782. Shade ASM

2014-03-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/90#issuecomment-36827486 @sryza to test this I would do a `mvn install` and then try building a simple spark application in sbt or maven against your locally installed version. Then you can look

[GitHub] spark pull request: SPARK-1187, Added missing Python APIs

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/75#issuecomment-36934603 I played around with these and it looks good to me. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/95#discussion_r10360526 --- Diff: docs/running-on-yarn.md --- @@ -82,35 +84,30 @@ For example: ./bin/spark-class org.apache.spark.deploy.yarn.Client

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36936894 @yaoshengzhe this supports "yarn-standalone" for backwards compatibility so you don't need to change your application. The name "yarn-standalone&q

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/95#issuecomment-36936989 @sryza thanks Sandy this looks good to me. @tgraves want to take a look? If not I can merge this tonight - it's just some doc fixes. --- If your project is set up f

[GitHub] spark pull request: SPARK-1197. Change yarn-standalone to yarn-clu...

2014-03-06 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/95#discussion_r10360720 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1243,7 +1245,7 @@ object SparkContext { } scheduler

  1   2   3   4   >