Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/42#discussion_r10183713
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -194,12 +194,19 @@ class DAGScheduler(
}
}
}))
+
+ // Start listening for block manager registration
+
blockManagerMaster.registrationListener.foreach(_.setListenerBus(listenerBus))
}
def addSparkListener(listener: SparkListener) {
listenerBus.addListener(listener)
}
+ def post(event: SparkListenerEvent) {
--- End diff --
it would be better not to have other parts of Spark posting events to the
DAGScheduler. Maybe we could do the following:
1. Move the listener bus to the SparkContext (approved by @kayousterhout)
2. Pass a SparkContext to the DAGScheduler and access it through that. Then
we could remove the Spark env and other arguments currently passed in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
