Re: [VOTE] Officialy Deprecate GraphX in Spark 4

2024-10-03 Thread Hyukjin Kwon
+1 On Fri, 4 Oct 2024 at 07:14, Ángel wrote: > -1 Don’t deprecate GraphX because may be useful for some people and ... > would there be any replacement for that API? Anyway, I don't think > deprecating an API only because it hasn't been updated in ages is a good > practice (but I could be perfec

Re: [VOTE] Single-pass Analyzer for Catalyst

2024-10-03 Thread Mich Talebzadeh
+1 on the assumption that we should phase this release on an incremental basis. Probably will take us to end of release 5. HTH Mich Talebzadeh, Architect | Data Engineer | Data Science | Financial Crime PhD Imperial College London

Re: [VOTE] Single-pass Analyzer for Catalyst

2024-10-03 Thread Wenchen Fan
+1 On Wed, Oct 2, 2024 at 7:50 AM Peter Toth wrote: > +1 > > On Tue, Oct 1, 2024, 08:33 Yang Jie wrote: > >> +1, Thanks >> >> Jie Yang >> >> On 2024/10/01 03:26:40 John Zhuge wrote: >> > +1 (non-binding) >> > >> > On Mon, Sep 30, 2024 at 7:42 PM Gengliang Wang >> > wrote: >> > >> > > +1 >> > >

Re: [VOTE] Officialy Deprecate GraphX in Spark 4

2024-10-03 Thread Wenchen Fan
+1 On Tue, Oct 1, 2024 at 4:20 PM beliefer wrote: > +1. > > I didn't hear users need it. > > > At 2024-10-01 02:01:17, "Holden Karau" wrote: > > I think it has been de-facto deprecated, we haven’t updated it > meaningfully in several years. I think removing the API would be excessive > but depr

Re: [VOTE] Officialy Deprecate GraphX in Spark 4

2024-10-03 Thread Denny Lee
+1 (non-binding) On Thu, Oct 3, 2024 at 7:40 AM Wenchen Fan wrote: > +1 > > On Tue, Oct 1, 2024 at 4:20 PM beliefer wrote: > >> +1. >> >> I didn't hear users need it. >> >> >> At 2024-10-01 02:01:17, "Holden Karau" wrote: >> >> I think it has been de-facto deprecated, we haven’t updated it >>

Re: [VOTE] Single-pass Analyzer for Catalyst

2024-10-03 Thread L. C. Hsieh
+1 On Thu, Oct 3, 2024 at 7:31 AM Wenchen Fan wrote: > > +1 > > On Wed, Oct 2, 2024 at 7:50 AM Peter Toth wrote: >> >> +1 >> >> >> On Tue, Oct 1, 2024, 08:33 Yang Jie wrote: >>> >>> +1, Thanks >>> >>> Jie Yang >>> >>> On 2024/10/01 03:26:40 John Zhuge wrote: >>> > +1 (non-binding) >>> > >>> > O

Re: [VOTE] Officialy Deprecate GraphX in Spark 4

2024-10-03 Thread Ángel
-1 Don’t deprecate GraphX because may be useful for some people and ... would there be any replacement for that API? Anyway, I don't think deprecating an API only because it hasn't been updated in ages is a good practice (but I could be perfectly wrong). El jue, 3 oct 2024, 16:31, Wenchen Fan esc

unsubscribe

2024-10-03 Thread bruce COTTMAN
> On Oct 3, 2024, at 5:44 AM, Fanng wrote: > > - To unsubscribe e-mail: dev-unsubscr...@spark.apache.org

Re: [VOTE] Single-pass Analyzer for Catalyst

2024-10-03 Thread Mich Talebzadeh
With a project manager hat on and having read the SPIP This proposed single-pass Analyzer framework does potentially offer significant long-term benefits in terms of efficiency, maintenance, and stability, especially for large or complex queries.

Re: [VOTE] Single-pass Analyzer for Catalyst

2024-10-03 Thread Vladimir Golubev
Hi Mich! Thank you for this input. Yes, this is exactly the approach I would propose too. Putting the new analyzer under a flag and making the tests pass for both implementations is crucial. We need to compare the logical (analyzed) plans and ensure that they are identical. On Thu, Oct 3, 2024 at

Re: [VOTE] Single-pass Analyzer for Catalyst

2024-10-03 Thread Ángel
+1 El jue, 3 oct 2024, 20:06, Wenchen Fan escribió: > +1 > > On Wed, Oct 2, 2024 at 7:50 AM Peter Toth wrote: > >> +1 >> >> On Tue, Oct 1, 2024, 08:33 Yang Jie wrote: >> >>> +1, Thanks >>> >>> Jie Yang >>> >>> On 2024/10/01 03:26:40 John Zhuge wrote: >>> > +1 (non-binding) >>> > >>> > On Mon,