Re: Closing stale PRs with a GitHub Action

2020-01-27 Thread Hyukjin Kwon
Thanks for doing this Nicholas. 2020년 1월 28일 (화) 오전 8:15, Nicholas Chammas 님이 작성: > A brief update here: At the start of December when I started this thread > we had almost 500 open PRs. Now that the Stale workflow has had time to > catch up, we're down to ~280 open PRs. > > More impressive than

Re: Closing stale PRs with a GitHub Action

2020-01-27 Thread Nicholas Chammas
A brief update here: At the start of December when I started this thread we had almost 500 open PRs. Now that the Stale workflow has had time to catch up, we're down to ~280 open PRs. More impressive than the number of stale PRs that got closed

Re: Closing stale PRs with a GitHub Action

2019-12-15 Thread Nicholas Chammas
Just an FYI to everyone, we’ve merged in an Action to close stale PRs: https://github.com/apache/spark/pull/26877 2019년 12월 8일 (일) 오전 9:49, Hyukjin Kwon 님이 작성: > It doesn't need to exactly follow the conditions I used before as long as > Github Actions can provide other good options or conditions

Re: Closing stale PRs with a GitHub Action

2019-12-08 Thread Hyukjin Kwon
It doesn't need to exactly follow the conditions I used before as long as Github Actions can provide other good options or conditions. I just wanted to make sure the condition is reasonable. 2019년 12월 7일 (토) 오전 11:23, Hyukjin Kwon 님이 작성: > lol how did you know I'm going to read this email Sean? >

Re: Closing stale PRs with a GitHub Action

2019-12-06 Thread Hyukjin Kwon
lol how did you know I'm going to read this email Sean? When I manually identified the stale PRs, I used this conditions below: 1. Author's inactivity over a year. If the PRs were simply waiting for a review, I excluded it from stale PR list. 2. Ping one time and see if there are any updates with

Re: Closing stale PRs with a GitHub Action

2019-12-06 Thread Sean Owen
We used to not be able to close PRs directly, but now we can, so I assume this is as fine a way of doing so, if we want to. I don't think there's a policy against it or anything. Hyukjin how have you managed this one in the past? I don't mind it being automated if the idle time is long and it posts

Re: Closing stale PRs with a GitHub Action

2019-12-06 Thread Nicholas Chammas
That's true, we do use Actions today. I wonder if Apache Infra allows Actions to close PRs vs. just updating commit statuses. I only ask because I remember permissions were an issue in the past when discussing tooling like this. In any case, I'd be happy to submit a PR adding this in if there are

Re: Closing stale PRs with a GitHub Action

2019-12-06 Thread Sean Owen
I think we can add Actions, right? they're used for the newer tests in Github? I'm OK closing PRs inactive for a 'long time', where that's maybe 6-12 months or something. It's standard practice and doesn't mean it can't be reopened. Often the related JIRA should be closed as well but we have done t