Re: ArrayType support in Spark SQL

2016-09-27 Thread Takeshi Yamamuro
Done: https://issues.apache.org/jira/browse/SPARK-17683 On Tue, Sep 27, 2016 at 5:43 AM, Reynold Xin wrote: > Seems fair & easy to support. Can somebody open a JIRA ticket and patch? > > > On Mon, Sep 26, 2016 at 9:05 AM, Takeshi Yamamuro > wrote: > >> Hi, >> >> Since `Literal#default` can hand

Re: ArrayType support in Spark SQL

2016-09-26 Thread Reynold Xin
Seems fair & easy to support. Can somebody open a JIRA ticket and patch? On Mon, Sep 26, 2016 at 9:05 AM, Takeshi Yamamuro wrote: > Hi, > > Since `Literal#default` can handle array types, it seems there is no > strong reason > for unsupporting the type in `Literal#apply`, that is, `functions.li

Re: ArrayType support in Spark SQL

2016-09-26 Thread Takeshi Yamamuro
Hi, Since `Literal#default` can handle array types, it seems there is no strong reason for unsupporting the type in `Literal#apply`, that is, `functions.lit`. https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala#L119 // m

Re: ArrayType support in Spark SQL

2016-09-25 Thread Jason White
Continuing to dig, I encountered: https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala#L125 // TODO(davies): add tests for ArrayType, MapType and StructType I guess others have thought of this already, jus