[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36548137 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12972/ --- If your pr

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36548135 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36547977 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36547975 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r1084 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -41,56 +46,103 @@ private[spark] object JettyUtils extends Logging { type Resp

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r1063 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36542188 Thanks for the detailed review Patrick. I've updated based on the comments except for renaming the Handlers to Servlet and changing to use SparkConf. I will make those

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10221836 --- Diff: docs/configuration.md --- @@ -477,6 +505,21 @@ Apart from these, the following properties are also available, and may be useful Whe

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10221207 --- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala --- @@ -18,25 +18,27 @@ package org.apache.spark.network import org.apa

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10220939 --- Diff: core/src/main/scala/org/apache/spark/network/SecurityMessage.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10219868 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10216724 --- Diff: core/src/main/scala/org/apache/spark/network/ConnectionManager.scala --- @@ -557,7 +754,54 @@ private[spark] class ConnectionManager(port: Int, con

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10216556 --- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala --- @@ -18,25 +18,27 @@ package org.apache.spark.network import org.apa

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10216010 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -135,6 +135,8 @@ class SparkContext( val isLocal = (master == "local" ||

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10215322 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-03-03 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10215150 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36315155 Hey Tom, This patch is looking really great. I took a pretty thorough look through this and there were really only two high level things: 1. Configuration

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10152124 --- Diff: docs/security.md --- @@ -0,0 +1,14 @@ +--- +layout: global +title: Spark Security +--- + +Spark currently supports authenticat

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10151846 --- Diff: core/src/main/scala/org/apache/spark/network/SecurityMessage.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10151554 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -41,56 +46,103 @@ private[spark] object JettyUtils extends Logging { type Respo

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10150334 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -41,56 +46,103 @@ private[spark] object JettyUtils extends Logging { type Respo

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10150320 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -41,56 +46,103 @@ private[spark] object JettyUtils extends Logging { type Respo

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10149280 --- Diff: core/src/main/scala/org/apache/spark/network/ConnectionManager.scala --- @@ -557,7 +754,54 @@ private[spark] class ConnectionManager(port: Int, conf

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10149145 --- Diff: core/src/main/scala/org/apache/spark/network/ConnectionId.scala --- @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144869 --- Diff: docs/configuration.md --- @@ -477,6 +505,21 @@ Apart from these, the following properties are also available, and may be useful Whet

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144822 --- Diff: core/src/main/scala/org/apache/spark/network/ConnectionManager.scala --- @@ -53,6 +54,10 @@ private[spark] class ConnectionManager(port: Int, conf:

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144775 --- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala --- @@ -18,25 +18,27 @@ package org.apache.spark.network import org.apac

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144726 --- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala --- @@ -18,25 +18,27 @@ package org.apache.spark.network import org.apac

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144358 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/ui/WorkerWebUI.scala --- @@ -198,6 +199,6 @@ class WorkerWebUI(val worker: Worker, val workDir: F

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144156 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -100,17 +152,12 @@ private[spark] object JettyUtils extends Logging { * If the

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10144073 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10143842 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10143746 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10142402 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -135,6 +135,8 @@ class SparkContext( val isLocal = (master == "local" || m

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10141554 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10141281 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10141220 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10140917 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10140725 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/33#discussion_r10140602 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36275335 its ready for review. I believe I've addressed all the comments from the previous PR. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36274459 @tgravescs is this ready for another round of review or are you still working on it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36244602 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12918/ --- If your project i

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36244600 Build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36241960 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36241944 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/33#issuecomment-36241945 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: Add Security to Spark - Akka, Http, Connection...

2014-02-27 Thread tgravescs
GitHub user tgravescs opened a pull request: https://github.com/apache/spark/pull/33 Add Security to Spark - Akka, Http, ConnectionManager, UI use servlets resubmit pull request. was https://github.com/apache/incubator-spark/pull/332. You can merge this pull request into a Git rep