Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/33#discussion_r10150334
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -41,56 +46,103 @@ private[spark] object JettyUtils extends Logging {
type Responder[T] = HttpServletRequest => T
// Conversions from various types of Responder's to jetty Handlers
- implicit def jsonResponderToHandler(responder: Responder[JValue]):
Handler =
+ implicit def jsonResponderToHandler(responder: Responder[JValue]):
HttpServlet =
createHandler(responder, "text/json", (in: JValue) =>
pretty(render(in)))
- implicit def htmlResponderToHandler(responder: Responder[Seq[Node]]):
Handler =
+ implicit def htmlResponderToHandler(responder: Responder[Seq[Node]]):
HttpServlet =
createHandler(responder, "text/html", (in: Seq[Node]) => "<!DOCTYPE
html>" + in.toString)
- implicit def textResponderToHandler(responder: Responder[String]):
Handler =
+ implicit def textResponderToHandler(responder: Responder[String]):
HttpServlet =
createHandler(responder, "text/plain")
- def createHandler[T <% AnyRef](responder: Responder[T], contentType:
String,
- extractFn: T => String = (in: Any) =>
in.toString): Handler = {
- new AbstractHandler {
- def handle(target: String,
- baseRequest: Request,
- request: HttpServletRequest,
+ def createHandler[T <% AnyRef](responder: Responder[T], contentType:
String,
--- End diff --
and this could be... `createServlet`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
