Re: [VOTE] Release Spark 3.1.1 (RC3)

2021-02-23 Thread Maxim Gekk
+1 (non-binding) On Wed, Feb 24, 2021 at 2:42 AM Cheng Su wrote: > +1 (non-binding) > > > > *From: *Takeshi Yamamuro > *Date: *Tuesday, February 23, 2021 at 3:30 PM > *To: *Hyukjin Kwon , dev > *Subject: *Re: [VOTE] Release Spark 3.1.1 (RC3) > > > > +1 > > > > On Wed, Feb 24, 2021 at 2:07 AM J

Re: [VOTE] Release Spark 3.1.1 (RC3)

2021-02-23 Thread Cheng Su
+1 (non-binding) From: Takeshi Yamamuro Date: Tuesday, February 23, 2021 at 3:30 PM To: Hyukjin Kwon , dev Subject: Re: [VOTE] Release Spark 3.1.1 (RC3) +1 On Wed, Feb 24, 2021 at 2:07 AM John Zhuge mailto:jzh...@apache.org>> wrote: +1 (non-binding) On Mon, Feb 22, 2021 at 10:19 PM Gengliang

Re: [VOTE] Release Spark 3.1.1 (RC3)

2021-02-23 Thread Takeshi Yamamuro
+1 On Wed, Feb 24, 2021 at 2:07 AM John Zhuge wrote: > +1 (non-binding) > > On Mon, Feb 22, 2021 at 10:19 PM Gengliang Wang wrote: > >> +1 (non-binding) >> >> On Tue, Feb 23, 2021 at 10:56 AM Yuming Wang wrote: >> >>> +1 @Sean Owen I do not have this issue: >>> >>> [info] SparkSQLEnvSuite: >

Re: [build system] jenkins wedged, going to restart after current builds finish

2021-02-23 Thread shane knapp ☠
this was done about an hour ago... rebooted several of the workers to clear out lingering builds, and one worker had an SSD fail on boot and is currently offline. shane On Tue, Feb 23, 2021 at 10:13 AM shane knapp ☠ wrote: > EOM > > -- > Shane Knapp > Computer Guy / Voice of Reason > UC Berkel

[build system] jenkins wedged, going to restart after current builds finish

2021-02-23 Thread shane knapp ☠
EOM -- Shane Knapp Computer Guy / Voice of Reason UC Berkeley EECS Research / RISELab Staff Technical Lead https://rise.cs.berkeley.edu

Re: K8s integration test failure ("credentials Jenkins is using is probably wrong...")

2021-02-23 Thread shane knapp ☠
stupid bash variable assignment. i'm surprised this has lingered for as long as it had (3 years). it's fixed and shouldn't be an issue any more. On Tue, Feb 23, 2021 at 9:28 AM shane knapp ☠ wrote: > the AmplabJenks bot's github creds are out of date, which is causing that > non-fatal error.

Re: K8s integration test failure ("credentials Jenkins is using is probably wrong...")

2021-02-23 Thread shane knapp ☠
the AmplabJenks bot's github creds are out of date, which is causing that non-fatal error. however, if you scroll back you'll see that minikube actually failed to start. that should have definitely failed the build, so i'll look at the job's bash logic and see what we missed. also, that worker (

Re: [VOTE] Release Spark 3.1.1 (RC3)

2021-02-23 Thread John Zhuge
+1 (non-binding) On Mon, Feb 22, 2021 at 10:19 PM Gengliang Wang wrote: > +1 (non-binding) > > On Tue, Feb 23, 2021 at 10:56 AM Yuming Wang wrote: > >> +1 @Sean Owen I do not have this issue: >> >> [info] SparkSQLEnvSuite: >> 19:45:15.430 WARN org.apache.hadoop.util.NativeCodeLoader: Unable t

Re: Please use Jekyll via "bundle exec" from now on

2021-02-23 Thread Attila Zsolt Piros
With this commit a github workflow introduced for the PRs of the *spark-website* repo. It contains an action to check: - whether the generation was complete (it contains all the generated HTMLs for the

Re: Auto-closing PRs or How to get reviewers' attention

2021-02-23 Thread Matthew Powers
Enrico - thanks for sharing your experience. I recently got a couple of PRs merged and my experience was different. I got lots of feedback from several maintainers (thank you very much!). Can't speak to your PRs specifically, but can give the general advice that pivoting code based on maintainer

Re: K8s integration test failure ("credentials Jenkins is using is probably wrong...")

2021-02-23 Thread Sean Owen
Shane would you know? May be a problem with a single worker. On Tue, Feb 23, 2021 at 8:46 AM Phillip Henry wrote: > > Hi, > > Silly question: the Jenkins build for my PR is failing but it seems > outside of my control. What must I do to remedy this? > > I've submitted > > https://github.com/apac

K8s integration test failure ("credentials Jenkins is using is probably wrong...")

2021-02-23 Thread Phillip Henry
Hi, Silly question: the Jenkins build for my PR is failing but it seems outside of my control. What must I do to remedy this? I've submitted https://github.com/apache/spark/pull/31535 but Spark QA is telling me "Kubernetes integration test status failure". The Jenkins job says "SUCCESS" but al

Re: Auto-closing PRs or How to get reviewers' attention

2021-02-23 Thread Sean Owen
Yes, committers are added regularly. I don't think that changes the situation for most PRs that perhaps just aren't suitable to merge. Again the best thing you can do is make it as easy to merge as possible and find people who have touched the code for review. This often works out. On Tue, Feb 23,

Re: Auto-closing PRs or How to get reviewers' attention

2021-02-23 Thread Enrico Minack
Am 18.02.21 um 16:34 schrieb Sean Owen: One other aspect is that a committer is taking some degree of responsibility for merging a change, so the ask is more than just a few minutes of eyeballing. If it breaks something the merger pretty much owns resolving it, and, the whole project owns any c

Re: [DISCUSS] SPIP: FunctionCatalog

2021-02-23 Thread Wenchen Fan
+1, as I already proposed we can move forward with PRs > To move forward, how about we implement the function loading and binding first? Then we can have PRs for both the individual-parameters (I can take it) and row-parameter approaches, if we still can't reach a consensus at that time and need t

Re: [DISCUSS] SPIP: FunctionCatalog

2021-02-23 Thread Dongjoon Hyun
I've been still supporting Ryan's SPIP (original PR and its extension proposal discussed here) because of its simplicity. According to this email thread context, I also understand the different perspectives like Hyukjin's concerns about having multiple ways and Wenchen's proposal and rationales.