Re: Review Request 51689: Fix SAMZA-1012 - Generated changelog mappings are not consistent

2016-09-13 Thread Tommy Becker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51689/ --- (Updated Sept. 13, 2016, 8:26 a.m.) Review request for samza. Bugs: SAMZA-101

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-13 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review148730 --- Good patch. Doc updates are missing. Some initial feedback bel

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-13 Thread Hai Lu
> On Sept. 13, 2016, 12:33 a.m., Yi Pan (Data Infrastructure) wrote: > > Still in the middle but don't want to lose what I had up to now. Also in the middle of addressing all the feedbacks. Have all the changes locally. Will push them altogether later. Thanks again for your review! > On Sept.

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-13 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 13, 2016, 9 p.m.) Review request for samza, Chris Pettitt, Navin

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-13 Thread Xinyu Liu
> On Sept. 7, 2016, 6:01 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/api/overview.md, line 49 > > > > > > This is a bit confusing. If I read these two comment lines as pseudo > >

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-13 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review148787 --- I started prototyping the following usecase: ` * A task that join

Samza kinesis implementation

2016-09-13 Thread Shekar Tippur
Hello, I am looking for direction on implementing samza over Kinesis. I see that jira ticket is in unresolved state. https://issues.apache.org/jira/plugins/servlet/mobile#issue/SAMZA-489 I also saw that with Samza release 0.10 this implementation is in place. Appreciate any pointers on this. S

Re: Samza kinesis implementation

2016-09-13 Thread Navina Ramesh (Apache)
Hi Shekar, Last year, we had one of the Samza committers, Yan Fang, mentor a PhD student - Renato ,as a part of the GSoC program, where they worked on integrating Samza with Amazon Kinesis. I have cc'd the two of them so they can provide you more context. Here is the presentation from ApacheCon 20

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-13 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148824 --- Fix it, then Ship it! lgtm overall. Thanks! docs/learn/docume

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-13 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148826 --- Fix it, then Ship it! I think I have all my comments called out

Re: Review Request 51516: SAMZA-702: Document the significance of all the different metrics emitted by Samza out of the box

2016-09-13 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51516/#review148832 --- Ship it! Ship It! - Navina Ramesh On Sept. 2, 2016, 9:10 a.m

Re: Samza kinesis implementation

2016-09-13 Thread Shekar Tippur
Thanks Navina. This presentation is quite detailed. Let me see if I can work off of this. Thanks again. I appreciate any further documentation as well. - Shekar On Tue, Sep 13, 2016 at 5:30 PM, Navina Ramesh (Apache) wrote: > Hi Shekar, > > Last year, we had one of the Samza committers, Yan

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-13 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review148780 --- Thanks for pulling it off! Two high-level comments: a) I would pre

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-13 Thread Hai Lu
> On Sept. 13, 2016, 1:37 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/partitioner/DirectoryPartitioner.java, > > line 58 > > > > > > nit: since the input whiteL

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-13 Thread Yi Pan (Data Infrastructure)
> On Sept. 13, 2016, 12:33 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/HdfsSystemAdmin.java, > > line 91 > > > > > > You can do: > > try(FSDataOutputStream