Re: Review Request 35933: SAMZA-449 Expose RocksDB statistic

2015-06-30 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35933/#review89902 --- samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDb

Re: Review Request 35933: SAMZA-449 Expose RocksDB statistic

2015-06-30 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35933/#review89913 --- samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDb

Re: Review Request 35397: Fix SAMZA-697

2015-06-30 Thread Guozhang Wang
> On June 17, 2015, 9:03 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala, > > lines 103-111 > > > > > > a little concernted about this. This means we will load the cla

Re: Review Request 35397: Fix SAMZA-697

2015-06-30 Thread Guozhang Wang
> On June 18, 2015, 11:58 p.m., Boris Shkolnik wrote: > > samza-core/src/main/java/org/apache/samza/task/TaskClassLoader.java, line 50 > > > > > > Do we have test for this case? We check this case in TestTaskClassLoade

Re: Review Request 35933: SAMZA-449 Expose RocksDB statistic

2015-06-30 Thread Gustavo Anatoly F . V . SolĂ­s
> On Junho 30, 2015, 3:25 p.m., Yan Fang wrote: > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbStatistic.scala, > > line 25 > > > > > > It's better to use the name RocksDbStatisticMetrics to ind

Re: Review Request 35397: Fix SAMZA-697

2015-06-30 Thread Guozhang Wang
> On June 19, 2015, 8:59 a.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 443 > > > > > > Users who extends and implements StreamTask usually have the

Re: Review Request 35397: Fix Samza-697

2015-06-30 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated June 30, 2015, 6:29 p.m.) Review request for samza. Summary (updated

Re: Review Request 35397: v1

2015-06-30 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35397/ --- (Updated June 30, 2015, 6:28 p.m.) Review request for samza. Summary (updated

Re: [VOTE] Apache Samza 0.9.1 RC1

2015-06-30 Thread Milinda Pathirage
+1 (non-binding) Verified signature. Tested locally using ./bin/check-all.sh. Thanks Milinda On Tue, Jun 30, 2015 at 2:10 AM, Yan Fang wrote: > +1 > > Verified MD5, Signature. > > Tested locally. > > Thanks, > > Fang, Yan > yanfang...@gmail.com > > On Sun, Jun 28, 2015 at 12:31 PM, Yi Pan wro

Thoughts and obesrvations on Samza

2015-06-30 Thread Chris Riccomini
Hey all, I have had some discussions with Samza engineers at LinkedIn and Confluent and we came up with a few observations and would like to propose some changes. We've observed some things that I want to call out about Samza's design, and I'd like to propose some changes. * Samza is dependent u

Re: [VOTE] Apache Samza 0.9.1 RC1

2015-06-30 Thread Chris Riccomini
+1 Verified MD5, and asc signature. Build locally, and all tests pass. Cheers, Chris On Tue, Jun 30, 2015 at 1:26 PM, Milinda Pathirage wrote: > +1 (non-binding) > > Verified signature. Tested locally using ./bin/check-all.sh. > > Thanks > Milinda > > On Tue, Jun 30, 2015 at 2:10 AM, Yan Fang

Re: Thoughts and obesrvations on Samza

2015-06-30 Thread Jay Kreps
Hey guys, This came out of some conversations Chris and I were having around whether it would make sense to use Samza as a kind of data ingestion framework for Kafka (which ultimately lead to KIP-26 "copycat"). This kind of combined with complaints around config and YARN and the discussion around

Re: Thoughts and obesrvations on Samza

2015-06-30 Thread Jay Kreps
Looks like gmail mangled the code example, it was supposed to look like this: Properties props = new Properties(); props.put("bootstrap.servers", "localhost:4242"); StreamingConfig config = new StreamingConfig(props); config.subscribe("test-topic-1", "test-topic-2"); config.processor(ExampleStream