----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35933/#review89902 -----------------------------------------------------------
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala (line 150) <https://reviews.apache.org/r/35933/#comment142781> it should accept the "metrics" (from line 143) as the third parameter. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala (line 243) <https://reviews.apache.org/r/35933/#comment142780> add some doc here, saying something like, calling this method will expose RocksDB statistic to a metric, etc. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbStatistic.scala (line 25) <https://reviews.apache.org/r/35933/#comment142776> It's better to use the name RocksDbStatisticMetrics to indicate it is a metrics. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbStatistic.scala (line 40) <https://reviews.apache.org/r/35933/#comment142777> can we use the lower case for the all names of metrics? It's better to keep the name convension consistent in the Samza. - Yan Fang On June 26, 2015, 5:56 p.m., Gustavo Anatoly F. V. Solís wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35933/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 5:56 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > RocksDB statistic > > > Diffs > ----- > > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > a423f7bd6c43461e051b5fd1f880dd01db785991 > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbStatistic.scala > PRE-CREATION > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala > a428a16bc1e9ab4980a6f17db4fd810057d31136 > > Diff: https://reviews.apache.org/r/35933/diff/ > > > Testing > ------- > > > Thanks, > > Gustavo Anatoly F. V. Solís > >
