Re: Review Request 34009: WIP: SAMZA-650 window store implementation

2015-05-12 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83395 --- samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.ja

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

2015-05-12 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83396 --- Hi, Yi, Patch looks good overall. I think we should get this into s

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

2015-05-12 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83405 --- samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/St

Re: Input stream partition to task mapping

2015-05-12 Thread Susan Luong
Hi Yan, We are looking for a solution for a similar problem. Currently, we have 2 input streams, one transactions stream (5 partitions) and one rules stream (one partition). I have a custom SystemStreamPartitionGrouper that assigns the SSPs like so:. taskName0: Trx stream partition 0, Rules stre

Re: Errors and hung job on broker shutdown

2015-05-12 Thread Guozhang Wang
Hmm, that is a little wired since if the ip addresses are not changed then the producer should be able to re-connect. I checked your logs again, and only saw two ip addresses (10.0.0.40, 10.0.2.105), and the thrown exceptions indicate that the producer cannot connect to them (I am assuming the logs

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

2015-05-12 Thread Milinda Pathirage
> On May 12, 2015, 12:58 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/ExecutionPlanner.java, > > line 114 > > > > > > In the new operator API, I me

Re: Errors and hung job on broker shutdown

2015-05-12 Thread Dan
I think this is probably a different error. I've also posted this to the Kafka list and I think it's due to bugs in the broker metadata update code in the new Java producer. So there are probably not any Samza issues from our side I think. Other than it appearing to be frozen as the producer is fai

Re: Review Request 33280: [SAMZA-561] Basic streaming SQL query planning support

2015-05-12 Thread Milinda Pathirage
> On May 12, 2015, 12:58 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/TypeAwareOperatorSpec.java, > > line 34 > > > > > > What about the operators w/

Re: Review Request 33735: RocksDB TTL support

2015-05-12 Thread Mohamed Mahmoud (El-Geish)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83438 --- docs/learn/documentation/versioned/jobs/configuration-table.html

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

2015-05-12 Thread Yi Pan (Data Infrastructure)
> On May 12, 2015, 2:36 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java, line > > 62 > > > > > > I assume this is the system time. If yes, may be having a brief

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

2015-05-12 Thread Yi Pan (Data Infrastructure)
> On May 12, 2015, 2:39 p.m., Milinda Pathirage wrote: > > Hi, Yi, > > > > Patch looks good overall. I think we should get this into samza-sql branch > > first and change the SAMZA-561 patch to work with latest API changes. Thanks a lot! I am addressing the comments/issues from you and from my

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

2015-05-12 Thread Yi Pan (Data Infrastructure)
> On May 12, 2015, 3:07 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java, > > line 83 > > > > > > Don't we need to make this final because we are

Re: Input stream partition to task mapping

2015-05-12 Thread Yan Fang
Hi Susan, -- " I have a custom SystemStreamPartitionGrouper" -- this is a very good try! -- "However, it looks like messages from the Rules stream are going to only one task instance, and not to all of them like I hoped. I have them running in the same container. Is it because there is only one o

Review Request 34155: SAMZA-643: Improve error message for null stream in OutgoingMessageEnvelope

2015-05-12 Thread Gustavo Anatoly F . V . SolĂ­s
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34155/ --- Review request for samza. Repository: samza Description --- Checking str