----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review83438 -----------------------------------------------------------
docs/learn/documentation/versioned/jobs/configuration-table.html <https://reviews.apache.org/r/33735/#comment134425> Please add the suffix ".ms": http://samza.apache.org/contribute/coding-guide.html#Configuration Configuration is the final third of our “UI”. All configuration names that define time must end with .ms (e.g. foo.bar.ms=1000). I understand that the current implementation of the RocksDB TTL doesn't support granularity higher than seconds, but: * we can convert, and round, to seconds (since TTL is not exact anyways) * in the future if MS are supported, no need to change the contract here samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/33735/#comment134426> This kind of polymorphism should be accomplished via virtual methods; extend and override. The factory should inspect the config, and determine whether to return a RocksDbKeyValueStore or a RocksDbKeyValueStoreWithTtl samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala <https://reviews.apache.org/r/33735/#comment134428> Why are we re-testing RocksDB's TTL here? Is there a way to query RocksDB to check whether or not the desired options were used when the DB was opened? - Mohamed Mahmoud (El-Geish) On May 6, 2015, 8:55 p.m., Naveen Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33735/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 8:55 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > RocksDB TTL support > https://issues.apache.org/jira/browse/SAMZA-537 > https://issues.apache.org/jira/browse/SAMZA-442 > > Please ignore the maven link added to build.gradle, I'll remove it once I > validate the release is good. > > > Diffs > ----- > > build.gradle ebad6eb27372d13bdb76506db2d4372b128f3c1e > docs/learn/documentation/versioned/jobs/configuration-table.html > 728197d01d1e3f551ea53e2a14e97df44e29ee19 > gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala > 5ab68590a4ed2686d730344665e25776cade6add > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > 66c2a0dc2e38e21f951727a30f0987776ac52fe2 > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala > PRE-CREATION > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > 50dfc10bb053d74dba70fdbce0ef87609ba447ea > > Diff: https://reviews.apache.org/r/33735/diff/ > > > Testing > ------- > > Added Unit test > > > Thanks, > > Naveen Somasundaram > >
