Review SAMZA-544

2015-02-24 Thread Chris Riccomini
Hey all, Could I get a review for: https://issues.apache.org/jira/browse/SAMZA-544 Thanks. Cheers, Chris

Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Milinda Pathirage
Hi Devs, I tried to add a new integration test to samza-test and found out that the second test always fail if that test depends on a different job. I had two *samza_job_deployer.start *calls for 'negate_number' job and the test job I implemented. But my test always failed (but negate_number test

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Chris Riccomini
Hey Milinda, Could you post your code somewhere? I have two jobs running in smoke_tests.py on SAMZA-544. Maybe that helps? Cheers, Chris On Tue, Feb 24, 2015 at 8:58 AM, Milinda Pathirage wrote: > Hi Devs, > > I tried to add a new integration test to samza-test and found out that the > second

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Milinda Pathirage
Hi Chris, Will push it to a branch in my Samza fork and send you the link. Thanks Milinda On Tue, Feb 24, 2015 at 12:02 PM, Chris Riccomini wrote: > Hey Milinda, > > Could you post your code somewhere? I have two jobs running in > smoke_tests.py on SAMZA-544. Maybe that helps? > > Cheers, > Ch

Re: Review Request 31290: SAMAZ-544

2015-02-24 Thread Chinmay Soman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31290/#review73828 --- Ship it! - Chinmay Soman On Feb. 23, 2015, 12:23 a.m., Chris Ricc

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Milinda Pathirage
Hi Chris, You can find my changes at https://github.com/milinda/samza/tree/samza-integration-tests Thanks Milinda On Tue, Feb 24, 2015 at 12:04 PM, Milinda Pathirage wrote: > Hi Chris, > > Will push it to a branch in my Samza fork and send you the link. > > Thanks > Milinda > > On Tue, Feb 24,

Re: Review Request 31290: SAMAZ-544

2015-02-24 Thread Naveen Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31290/#review73830 --- Ship it! Ship It! - Naveen Somasundaram On Feb. 23, 2015, 12:23

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Chris Riccomini
Hey Milinda, Could you start by rebasing to the latest 0.9.0 branch? There have been some changes there to run multiple jobs. For example, jobs are now started as part of the test_* methods, rather than in deployment.py: https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob_plain;f=samza-te

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Milinda Pathirage
Hi Chris, Thanks for the info. I'll rebase to the latest 0.9.0 branch. I think its better if we can rebase the samza-sql branch. I'm trying to get simple query where query working end-to-end with avro messages. Thanks Milinda On Tue, Feb 24, 2015 at 12:35 PM, Chris Riccomini wrote: > Hey Milin

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Milinda Pathirage
Looks like rebasing is already done. I didn't see the commit messages. Milinda On Tue, Feb 24, 2015 at 3:08 PM, Milinda Pathirage wrote: > Hi Chris, > > Thanks for the info. I'll rebase to the latest 0.9.0 branch. I think its > better if we can rebase the samza-sql branch. I'm trying to get sim

Re: Integration test deployment script doesn't work when there are two jobs

2015-02-24 Thread Chris Riccomini
Hey Milinda, I rebased earlier this morning, and pushed samza-sql on Apache. If you rebase your fork off of this, you should be seeing the current state of the integration tests. Cheers, Chris On Tue, Feb 24, 2015 at 12:09 PM, Milinda Pathirage wrote: > Looks like rebasing is already done. I d

Re: Reprocessing and windowing

2015-02-24 Thread Geoffry Sumter
Roger: That was an extremely clear and helpful talk, the described approach fits my usecase nearly perfectly, thanks! Yi: I'd love to give feedback, I'll add myself to the task. On Mon, Feb 23, 2015 at 6:21 PM, Yi Pan wrote: > Hey, Geoffry, > > We have started some work in SAMZA-552 to create a

Review Request 31392: SAMZA-555

2015-02-24 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31392/ --- Review request for samza. Bugs: SAMZA-555 https://issues.apache.org/jira/br

Test failure in samza-sql branch

2015-02-24 Thread Milinda Pathirage
Hi Devs, Has anyone seen following test failure: testShouldGetOldestNewestAndNextOffsets FAILED java.lang.AssertionError: expected:<0> but was: at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.failNotEquals(Assert.java:645) at org.junit.Assert.assertEqu

Review Request 31405: Serde Implementation or AvroData (SAMZA-575)

2015-02-24 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31405/ --- Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Nav

Re: Test failure in samza-sql branch

2015-02-24 Thread Chris Riccomini
Hey Milinda, No, I haven't seen this fail. Is this transient or does it happen every time? I ran a bin/check-all.sh after the merge this morning, and didn't see any failures. Cheers, Chris On Tuesday, February 24, 2015, Milinda Pathirage wrote: > Hi Devs, > > Has anyone seen following test fai