----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31405/ -----------------------------------------------------------
Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Navina Ramesh. Bugs: SAMZA-575 https://issues.apache.org/jira/browse/SAMZA-575 Repository: samza Description ------- Serde implementation for AvroData Diffs ----- samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31405/diff/ Testing ------- ./gradlew :samza-sql:test passed ./bin/check-all.sh gave below error which is not related to this patch. testShouldGetOldestNewestAndNextOffsets FAILED java.lang.AssertionError: expected:<0> but was:<null> at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.failNotEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:126) at org.junit.Assert.assertEquals(Assert.java:145) at org.apache.samza.system.kafka.TestKafkaSystemAdmin.testShouldGetOldestNewestAndNextOffsets(TestKafkaSystemAdmin.scala:239) Thanks, Milinda Pathirage