Review Request 30920: SAMZA-554: Simplify serde configuration by providing default serde names

2015-02-12 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30920/ --- Review request for samza. Bugs: SAMZA-554 https://issues.apache.org/jira/br

Review Request 30937: SAMZA-522

2015-02-12 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30937/ --- Review request for samza. Bugs: SAMZA-522 https://issues.apache.org/jira/br

Re: Review Request 30920: SAMZA-554: Simplify serde configuration by providing default serde names

2015-02-12 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30920/#review72183 --- samza-core/src/main/scala/org/apache/samza/container/SamzaContainer

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Chris Riccomini
Hey Julian, > The rule of thumb I’ve learned integrating Calcite into Hive is that only a branch should depend on snapshot versions of another component This is very practical. I hadn't considered the Calcite dependency issue when I pushed for merging into master rather than a branch. Based on t

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Milinda Pathirage
I am +1 for this approach. Milinda On Thu, Feb 12, 2015 at 11:22 AM, Chris Riccomini wrote: > Hey Julian, > > > The rule of thumb I’ve learned integrating Calcite into Hive is that only > a branch should depend on snapshot versions of another component > > This is very practical. I hadn't consi

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Jakob Homan
+1, assuming we're keeping RTC on the branch (, Jakob said pedantically). On 12 February 2015 at 08:25, Milinda Pathirage wrote: > I am +1 for this approach. > > Milinda > > On Thu, Feb 12, 2015 at 11:22 AM, Chris Riccomini > wrote: > >> Hey Julian, >> >> > The rule of thumb I’ve learned integra

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Chris Riccomini
@Jakob, totally agree. I think the semantics of the SQL module won't change. RTC, experimental, more lax on tests/docs. When we commit into master, we can enforce much stronger test/doc requirements. That's what I'm thinking. On Thu, Feb 12, 2015 at 9:26 AM, Jakob Homan wrote: > +1, assuming we'

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Julian Hyde
+1 I've pushed a snapshot, versioned "1.1-chi-incubating-SNAPSHOT", and based on https://github.com/julianhyde/incubator-calcite/commit/b8a91c31859b6901976de8dcad43afd4877cad36. See https://repository.apache.org/content/repositories/snapshots/org/apache/calcite/calcite/ > On Feb 12, 2015, at

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Milinda Pathirage
Thanks Julian. @Chris, I'll update the patch with Calcite version change. On Thu, Feb 12, 2015 at 1:56 PM, Julian Hyde wrote: > +1 > > I've pushed a snapshot, versioned "1.1-chi-incubating-SNAPSHOT", and based > on > https://github.com/julianhyde/incubator-calcite/commit/b8a91c31859b6901976de8d

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Chris Riccomini
Hey all, Cool. I'll revert samza-sql commits, and cut a branch, then re-apply SAMZA-482 and SAMZA-484. Cheers, Chris On Thu, Feb 12, 2015 at 12:06 PM, Milinda Pathirage wrote: > Thanks Julian. > > @Chris, I'll update the patch with Calcite version change. > > On Thu, Feb 12, 2015 at 1:56 PM, J

Re: Review Request 30781: SAMZA-548

2015-02-12 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30781/ --- (Updated Feb. 12, 2015, 9:11 p.m.) Review request for samza. Bugs: SAMZA-548

Re: Review Request 30781: SAMZA-548

2015-02-12 Thread Chris Riccomini
> On Feb. 9, 2015, 7:52 p.m., Navina Ramesh wrote: > > samza-test/src/main/python/samza_job_yarn_deployer.py, line 204 > > > > > > What are the final job states that is returned by Yarn? It can be any of FINAL, FAILED

Re: Review Request 30781: SAMZA-548

2015-02-12 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30781/ --- (Updated Feb. 12, 2015, 9:16 p.m.) Review request for samza. Bugs: SAMZA-548

Re: Review Request 30825: SAMZA-547: Add Java Serializable Serde

2015-02-12 Thread Ruslan Khafizov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30825/ --- (Updated Feb. 12, 2015, 10:18 p.m.) Review request for samza. Repository: sam

Re: [DISCUSS] SQL workflow

2015-02-12 Thread Chris Riccomini
Hey all, I've reverted SAMZA-482 and SAMZA-484 on master, and moved them into a new branch called 'samza-sql': https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tree;h=refs/heads/samza-sql;hb=refs/heads/samza-sql Cheers, Chris On Thu, Feb 12, 2015 at 1:03 PM, Chris Riccomini wrote: > Hey